public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@cygnus.com>
To: Insight List <insight@sourceware.cygnus.com>
Subject: rename to insight
Date: Tue, 21 Nov 2000 16:03:00 -0000	[thread overview]
Message-ID: <874s10dfwt.fsf@creche.cygnus.com> (raw)

Here's a different patch to have an `insight' executable.
This patch takes the shell script approach.

I like this approach because it doesn't cost much.  A distributor
(Debian, Red Hat, whoever) can build a single gdb.  By default this
gdb will just be gdb, but if the user invokes `insight' they get the
GUI.

I dislike the other approach (relinking for insight) because it makes
it harder for packagers.

For instance, how is documentation to be handled?  Only one package
can have a given file, so the packagers must either rename the insight
documentation (but why have two identical copies of the gdb docs?) or
leave the docs out of one package (eww), or make a new package holding
only the docs (also eww).

2000-11-21  Tom Tromey  <tromey@cygnus.com>

	* insight: New file.
	* Makefile.in (install-gdbtk): Install `insight'.
	* top.c (use_windows): Default to 0.

Tom

Index: insight
===================================================================
RCS file: insight
diff -N insight
--- /dev/null	Tue May  5 13:32:27 1998
+++ insight	Tue Nov 21 15:58:01 2000
@@ -0,0 +1,23 @@
+#! /bin/sh
+
+# GUI wrapper for gdb.
+# Copyright 1986-2000 Free Software Foundation, Inc.
+
+# This file is part of GDB.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330,
+# Boston, MA 02111-1307, USA.
+
+exec gdb -w ${1+"$@"}
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.47
diff -u -r1.47 Makefile.in
--- Makefile.in	2000/11/10 23:02:56	1.47
+++ Makefile.in	2000/11/21 23:58:04
@@ -1334,11 +1340,20 @@
 	$(SHELL) $(srcdir)/../mkinstalldirs $(datadir)/gdbtcl/help \
 		$(datadir)/gdbtcl/help/images \
 		$(datadir)/gdbtcl/help/trace ; \
+	$(SHELL) $(srcdir)/../mkinstalldirs $(bindir)
 	cd $(srcdir)/gdbtk/library ; \
 	for i in *.tcl *.ith *.itb images/*.gif images2/*.gif images/icons.txt images2/icons.txt tclIndex help/*.html  help/trace/*.html help/trace/index.toc help/images/*.gif; \
 	  do \
 		$(INSTALL_DATA) $$i $(datadir)/gdbtcl/$$i ; \
-	  done ;
+	  done
+	transformed_name=`t='$(program_transform_name)'; \
+			  echo insight | sed -e $$t` ; \
+		if test "x$$transformed_name" = x; then \
+		  transformed_name=insight ; \
+		else \
+		  true ; \
+		fi ; \
+	$(INSTALL_PROGRAM) $(srcdir)/insight $(bindir)/$$transformed_name
 
 gdbres.o: $(srcdir)/gdbtk/gdb.rc $(srcdir)/gdbtk/gdbtool.ico
 	$(WINDRES) --include $(srcdir)/gdbtk $(srcdir)/gdbtk/gdb.rc gdbres.o
Index: top.c
===================================================================
RCS file: /cvs/src/src/gdb/top.c,v
retrieving revision 1.21
diff -u -r1.21 top.c
--- top.c	2000/11/16 14:51:50	1.21
+++ top.c	2000/11/21 23:58:07
@@ -173,7 +173,7 @@
 /* If nonzero, and GDB has been configured to be able to use windows,
    attempt to open them upon startup.  */
 
-int use_windows = 1;
+int use_windows = 0;
 
 extern char lang_frame_mismatch_warn[];		/* language.c */
 

         reply	other threads:[~2000-11-21 16:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Syd>
     [not found] ` <Polk's>
     [not found]   ` <message>
     [not found]     ` <of>
     [not found]       ` <"Tue,>
     [not found]       ` <"28>
     [not found]       ` <"Wed,>
     [not found]       ` <"Mon,>
     [not found]         ` <01>
     [not found]           ` <May>
     [not found]             ` <2000>
     [not found]               ` <09:07:18>
     [not found]                 ` <-0700>
2000-04-29  7:21                   ` make check in itcl Andreas Jaeger
2000-05-01  9:05                     ` Syd Polk
2000-05-01  9:27                       ` Andreas Jaeger
2000-05-01 10:15                         ` Syd Polk
2000-05-01 10:58                           ` Andreas Jaeger
2000-05-01 11:21                             ` Syd Polk
2000-05-03 10:37                             ` Syd Polk
2000-05-03 12:05                               ` Andreas Jaeger
2000-05-03 12:37                                 ` Syd Polk
2000-05-04  2:34                                   ` Andrew Cagney
     [not found]               ` <09:17:35>
     [not found]                 ` <-0800>
2000-11-21 16:03                   ` Tom Tromey [this message]
     [not found]                     ` <mailpost.974851789.4627@postal.sibyte.com>
2000-11-22  9:42                       ` rename to insight Chris G. Demetriou
2000-11-22 10:29                         ` Tom Tromey
2000-11-28  9:18                           ` Chris G. Demetriou
2000-11-28  9:34                             ` Tom Tromey
2000-11-28 12:52                               ` Syd Polk
2000-11-28 10:34 Patch: fixlet in gdbtk-cmds.c Tom Tromey
2000-11-28 12:55 ` Syd Polk
2000-11-28 13:46   ` Tom Tromey
2000-11-28 14:47     ` Syd Polk
2000-11-28 17:32   ` Tom Tromey
2000-11-28 23:51     ` Syd Polk
2000-11-29 13:48       ` Tom Tromey
2000-11-29 18:41         ` Syd Polk
2000-11-29 20:07           ` Fernando Nasser
2000-11-30  9:09             ` Tom Tromey
2000-11-30  9:57               ` Fernando Nasser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874s10dfwt.fsf@creche.cygnus.com \
    --to=tromey@cygnus.com \
    --cc=insight@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).