Ping: save breakpoint patch

Ping: save breakpoint patch

[Tom Tromey]

This is the one-month ping for a patch I submitted:

    http://sources.redhat.com/ml/insight/2001-q2/msg00237.html

This patch changes Insight so that it saves breakpoint information
with the current session.

Fernando thought it was ok, at least provisionally, but my
understanding is that someone else (Keith, I guess) needs to approve
it.

Feel free to tell me that you don't want patch pings.  I just want to
make sure it isn't dropped.

Tom

Re: Ping: save breakpoint patch

[Keith Seitz]

On 11 Jun 2001, Tom Tromey wrote:

> This is the one-month ping for a patch I submitted:
>
>     http://sources.redhat.com/ml/insight/2001-q2/msg00237.html
>
> This patch changes Insight so that it saves breakpoint information
> with the current session.
>
> Fernando thought it was ok, at least provisionally, but my
> understanding is that someone else (Keith, I guess) needs to approve
> it.

I thought that we were going to go with this? I didn't even realize that
you had NOT checked it in...

(Why would I need to approve something that Fernando already approved?)
Keith

Re: Ping: save breakpoint patch

[Fernando Nasser]

Tom Tromey wrote:
> 
> This is the one-month ping for a patch I submitted:
> 
>     http://sources.redhat.com/ml/insight/2001-q2/msg00237.html
> 
> This patch changes Insight so that it saves breakpoint information
> with the current session.
> 
> Fernando thought it was ok, at least provisionally, but my
> understanding is that someone else (Keith, I guess) needs to approve
> it.
> 

We are in some kind of "OR" mode except for more substantial changes (which is more or less the case).  Jim may be on vacations and Keith are really busy replacing the hooks code with events.  Give it until tomorrow and if nobody posts any objections just check it in.


> Feel free to tell me that you don't want patch pings.  I just want to
> make sure it isn't dropped.
> 

No, patch pings are welcome.



P.S.: Do we need to document the fact that breakpoints are saved somewhere?  This is supposed to be the "natural" behavior that one should expect (well, as much as it is possible to implement), but certainly adding a small note somewhere won't hurt.  If you write a short paragraph I will look for a place to insert it.

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: Ping: save breakpoint patch

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:

Keith> I thought that we were going to go with this? I didn't even
Keith> realize that you had NOT checked it in...

I'll check it in.

Keith> (Why would I need to approve something that Fernando already
Keith> approved?)

I don't know.  Ordinarily if Fernando says ok, I go ahead.  But in
this case his approval seemed conditional:

Fernando> My vote is that Tom patches should go in.

No problem though.  Thanks.

Tom