[RFA] variable window menu fix

[RFA] variable window menu fix

[Martin M. Hunt]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

If you open a variable window, the pulldown menu entry "Format" is enabled.  
You can then set the format although you haven't selected anything.  This 
causes an error dialog, of course.  The patch disables the pulldown menu until
something is selected.

2001-07-21  Martin M. Hunt  <hunt@redhat.com>

	* library/variables.tcl (build_menu_helper): Set
	the Format menu option to "disabled" initially.

Index: variables.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/variables.tcl,v
retrieving revision 1.12
diff -u -p -r1.12 variables.tcl
--- variables.tcl	2001/06/04 15:49:53	1.12
+++ variables.tcl	2001/07/21 07:19:56
@@ -203,7 +203,7 @@ class VariableWin {
 		    %s editEntry [%s getSelection]
 		} $this $this]
 	}
-	[namespace tail $this].mmenu.var add cascade -label Format -underline 0 \
+	[namespace tail $this].mmenu.var add cascade -label Format -underline 0 
-state disabled \
 	    -menu [namespace tail $this].mmenu.var.format
 
 	menu [namespace tail $this].mmenu.var.format
ÿÿÿ

Re: [RFA] variable window menu fix

[Fernando Nasser]

"Martin M. Hunt" wrote:
> 
> If you open a variable window, the pulldown menu entry "Format" is enabled.
> You can then set the format although you haven't selected anything.  This
> causes an error dialog, of course.  The patch disables the pulldown menu until
> something is selected.
> 

Approved.

Nice catch!

Thank you Martin.

Fernando


> 2001-07-21  Martin M. Hunt  <hunt@redhat.com>
> 
>         * library/variables.tcl (build_menu_helper): Set
>         the Format menu option to "disabled" initially.
> 
> Index: variables.tcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/variables.tcl,v
> retrieving revision 1.12
> diff -u -p -r1.12 variables.tcl
> --- variables.tcl       2001/06/04 15:49:53     1.12
> +++ variables.tcl       2001/07/21 07:19:56
> @@ -203,7 +203,7 @@ class VariableWin {
>                     %s editEntry [%s getSelection]
>                 } $this $this]
>         }
> -       [namespace tail $this].mmenu.var add cascade -label Format -underline 0 \
> +       [namespace tail $this].mmenu.var add cascade -label Format -underline 0
> -state disabled \
>             -menu [namespace tail $this].mmenu.var.format
> 
>         menu [namespace tail $this].mmenu.var.format


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9