potential tix build problem

potential tix build problem

[Jonathan Larmour]

Insight dudes,

When installing Insight, I saw the following in the output:

make[3]: Entering directory
`/export/bucket/sourceware/gdb/build/arm-elf/tix/unix/tk8.0'
TCL_LIBRARY=/home/jlarmour/sourceware/gdb/insight/src/tcl/library
TK_LIBRARY=/home/jlarmour/sourceware/gdb/insight/src/tk/library
@TCL_BIN_DIR@/tclsh
/home/jlarmour/sourceware/gdb/insight/src/tix/tools/tclc.tcl
/home/jlarmour/sourceware/gdb/insight/src/tix/library/pref/*.fsc
/home/jlarmour/sourceware/gdb/insight/src/tix/library/pref/*.csc
/home/jlarmour/sourceware/gdb/insight/src/tix/library/*.tcl \
    > tixSamLib.c
/bin/sh: @TCL_BIN_DIR@/tclsh: No such file or directory
make[3]: *** [tixSamLib.c] Error 127

The error was ignored and the make install continued. The reason for this
is actually in tcl/unix/ where there is nothing in the autoconf stuff to
substitute in the correct value of TCL_BIN_DIR into tclConfig.sh.in that I
can see.

It seems that the configury in tcl/win/ solves this, so the appropriate
patch to tcl/unix/configure.in would be:

Index: configure.in
===================================================================
RCS file: /cvs/src/src/tcl/unix/configure.in,v
retrieving revision 1.3
diff -u -5 -p -r1.3 configure.in
--- configure.in	2000/12/14 00:22:52	1.3
+++ configure.in	2001/07/26 01:51:12
@@ -1350,10 +1350,11 @@ TCL_LIB_FULL_PATH="`pwd`/${TCL_LIB_FILE}
 if test "$prefix" != "$exec_prefix"; then
     TCL_PACKAGE_PATH="${exec_prefix}/lib ${prefix}/lib"
 else
     TCL_PACKAGE_PATH="${prefix}/lib"
 fi
+TCL_BIN_DIR=`pwd`
 
 AC_SUBST(BUILD_DLTEST)
 AC_SUBST(DL_LIBS)
 AC_SUBST(DL_OBJS)
 AC_SUBST(LD_FLAGS)
@@ -1378,10 +1379,11 @@ AC_SUBST(TCL_SHARED_LIB_SUFFIX)
 AC_SUBST(TCL_SHARED_BUILD)
 AC_SUBST(TCL_SHLIB_CFLAGS)
 AC_SUBST(TCL_SRC_DIR)
 AC_SUBST(TCL_UNSHARED_LIB_SUFFIX)
 AC_SUBST(TCL_VERSION)
+AC_SUBST(TCL_BIN_DIR)
 # CYGNUS LOCAL
 AC_SUBST(TCL_SHARED_LIB_FILE)
 AC_SUBST(TCL_UNSHARED_LIB_FILE)
 # END CYGNUS LOCAL

which appears to work. 

According to src/MAINTAINERS you are the owners of this stuff so is this
right?

If it's okay to check in, off-line you can tell me how to deal with our
internal devo, and any consequences for irox's TCL update.

Jifl


2001-07-26  Jonathan Larmour  <jlarmour@redhat.com>

	* configure.in: Substitute TCL_BIN_DIR, defaulting to `pwd`.
	* configure: Regenerated.

-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine
Come to the Red Hat TechWorld open source conference in Brussels!
Keynotes, techie talks and exhibitions    http://www.redhat-techworld.com/

Re: potential tix build problem

[Keith Seitz]

On Thu, 26 Jul 2001, Jonathan Larmour wrote:

> make[3]: Entering directory
> `/export/bucket/sourceware/gdb/build/arm-elf/tix/unix/tk8.0'
> TCL_LIBRARY=/home/jlarmour/sourceware/gdb/insight/src/tcl/library
> TK_LIBRARY=/home/jlarmour/sourceware/gdb/insight/src/tk/library
> @TCL_BIN_DIR@/tclsh
> /home/jlarmour/sourceware/gdb/insight/src/tix/tools/tclc.tcl
> /home/jlarmour/sourceware/gdb/insight/src/tix/library/pref/*.fsc
> /home/jlarmour/sourceware/gdb/insight/src/tix/library/pref/*.csc
> /home/jlarmour/sourceware/gdb/insight/src/tix/library/*.tcl \
>     > tixSamLib.c
> /bin/sh: @TCL_BIN_DIR@/tclsh: No such file or directory
> make[3]: *** [tixSamLib.c] Error 127

Hmmm... I don't seem to ever see this error when installing on linux.

> The error was ignored and the make install continued. The reason for this
> is actually in tcl/unix/ where there is nothing in the autoconf stuff to
> substitute in the correct value of TCL_BIN_DIR into tclConfig.sh.in that I
> can see.
>
> It seems that the configury in tcl/win/ solves this, so the appropriate
> patch to tcl/unix/configure.in would be:

[snip]

> According to src/MAINTAINERS you are the owners of this stuff so is this
> right?

I guess so.

> If it's okay to check in, off-line you can tell me how to deal with our
> internal devo, and any consequences for irox's TCL update.

I dunno. I looked at what is in Sourceforge's Tcl repository, and it looks
like they just now do a "AC_SUBST(TCL_BIN_DIR)", without ever setting it.
In any case, if it works, I say check it in. I'm not entirely sure what
this tix sam stuff is all about, anyway. (Stand-alone module?)

I'm not sure it really matters for us either way. I've never had any
problems with running/installing Insight because of tix
(installation/build problems).

Maybe irox or mdejong has something to say?
Keith

Re: potential tix build problem

[Mo DeJong]

On Thu, 26 Jul 2001, Keith Seitz wrote:

> On Thu, 26 Jul 2001, Jonathan Larmour wrote:
> 
> > make[3]: Entering directory
> > `/export/bucket/sourceware/gdb/build/arm-elf/tix/unix/tk8.0'
> > TCL_LIBRARY=/home/jlarmour/sourceware/gdb/insight/src/tcl/library
> > TK_LIBRARY=/home/jlarmour/sourceware/gdb/insight/src/tk/library
> > @TCL_BIN_DIR@/tclsh
> > /home/jlarmour/sourceware/gdb/insight/src/tix/tools/tclc.tcl
> > /home/jlarmour/sourceware/gdb/insight/src/tix/library/pref/*.fsc
> > /home/jlarmour/sourceware/gdb/insight/src/tix/library/pref/*.csc
> > /home/jlarmour/sourceware/gdb/insight/src/tix/library/*.tcl \
> >     > tixSamLib.c
> > /bin/sh: @TCL_BIN_DIR@/tclsh: No such file or directory
> > make[3]: *** [tixSamLib.c] Error 127
> 
> Hmmm... I don't seem to ever see this error when installing on linux.

Ugh. We are really trying to remove any use of Tcl executables at
runtime since it does not work when cross compiling.

Poking around in src/tix/unix/tk8.0/Makefile.in trned up:

tclSamLib.c:
        $(RUN_TCLSH) $(SRC_DIR)/tools/tclc.tcl $(TCL_SCRIPTS) \
            > tclSamLib.c

It seems RUN_TCLSH is used to generate .c files of static Tcl
code. I am not sure why that would be kicked off at runtime.

> > The error was ignored and the make install continued. The reason for this
> > is actually in tcl/unix/ where there is nothing in the autoconf stuff to
> > substitute in the correct value of TCL_BIN_DIR into tclConfig.sh.in that I
> > can see.
> >
> > It seems that the configury in tcl/win/ solves this, so the appropriate
> > patch to tcl/unix/configure.in would be:

Ok, I am a bit confused by this patch. If the problem is a lack of
TCL_BIN_DIR in the tix configure script, why is this patch for
Tcl?

The TCL_BIN_DIR var seems to be set in src/tix/unix/tk8.0/configure.in

(On line 147)

TCL_BIN_DIR=../../../tcl/unix

It also get substituted later:

AC_SUBST(TCL_BIN_DIR)

> > If it's okay to check in, off-line you can tell me how to deal with our
> > internal devo, and any consequences for irox's TCL update.
> 
> I dunno. I looked at what is in Sourceforge's Tcl repository, and it looks
> like they just now do a "AC_SUBST(TCL_BIN_DIR)", without ever setting it.
> In any case, if it works, I say check it in. I'm not entirely sure what
> this tix sam stuff is all about, anyway. (Stand-alone module?)

In the Tcl config, TCL_BIN_DIR is set by the SC_PATH_TCLCONFIG macro.
This TCL_BIN_DIR value does not show up in tclConfig.sh so each
module needs to figure it out. That makes sense because tclConfig.sh
lives in ${TCL_BIN_DIR} so how would an extension know how to
load ${TCL_BIN_DIR}/tclConfig.sh if it did not know what
TCL_BIN_DIR was?

> I'm not sure it really matters for us either way. I've never had any
> problems with running/installing Insight because of tix
> (installation/build problems).

I just took a peek at the 8.0 code on sources and it seems to set
TCL_BIN_DIR in unix/tclConfig.sh.in. This seems to be an
ill advised cygnus local change. This change does not appear
in the 8.3 upgrade so I would advise against adding the patch.
It seems like setting TCL_BIN_DIR in the tix configure script
is the right fix for this problem.

cheers
Mo DeJong
Red Hat Inc

Re: potential tix build problem

[Jonathan Larmour]

Mo DeJong wrote:
> 
> On Thu, 26 Jul 2001, Keith Seitz wrote:
> 
> > On Thu, 26 Jul 2001, Jonathan Larmour wrote:
> >
> > > make[3]: Entering directory
> > > `/export/bucket/sourceware/gdb/build/arm-elf/tix/unix/tk8.0'
> > > TCL_LIBRARY=/home/jlarmour/sourceware/gdb/insight/src/tcl/library
> > > TK_LIBRARY=/home/jlarmour/sourceware/gdb/insight/src/tk/library
> > > @TCL_BIN_DIR@/tclsh
> > > /home/jlarmour/sourceware/gdb/insight/src/tix/tools/tclc.tcl
> > > /home/jlarmour/sourceware/gdb/insight/src/tix/library/pref/*.fsc
> > > /home/jlarmour/sourceware/gdb/insight/src/tix/library/pref/*.csc
> > > /home/jlarmour/sourceware/gdb/insight/src/tix/library/*.tcl \
> > >     > tixSamLib.c
> > > /bin/sh: @TCL_BIN_DIR@/tclsh: No such file or directory
> > > make[3]: *** [tixSamLib.c] Error 127
> >
> > Hmmm... I don't seem to ever see this error when installing on linux.
> 
> Ugh. We are really trying to remove any use of Tcl executables at
> runtime since it does not work when cross compiling.
> 
> Poking around in src/tix/unix/tk8.0/Makefile.in trned up:
> 
> tclSamLib.c:
>         $(RUN_TCLSH) $(SRC_DIR)/tools/tclc.tcl $(TCL_SCRIPTS) \
>             > tclSamLib.c
> 
> It seems RUN_TCLSH is used to generate .c files of static Tcl
> code. I am not sure why that would be kicked off at runtime.
> 
> > > The error was ignored and the make install continued. The reason for this
> > > is actually in tcl/unix/ where there is nothing in the autoconf stuff to
> > > substitute in the correct value of TCL_BIN_DIR into tclConfig.sh.in that I
> > > can see.
> > >
> > > It seems that the configury in tcl/win/ solves this, so the appropriate
> > > patch to tcl/unix/configure.in would be:
> 
> Ok, I am a bit confused by this patch. If the problem is a lack of
> TCL_BIN_DIR in the tix configure script, why is this patch for
> Tcl?
> 
> The TCL_BIN_DIR var seems to be set in src/tix/unix/tk8.0/configure.in
> 
> (On line 147)
> 
> TCL_BIN_DIR=../../../tcl/unix
> 
> It also get substituted later:
> 
> AC_SUBST(TCL_BIN_DIR)

However, TCL_BIN_DIR gets reset by the run of tclConfig.sh on line 224.
 
> > > If it's okay to check in, off-line you can tell me how to deal with our
> > > internal devo, and any consequences for irox's TCL update.
> >
> > I dunno. I looked at what is in Sourceforge's Tcl repository, and it looks
> > like they just now do a "AC_SUBST(TCL_BIN_DIR)", without ever setting it.
> > In any case, if it works, I say check it in. I'm not entirely sure what
> > this tix sam stuff is all about, anyway. (Stand-alone module?)
> 
> In the Tcl config, TCL_BIN_DIR is set by the SC_PATH_TCLCONFIG macro.
> This TCL_BIN_DIR value does not show up in tclConfig.sh so each
> module needs to figure it out.

It does show up, as being set to @TCL_BIN_DIR@. It's just there is no
AC_SUBST for that variable so it remains set as literally that.

> That makes sense because tclConfig.sh
> lives in ${TCL_BIN_DIR} so how would an extension know how to
> load ${TCL_BIN_DIR}/tclConfig.sh if it did not know what
> TCL_BIN_DIR was?

Then why does the variable exist at all? Perhaps just to give location
independence to tclConfig.sh (hah!).
 
> > I'm not sure it really matters for us either way. I've never had any
> > problems with running/installing Insight because of tix
> > (installation/build problems).
> 
> I just took a peek at the 8.0 code on sources and it seems to set
> TCL_BIN_DIR in unix/tclConfig.sh.in. This seems to be an
> ill advised cygnus local change. This change does not appear
> in the 8.3 upgrade so I would advise against adding the patch.
> It seems like setting TCL_BIN_DIR in the tix configure script
> is the right fix for this problem.

TCL_BIN_DIR is already set and AC_SUBST'd in tix/unix/tk8.0. Perhaps than
the change should be either to remove the setting of TCL_BIN_DIR from
tcl/unix/tclConfig.sh.in, or to move the set of TCL_BIN_DIR to beneath the
execution of tclConfig.sh.

All I was doing was trying to make the unix build process similar to the
win one, which has this solved. So if you're saying this method is wrong,
it means the AC_SUBST in tcl/win/configure.in should be removed too.

If you think that's what should happen, I'll make the patch.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine

Re: potential tix build problem

[Mo DeJong]

On Tue, 31 Jul 2001, Jonathan Larmour wrote:

> > That makes sense because tclConfig.sh
> > lives in ${TCL_BIN_DIR} so how would an extension know how to
> > load ${TCL_BIN_DIR}/tclConfig.sh if it did not know what
> > TCL_BIN_DIR was?
> 
> Then why does the variable exist at all? Perhaps just to give location
> independence to tclConfig.sh (hah!).

Beats me. The TCL_BIN_DIR is going to record the build bin dir
anyway, so it is not like it would help once installed.
 
> > I just took a peek at the 8.0 code on sources and it seems to set
> > TCL_BIN_DIR in unix/tclConfig.sh.in. This seems to be an
> > ill advised cygnus local change. This change does not appear
> > in the 8.3 upgrade so I would advise against adding the patch.
> > It seems like setting TCL_BIN_DIR in the tix configure script
> > is the right fix for this problem.
> 
> TCL_BIN_DIR is already set and AC_SUBST'd in tix/unix/tk8.0. Perhaps than
> the change should be either to remove the setting of TCL_BIN_DIR from
> tcl/unix/tclConfig.sh.in, or to move the set of TCL_BIN_DIR to beneath the
> execution of tclConfig.sh.

I think the correct fix is to remove the TCL_BIN_DIR from 
unix/tclConfig.sh.in. I was just looking around and found
another src/tcl/cygwin/tclConfig.sh.in which also does
not set TCL_BIN_DIR in tclConfig.sh.in. I don't even see
a tclConfig.sh.in file in the win subdir. Of course,
I am not sure that such a change would not break some
other package.

> All I was doing was trying to make the unix build process similar to the
> win one, which has this solved. So if you're saying this method is wrong,
> it means the AC_SUBST in tcl/win/configure.in should be removed too.

Humm, it looks like the win version just uses the tclConfig.sh.in
from the unix subdir. I don't see any other files in the
tcl/win subdir that make use of the TCL_BIN_DIR subst.

> If you think that's what should happen, I'll make the patch.

Well, I think that is the right fix. Of course, if this is
not really broken perhaps it would be better to just
leave it alone for now. We are going to be doing the
Tcl/Tk 8.3 merge in the next couple of weeks. Perhaps
we could just put the pain off until then.

Mo

Re: potential tix build problem

[Jonathan Larmour]

Mo DeJong wrote:
> > If you think that's what should happen, I'll make the patch.
> 
> Well, I think that is the right fix. Of course, if this is
> not really broken perhaps it would be better to just
> leave it alone for now. We are going to be doing the
> Tcl/Tk 8.3 merge in the next couple of weeks. Perhaps
> we could just put the pain off until then.

Okay, I'll just leave it then. It fails in a benign way. If the 8.3 merge
doesn't have the same issue, then that's all that _really_ matters.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine