public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* [rfa/expect] Add explicit build rules for tcl_regexp.c
@ 2001-09-20 13:13 Andrew Cagney
  2001-09-22  0:31 ` Ian Roxborough
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2001-09-20 13:13 UTC (permalink / raw)
  To: gdb-patches; +Cc: insight

Hello,

I was finding that I couldn't build the expect in the CVS repository on 
a FreeBSD machine - expect/tcl_regexp.c was failing because it was 
including tcl/.../unistd.h instead of <unistd.h>.  This was occuring 
because HAVE_UNISTD_H wasn't defined.

The attached patch adds an explicit compile rule for tcl_regexp.c that 
includes all the autoconf -D... flags (esp HAVE_UNISTD_H) and hence 
(appears to) fix the problem

Ok?
	Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [rfa/expect] Add explicit build rules for tcl_regexp.c
  2001-09-20 13:13 [rfa/expect] Add explicit build rules for tcl_regexp.c Andrew Cagney
@ 2001-09-22  0:31 ` Ian Roxborough
  2001-09-22 11:13   ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Roxborough @ 2001-09-22  0:31 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: gdb-patches, insight

Approved.

THanks,
  Ian.

Andrew Cagney wrote:
> 
> Hello,
> 
> I was finding that I couldn't build the expect in the CVS repository on
> a FreeBSD machine - expect/tcl_regexp.c was failing because it was
> including tcl/.../unistd.h instead of <unistd.h>.  This was occuring
> because HAVE_UNISTD_H wasn't defined.
> 
> The attached patch adds an explicit compile rule for tcl_regexp.c that
> includes all the autoconf -D... flags (esp HAVE_UNISTD_H) and hence
> (appears to) fix the problem
> 
> Ok?
>         Andrew
> 
>   --------------------------------------------------------------------------------
> Thu Sep 20 16:00:44 2001  Andrew Cagney  <cagney@b1.cygnus.com>
> 
>         * Makefile.in (shared/tcl_regexp.o, tcl_regexp.o): Add explict
>         build rules that include @TCL_DEFS@ in the list of compiler flags.
> 
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/expect/Makefile.in,v
> retrieving revision 1.3
> diff -p -r1.3 Makefile.in
> *** Makefile.in 2001/09/08 06:26:30     1.3
> --- Makefile.in 2001/09/20 20:03:06
> *************** pty_sgttyb.o: $(srcdir)/pty_sgttyb.c exp
> *** 848,850 ****
> --- 848,855 ----
>   pty_termios.o: $(srcdir)/pty_termios.c expect_cf.h exp_win.h \
>         exp_tty_in.h exp_tty.h exp_rename.h exp_pty.h
>   pty_unicos.o: $(srcdir)/pty_unicos.c expect_cf.h exp_rename.h
> + tcl_regexp.o: $(srcdir)/tcl_regexp.c
> +       $(CC) -c $(CFLAGS_INT) @TCL_DEFS@ $(HDEFS) $<
> + shared/tcl_regexp.o: $(srcdir)/tcl_regexp.c
> +       $(CC) -c $(CFLAGS_INT) @EXP_SHLIB_CFLAGS@ @TCL_DEFS@ $(HDEFS) $< -o shared/$@
> +

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [rfa/expect] Add explicit build rules for tcl_regexp.c
  2001-09-22  0:31 ` Ian Roxborough
@ 2001-09-22 11:13   ` Andrew Cagney
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2001-09-22 11:13 UTC (permalink / raw)
  To: Ian Roxborough; +Cc: gdb-patches, insight

>> Thu Sep 20 16:00:44 2001  Andrew Cagney  <cagney@b1.cygnus.com>
>> 
>> * Makefile.in (shared/tcl_regexp.o, tcl_regexp.o): Add explict
>> build rules that include @TCL_DEFS@ in the list of compiler flags.
>> 

It is in.
	Andrew


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-09-22 11:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-09-20 13:13 [rfa/expect] Add explicit build rules for tcl_regexp.c Andrew Cagney
2001-09-22  0:31 ` Ian Roxborough
2001-09-22 11:13   ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).