[patch] remove Tix

[patch] remove Tix

[Martin M. Hunt]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]


2002-11-27  Martin M. Hunt  <hunt@redhat.com>

	* generic/gdbtk.c (gdbtk_init): Don't call Tix_Init.
	Don't include tix.h

	* generic/gdbtk-hooks.c: Don't include tix.h.

	* generic/gdbtkj-cmds.c: Don't include tix.h.




[-- Attachment #2: p --]
[-- Type: text/x-patch, Size: 1912 bytes --]

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.61
diff -u -r1.61 gdbtk-cmds.c
--- generic/gdbtk-cmds.c	27 Nov 2002 15:29:53 -0000	1.61
+++ generic/gdbtk-cmds.c	27 Nov 2002 19:08:39 -0000
@@ -39,7 +39,6 @@
    but gdb uses stdarg.h, so make sure HAS_STDARG is defined.  */
 #define HAS_STDARG 1
 
-#include <tix.h>
 #include <itcl.h>
 
 #include "guitcl.h"
Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.27
diff -u -r1.27 gdbtk-hooks.c
--- generic/gdbtk-hooks.c	6 Nov 2002 14:22:28 -0000	1.27
+++ generic/gdbtk-hooks.c	27 Nov 2002 19:08:40 -0000
@@ -43,7 +43,6 @@
 #define HAS_STDARG 1
 
 #include <itcl.h>
-#include <tix.h>
 #include "guitcl.h"
 #include "gdbtk.h"
 
Index: generic/gdbtk.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.c,v
retrieving revision 1.29
diff -u -r1.29 gdbtk.c
--- generic/gdbtk.c	14 Aug 2002 15:44:24 -0000	1.29
+++ generic/gdbtk.c	27 Nov 2002 19:08:40 -0000
@@ -42,7 +42,6 @@
    but gdb uses stdarg.h, so make sure HAS_STDARG is defined.  */
 #define HAS_STDARG 1
 
-#include <tix.h>
 #include <itcl.h>
 #include <itk.h>
 #include "guitcl.h"
@@ -509,11 +508,6 @@
   if (Itk_Init (gdbtk_interp) == TCL_ERROR)
     error ("Itk_Init failed: %s", gdbtk_interp->result);
   Tcl_StaticPackage (gdbtk_interp, "Itk", Itk_Init,
-		     (Tcl_PackageInitProc *) NULL);
-
-  if (Tix_Init (gdbtk_interp) != TCL_OK)
-    error ("Tix_Init failed: %s", gdbtk_interp->result);
-  Tcl_StaticPackage (gdbtk_interp, "Tix", Tix_Init,
 		     (Tcl_PackageInitProc *) NULL);
 
   if (Tktable_Init (gdbtk_interp) != TCL_OK)

Re: [patch] remove Tix

[Christopher Faylor]

On Wed, Nov 27, 2002 at 11:14:40AM -0800, Martin M. Hunt wrote:
>2002-11-27  Martin M. Hunt  <hunt@redhat.com>
>
>	* generic/gdbtk.c (gdbtk_init): Don't call Tix_Init.
>	Don't include tix.h
>
>	* generic/gdbtk-hooks.c: Don't include tix.h.
>
>	* generic/gdbtkj-cmds.c: Don't include tix.h.

Does this mean that we can remove tix from the insight module
on sources dot redhat dot com?

cgf

Re: [patch] remove Tix

[Andrew Cagney]

> On Wed, Nov 27, 2002 at 11:14:40AM -0800, Martin M. Hunt wrote:
> 
>>2002-11-27  Martin M. Hunt  <hunt@redhat.com>
>>
>>	* generic/gdbtk.c (gdbtk_init): Don't call Tix_Init.
>>	Don't include tix.h
>>
>>	* generic/gdbtk-hooks.c: Don't include tix.h.
>>
>>	* generic/gdbtkj-cmds.c: Don't include tix.h.
> 
> 
> Does this mean that we can remove tix from the insight module
> on sources dot redhat dot com?

Not really.

If tix was removed, someone checking out:
	-D last-year insight
would find that the no longer got tix (which was needed back then).

Might end up doing something like adding a module:
	insight-5-3

Andrew

Re: [patch] remove Tix

[Christopher Faylor]

On Thu, Nov 28, 2002 at 10:50:09PM -0500, Andrew Cagney wrote:
>>On Wed, Nov 27, 2002 at 11:14:40AM -0800, Martin M. Hunt wrote:
>>
>>>2002-11-27  Martin M. Hunt  <hunt@redhat.com>
>>>
>>>	* generic/gdbtk.c (gdbtk_init): Don't call Tix_Init.
>>>	Don't include tix.h
>>>
>>>	* generic/gdbtk-hooks.c: Don't include tix.h.
>>>
>>>	* generic/gdbtkj-cmds.c: Don't include tix.h.
>>
>>
>>Does this mean that we can remove tix from the insight module
>>on sources dot redhat dot com?
>
>Not really.
>
>If tix was removed, someone checking out:
>	-D last-year insight
>would find that the no longer got tix (which was needed back then).

So, we create a module "last-year-insight" or "insight-tix".  I don't
see any reason to bend over backwards accommodating unusual things like
the above.

cgf

Re: [patch] remove Tix

[Andrew Cagney]

> On Thu, Nov 28, 2002 at 10:50:09PM -0500, Andrew Cagney wrote:
> 
>>>On Wed, Nov 27, 2002 at 11:14:40AM -0800, Martin M. Hunt wrote:
>>>
> 
>>>>2002-11-27  Martin M. Hunt  <hunt@redhat.com>
>>>>
>>>>	* generic/gdbtk.c (gdbtk_init): Don't call Tix_Init.
>>>>	Don't include tix.h
>>>>
>>>>	* generic/gdbtk-hooks.c: Don't include tix.h.
>>>>
>>>>	* generic/gdbtkj-cmds.c: Don't include tix.h.
> 
>>>
>>>
>>>Does this mean that we can remove tix from the insight module
>>>on sources dot redhat dot com?
> 
>>
>>Not really.
>>
>>If tix was removed, someone checking out:
>>	-D last-year insight
>>would find that the no longer got tix (which was needed back then).
> 
> 
> So, we create a module "last-year-insight" or "insight-tix".  I don't
> see any reason to bend over backwards accommodating unusual things like
> the above.

GDB will end up in a similar situtation, I was thinking of creating 
modules like gdb-5-2, gdb-5-3, ...