* [rfa] Fix 0x0x problem with memory addresses
@ 2002-12-05 22:28 Andrew Cagney
2002-12-06 7:47 ` Keith Seitz
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2002-12-05 22:28 UTC (permalink / raw)
To: insight
[-- Attachment #1: Type: text/plain, Size: 105 bytes --]
Hello,
This should stop the memory window displaying addresses as:
0x0x12345678
ok to commit?
Andrew
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 752 bytes --]
2002-12-06 Andrew Cagney <ac131313@redhat.com>
* generic/gdbtk-cmds.c (gdb_update_mem): Don't add a 0x prefix.
Index: ./gdb/gdbtk/generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.64
diff -u -r1.64 gdbtk-cmds.c
--- ./gdb/gdbtk/generic/gdbtk-cmds.c 4 Dec 2002 16:21:21 -0000 1.64
+++ ./gdb/gdbtk/generic/gdbtk-cmds.c 6 Dec 2002 06:23:48 -0000
@@ -2625,7 +2625,7 @@
for (i = 0; i < nbytes; i += bpr)
{
char s[130];
- sprintf (s, "0x%s", core_addr_to_string (addr + i));
+ sprintf (s, "%s", core_addr_to_string (addr + i));
INDEX ((int) i/bpr, -1);
Tcl_SetVar2 (interp, "data", index, s, 0);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [rfa] Fix 0x0x problem with memory addresses
2002-12-05 22:28 [rfa] Fix 0x0x problem with memory addresses Andrew Cagney
@ 2002-12-06 7:47 ` Keith Seitz
2002-12-06 8:28 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Keith Seitz @ 2002-12-06 7:47 UTC (permalink / raw)
To: Andrew Cagney; +Cc: insight
On Fri, 6 Dec 2002, Andrew Cagney wrote:
> Hello,
>
> This should stop the memory window displaying addresses as:
>
> 0x0x12345678
>
> ok to commit?
Indeed! (Sheesh -- I must be getting senile... How did I ever let this bug
go unnoticed for so long?)
Thanks!
Keith
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [rfa] Fix 0x0x problem with memory addresses
2002-12-06 7:47 ` Keith Seitz
@ 2002-12-06 8:28 ` Andrew Cagney
2002-12-10 8:43 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2002-12-06 8:28 UTC (permalink / raw)
To: Keith Seitz; +Cc: insight
> On Fri, 6 Dec 2002, Andrew Cagney wrote:
>
>
>> Hello,
>>
>> This should stop the memory window displaying addresses as:
>>
>> 0x0x12345678
>>
>> ok to commit?
>
>
> Indeed!
Committed. Hmm, 5.3?
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [rfa] Fix 0x0x problem with memory addresses
2002-12-06 8:28 ` Andrew Cagney
@ 2002-12-10 8:43 ` Andrew Cagney
2002-12-10 11:48 ` Martin M. Hunt
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2002-12-10 8:43 UTC (permalink / raw)
To: Keith Seitz; +Cc: Andrew Cagney, insight
####### ##### #####
# # # # #
# # #
###### ##### ###
# ### # #
# # ### # #
##### ### ##### #
> On Fri, 6 Dec 2002, Andrew Cagney wrote:
>
>
> Hello,
>
> This should stop the memory window displaying addresses as:
>
> 0x0x12345678
>
> ok to commit?
>
>
> Indeed!
> Committed. Hmm, 5.3?
>
> Andrew
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [rfa] Fix 0x0x problem with memory addresses
2002-12-10 8:43 ` Andrew Cagney
@ 2002-12-10 11:48 ` Martin M. Hunt
2002-12-10 11:54 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Martin M. Hunt @ 2002-12-10 11:48 UTC (permalink / raw)
To: Andrew Cagney; +Cc: Keith Seitz, insight
On Tue, 2002-12-10 at 08:43, Andrew Cagney wrote:
> ####### ##### #####
> # # # # #
> # # #
> ###### ##### ###
> # ### # #
> # # ### # #
> ##### ### ##### #
How are we deciding what goes into 5.3. The branch was cut in August
and Insight has not been updated. I thought it was frozen.
Martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [rfa] Fix 0x0x problem with memory addresses
2002-12-10 11:48 ` Martin M. Hunt
@ 2002-12-10 11:54 ` Andrew Cagney
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Cagney @ 2002-12-10 11:54 UTC (permalink / raw)
To: Martin M. Hunt; +Cc: Keith Seitz, insight
> On Tue, 2002-12-10 at 08:43, Andrew Cagney wrote:
>
>> ####### ##### #####
>> # # # # #
>> # # #
>> ###### ##### ###
>> # ### # #
>> # # ### # #
>> ##### ### ##### #
>
>
> How are we deciding what goes into 5.3. The branch was cut in August
> and Insight has not been updated. I thought it was frozen.
I'm about to commit this patch and then roll out a proper 5.3. After
that the branch will be unfrozen.
When/where the insight specific parts of the 5.3 branch are updated is
is really up to Insight developers (except for the last week when the
branch has been frozen).
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-12-10 19:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-12-05 22:28 [rfa] Fix 0x0x problem with memory addresses Andrew Cagney
2002-12-06 7:47 ` Keith Seitz
2002-12-06 8:28 ` Andrew Cagney
2002-12-10 8:43 ` Andrew Cagney
2002-12-10 11:48 ` Martin M. Hunt
2002-12-10 11:54 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).