public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* PATCH: Download sometimes fails to find exec file
@ 2000-10-04 12:31 Fernando Nasser
  2000-10-04 12:52 ` Syd Polk
  0 siblings, 1 reply; 6+ messages in thread
From: Fernando Nasser @ 2000-10-04 12:31 UTC (permalink / raw)
  To: insight

This is quite similar to the previous problem.  It is also related to 
passing Cygwin filenames to Tcl.

Here you are, sometimes, prevented to download your executable because 
Insight thinks that the file does not exist.

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9



Index: download.itb
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/gdbtk/library/download.itb,v
retrieving revision 1.1
diff -c -p -r1.1 download.itb
*** download.itb        2000/02/04 13:52:34     1.1
--- download.itb        2000/10/04 19:27:58
*************** body Download::download_it { } {
*** 147,152 ****
--- 147,153 ----
    global gdb_exe_name gdb_downloading gdb_loaded
    global gdb_target_name gdb_pretty_name
    global gdb_running
+   global tcl_platform
    
    debug "exe=$gdb_exe_name downloading=$gdb_downloading"
    debug "    loaded=$gdb_loaded target=$gdb_target_name running=$gdb_running"
*************** body Download::download_it { } {
*** 185,191 ****
      }
    }
    
!   if {! [file exists $gdb_exe_name]} {
      tk_messageBox -icon error -title GDB -type ok -modal task\
        -message "Request to download non-existent executable $gdb_exe_name"
      set gdb_downloading 0
--- 186,195 ----
      }
    }
    
!   if {[string compare $tcl_platform(platform) "windows"] == 0} {
!     set f [ide_cygwin_path to_win32 $gdb_exe_name]
!   }
!   if {! [file exists $f]} {
      tk_messageBox -icon error -title GDB -type ok -modal task\
        -message "Request to download non-existent executable $gdb_exe_name"
      set gdb_downloading 0

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: PATCH: Download sometimes fails to find exec file
  2000-10-04 12:31 PATCH: Download sometimes fails to find exec file Fernando Nasser
@ 2000-10-04 12:52 ` Syd Polk
  2000-10-04 13:23   ` Fernando Nasser
  0 siblings, 1 reply; 6+ messages in thread
From: Syd Polk @ 2000-10-04 12:52 UTC (permalink / raw)
  To: Fernando Nasser, insight

At 03:31 PM 10/4/00 -0400, Fernando Nasser wrote:
>This is quite similar to the previous problem.  It is also related to
>passing Cygwin filenames to Tcl.
>
>Here you are, sometimes, prevented to download your executable because
>Insight thinks that the file does not exist.
>
>--
>Fernando Nasser
>Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
>2323 Yonge Street, Suite #300
>Toronto, Ontario   M4P 2C9
>
>
>
>Index: download.itb
>===================================================================
>RCS file: /cvs/cvsfiles/devo/gdb/gdbtk/library/download.itb,v
>retrieving revision 1.1
>diff -c -p -r1.1 download.itb
>*** download.itb        2000/02/04 13:52:34     1.1
>--- download.itb        2000/10/04 19:27:58
>*************** body Download::download_it { } {
>*** 147,152 ****
>--- 147,153 ----
>     global gdb_exe_name gdb_downloading gdb_loaded
>     global gdb_target_name gdb_pretty_name
>     global gdb_running
>+   global tcl_platform
>
>     debug "exe=$gdb_exe_name downloading=$gdb_downloading"
>     debug "    loaded=$gdb_loaded target=$gdb_target_name 
> running=$gdb_running"
>*************** body Download::download_it { } {
>*** 185,191 ****
>       }
>     }
>
>!   if {! [file exists $gdb_exe_name]} {
>       tk_messageBox -icon error -title GDB -type ok -modal task\
>         -message "Request to download non-existent executable $gdb_exe_name"
>       set gdb_downloading 0
>--- 186,195 ----
>       }
>     }
>
>!   if {[string compare $tcl_platform(platform) "windows"] == 0} {
>!     set f [ide_cygwin_path to_win32 $gdb_exe_name]
>!   }

What is "f" set to here if the platform is not windows?

>!   if {! [file exists $f]} {
>       tk_messageBox -icon error -title GDB -type ok -modal task\
>         -message "Request to download non-existent executable $gdb_exe_name"
>       set gdb_downloading 0

Syd Polk		spolk@redhat.com
Engineering Manager	+1 415 777 9810 x 241
Red Hat, Inc.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: PATCH: Download sometimes fails to find exec file
  2000-10-04 12:52 ` Syd Polk
@ 2000-10-04 13:23   ` Fernando Nasser
  2000-10-04 13:33     ` Syd Polk
  0 siblings, 1 reply; 6+ messages in thread
From: Fernando Nasser @ 2000-10-04 13:23 UTC (permalink / raw)
  To: Syd Polk; +Cc: insight

Syd Polk wrote:
> 
> What is "f" set to here if the platform is not windows?
> 
A cut and paste error.  I got it here already.

Thanks.

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: PATCH: Download sometimes fails to find exec file
  2000-10-04 13:23   ` Fernando Nasser
@ 2000-10-04 13:33     ` Syd Polk
  2000-10-04 14:17       ` PATCH: Download sometimes fails to find exec file (REPOST) Fernando Nasser
  0 siblings, 1 reply; 6+ messages in thread
From: Syd Polk @ 2000-10-04 13:33 UTC (permalink / raw)
  To: Fernando Nasser; +Cc: insight

At 04:23 PM 10/4/00 -0400, Fernando Nasser wrote:
>Syd Polk wrote:
> >
> > What is "f" set to here if the platform is not windows?
> >
>A cut and paste error.  I got it here already.
>
>Thanks.
>
>--
>Fernando Nasser
>Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
>2323 Yonge Street, Suite #300
>Toronto, Ontario   M4P 2C9

Please submit an updated patch, and I will approve it.


Syd Polk		spolk@redhat.com
Engineering Manager	+1 415 777 9810 x 241
Red Hat, Inc.



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: PATCH: Download sometimes fails to find exec file (REPOST)
  2000-10-04 13:33     ` Syd Polk
@ 2000-10-04 14:17       ` Fernando Nasser
  2000-10-04 14:21         ` Syd Polk
  0 siblings, 1 reply; 6+ messages in thread
From: Fernando Nasser @ 2000-10-04 14:17 UTC (permalink / raw)
  To: Syd Polk; +Cc: insight

This is the correct one.  Thanks Syd.

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


*** download.itb        Wed Oct  4 17:12:26 2000
--- download.itb        Wed Oct  4 16:25:43 2000
***************
*** 147,152 ****
--- 147,153 ----
    global gdb_exe_name gdb_downloading gdb_loaded
    global gdb_target_name gdb_pretty_name
    global gdb_running
+   global tcl_platform
    
    debug "exe=$gdb_exe_name downloading=$gdb_downloading"
    debug "    loaded=$gdb_loaded target=$gdb_target_name running=$gdb_running"
***************
*** 185,191 ****
      }
    }
    
!   if {! [file exists $gdb_exe_name]} {
      tk_messageBox -icon error -title GDB -type ok -modal task\
        -message "Request to download non-existent executable $gdb_exe_name"
      set gdb_downloading 0
--- 186,197 ----
      }
    }
    
!   if {[string compare $tcl_platform(platform) "windows"] == 0} {
!     set f [ide_cygwin_path to_win32 $gdb_exe_name]
!   } else {
!     set f $gdb_exe_name
!   }
!   if {! [file exists $f]} {
      tk_messageBox -icon error -title GDB -type ok -modal task\
        -message "Request to download non-existent executable $gdb_exe_name"
      set gdb_downloading 0

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: PATCH: Download sometimes fails to find exec file (REPOST)
  2000-10-04 14:17       ` PATCH: Download sometimes fails to find exec file (REPOST) Fernando Nasser
@ 2000-10-04 14:21         ` Syd Polk
  0 siblings, 0 replies; 6+ messages in thread
From: Syd Polk @ 2000-10-04 14:21 UTC (permalink / raw)
  To: Fernando Nasser; +Cc: insight

Approved.

At 05:17 PM 10/4/00 -0400, Fernando Nasser wrote:
>This is the correct one.  Thanks Syd.
>
>--
>Fernando Nasser
>Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
>2323 Yonge Street, Suite #300
>Toronto, Ontario   M4P 2C9
>
>
>*** download.itb        Wed Oct  4 17:12:26 2000
>--- download.itb        Wed Oct  4 16:25:43 2000
>***************
>*** 147,152 ****
>--- 147,153 ----
>     global gdb_exe_name gdb_downloading gdb_loaded
>     global gdb_target_name gdb_pretty_name
>     global gdb_running
>+   global tcl_platform
>
>     debug "exe=$gdb_exe_name downloading=$gdb_downloading"
>     debug "    loaded=$gdb_loaded target=$gdb_target_name 
> running=$gdb_running"
>***************
>*** 185,191 ****
>       }
>     }
>
>!   if {! [file exists $gdb_exe_name]} {
>       tk_messageBox -icon error -title GDB -type ok -modal task\
>         -message "Request to download non-existent executable $gdb_exe_name"
>       set gdb_downloading 0
>--- 186,197 ----
>       }
>     }
>
>!   if {[string compare $tcl_platform(platform) "windows"] == 0} {
>!     set f [ide_cygwin_path to_win32 $gdb_exe_name]
>!   } else {
>!     set f $gdb_exe_name
>!   }
>!   if {! [file exists $f]} {
>       tk_messageBox -icon error -title GDB -type ok -modal task\
>         -message "Request to download non-existent executable $gdb_exe_name"
>       set gdb_downloading 0

Syd Polk		spolk@redhat.com
Engineering Manager	+1 415 777 9810 x 241
Red Hat, Inc.



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2000-10-04 14:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-10-04 12:31 PATCH: Download sometimes fails to find exec file Fernando Nasser
2000-10-04 12:52 ` Syd Polk
2000-10-04 13:23   ` Fernando Nasser
2000-10-04 13:33     ` Syd Polk
2000-10-04 14:17       ` PATCH: Download sometimes fails to find exec file (REPOST) Fernando Nasser
2000-10-04 14:21         ` Syd Polk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).