* Re: [RFA] 100494 fix
[not found] <200010272126.RAA02584@ozma.smith-house.org>
@ 2000-10-30 12:53 ` Fernando Nasser
2000-10-30 15:45 ` Larry Smith
2000-10-31 9:19 ` Larry Smith
0 siblings, 2 replies; 13+ messages in thread
From: Fernando Nasser @ 2000-10-30 12:53 UTC (permalink / raw)
To: Larry Smith; +Cc: gdb-patches, insight
Good catch Larry. But please add a labeled frame around the radiobuttons,
will you? The target selection dialog expansion box does look weird with
two square buttons and two rounds with no explanation.
"Run method" sounds right for the frame label.
If you really want to fix this, make sure the option is set to "run" and
the buttons greyed if the target "exec" is selected.
Cheers,
Fernando
P.S.: Insight patches go to the insight list, not gdb-patches as the people
that wrote the code watch it more closely and there is a larger group of
users and contributors in this list that do not subscribe to gdb-patches.
Larry Smith wrote:
>
> The following patch is for 100494, changing a pair of checkbuttons
> to radiobuttons. Since the proper behaviour was already enforced
> this is really only cosmetic, and changes no current control flow.
>
> I apologise for being unaware of proper protocol for doing patches
> on sourceware, this has already been checked in. I will try to be
> more circumspect in the future...
>
> regards,
> Larry
>
> 2000-10-26 Larry Smith <lsmith@redhat.com>
>
> * change targetselection.itb: Run Program and Continue From Last Stop
> are now radio buttons rather than checkbuttons
>
> Index: targetselection.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- targetselection.itb 2000/09/12 20:04:11 1.4
> +++ targetselection.itb 2000/10/26 20:47:57 1.5
> @@ -488,11 +488,11 @@
> checkbutton $frame.load -text {Download Program} -variable $var
>
> set var [pref varname gdb/src/run_cont]
> - checkbutton $frame.cont -text {Continue from Last Stop} -variable $var \
> + radiobutton $frame.cont -text {Continue from Last Stop} -value 1 -variable $var \
> -command [code $this set_run run]
>
> set var [pref varname gdb/src/run_run]
> - checkbutton $frame.run -text {Run Program} -variable $var \
> + radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> -command [code $this set_run cont]
>
> # The after attaching command entry
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-30 12:53 ` [RFA] 100494 fix Fernando Nasser
@ 2000-10-30 15:45 ` Larry Smith
2000-10-31 9:19 ` Larry Smith
1 sibling, 0 replies; 13+ messages in thread
From: Larry Smith @ 2000-10-30 15:45 UTC (permalink / raw)
To: Fernando Nasser; +Cc: insight
Fernando Nasser wrote:
> Good catch Larry. But please add a labeled frame around the radiobuttons,
> will you? The target selection dialog expansion box does look weird with
> two square buttons and two rounds with no explanation.
The "labeledframe" widget does not seem to put up the
label. Just the frame. Now the "MoreFrame" labeledframe
widget has the label "Run Options" and that doesn't appear,
either. No where in the dialog. Very curious.
Also, according to my [Incr/Tcl from the Ground Up, we
shouldn't be using the labeledframe widget directly
anyway, it's intended to be inherited by other megawidgets.
But it gives no reason for the caution.
I can't execute "iwidgets::labeledframe" from itkwish3.0,
nor any permutation of it I can find. Any clues what is
going on here?
> "Run method" sounds right for the frame label.
>
> If you really want to fix this, make sure the option is set to "run" and
> the buttons greyed if the target "exec" is selected.
>
> Cheers,
> Fernando
>
> P.S.: Insight patches go to the insight list, not gdb-patches as the people
> that wrote the code watch it more closely and there is a larger group of
> users and contributors in this list that do not subscribe to gdb-patches.
>
> Larry Smith wrote:
> >
> > The following patch is for 100494, changing a pair of checkbuttons
> > to radiobuttons. Since the proper behaviour was already enforced
> > this is really only cosmetic, and changes no current control flow.
> >
> > I apologise for being unaware of proper protocol for doing patches
> > on sourceware, this has already been checked in. I will try to be
> > more circumspect in the future...
> >
> > regards,
> > Larry
> >
> > 2000-10-26 Larry Smith <lsmith@redhat.com>
> >
> > * change targetselection.itb: Run Program and Continue From Last Stop
> > are now radio buttons rather than checkbuttons
> >
> > Index: targetselection.itb
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> > retrieving revision 1.4
> > retrieving revision 1.5
> > diff -u -r1.4 -r1.5
> > --- targetselection.itb 2000/09/12 20:04:11 1.4
> > +++ targetselection.itb 2000/10/26 20:47:57 1.5
> > @@ -488,11 +488,11 @@
> > checkbutton $frame.load -text {Download Program} -variable $var
> >
> > set var [pref varname gdb/src/run_cont]
> > - checkbutton $frame.cont -text {Continue from Last Stop} -variable $var \
> > + radiobutton $frame.cont -text {Continue from Last Stop} -value 1 -variable $var \
> > -command [code $this set_run run]
> >
> > set var [pref varname gdb/src/run_run]
> > - checkbutton $frame.run -text {Run Program} -variable $var \
> > + radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> > -command [code $this set_run cont]
> >
> > # The after attaching command entry
>
> --
> Fernando Nasser
> Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario M4P 2C9
--
.-. .-. .---. .---. .-..-. | "Bill Gates is just a monocle
| |__ / | \| |-< | |-< > / | and a Persian Cat away from
`----'`-^-'`-'`-'`-'`-' `-' | being one of the bad guys in a
My opinions only. | James Bond movie." -- D Miller
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-30 12:53 ` [RFA] 100494 fix Fernando Nasser
2000-10-30 15:45 ` Larry Smith
@ 2000-10-31 9:19 ` Larry Smith
2000-10-31 9:23 ` Syd Polk
1 sibling, 1 reply; 13+ messages in thread
From: Larry Smith @ 2000-10-31 9:19 UTC (permalink / raw)
To: Fernando Nasser; +Cc: gdb-patches, insight
Fernando Nasser wrote:
>
> Good catch Larry. But please add a labeled frame around the radiobuttons,
> will you? The target selection dialog expansion box does look weird with
> two square buttons and two rounds with no explanation.
>
> "Run method" sounds right for the frame label.
>
> If you really want to fix this, make sure the option is set to "run" and
> the buttons greyed if the target "exec" is selected.
Okay, this is a bit more involved than the previous patch,
but it seems to do what Fernando wants. It adds a new var
to the header file to save the pathnames for the run method
buttons, and when the target selection is changed to "exec",
these buttons are greyed out (and "run" selected) and when
it is anything else, the buttons are active and set to what-
ever the program would have set them to.
This has NOT been checked in or committed. Permission to
do so?
> cvs diff -r 1.2 targetselection.ith
Index: targetselection.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
retrieving revision 1.2
diff -r1.2 targetselection.ith
57a58,59
>
> variable run_method
>
> cvs diff -r 1.5 targetselection.itb
Index: targetselection.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
retrieving revision 1.5
diff -r1.5 targetselection.itb
489a490,493
> set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw -labeltext "Run Method" ]
> set run_method [ $rm_frame childsite ]
>
> set rm_label [label $frame.label -text "Run Method:"]
491c495
< radiobutton $frame.cont -text {Continue from Last Stop} -value 1
-variable $var \
---
> radiobutton $run_method.cont -text {Continue from Last Stop} -value 1 -variable $var \
495c499
< radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
---
> radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
501,504c505,516
< grid $frame.attach $frame.run -sticky w
< grid $frame.load $frame.cont -sticky w
< grid $frame.afterl -sticky we -columnspan 2
< grid $frame.aftere -sticky we -columnspan 2
---
>
> grid $frame.label -column 1 -row 0 -sticky w
> grid $frame.attach -column 0 -row 1 -ipady 2
> grid $frame.load -column 0 -row 2 -ipady 2
>
> grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
> grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
>
> grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
>
> grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
> grid $frame.aftere -sticky we -columnspan 2 -ipady 2
724a737,745
>
> if { "$target" == "exec" } {
> $run_method.run configure -state disabled -value 1
> $run_method.cont configure -state disabled
> } else {
> $run_method.run configure -state normal
> $run_method.cont configure -state normal
> }
>
>
>
> Cheers,
> Fernando
>
> P.S.: Insight patches go to the insight list, not gdb-patches as the people
> that wrote the code watch it more closely and there is a larger group of
> users and contributors in this list that do not subscribe to gdb-patches.
>
> Larry Smith wrote:
> >
> > The following patch is for 100494, changing a pair of checkbuttons
> > to radiobuttons. Since the proper behaviour was already enforced
> > this is really only cosmetic, and changes no current control flow.
> >
> > I apologise for being unaware of proper protocol for doing patches
> > on sourceware, this has already been checked in. I will try to be
> > more circumspect in the future...
> >
> > regards,
> > Larry
> >
> > 2000-10-26 Larry Smith <lsmith@redhat.com>
> >
> > * change targetselection.itb: Run Program and Continue From Last Stop
> > are now radio buttons rather than checkbuttons
> >
> > Index: targetselection.itb
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> > retrieving revision 1.4
> > retrieving revision 1.5
> > diff -u -r1.4 -r1.5
> > --- targetselection.itb 2000/09/12 20:04:11 1.4
> > +++ targetselection.itb 2000/10/26 20:47:57 1.5
> > @@ -488,11 +488,11 @@
> > checkbutton $frame.load -text {Download Program} -variable $var
> >
> > set var [pref varname gdb/src/run_cont]
> > - checkbutton $frame.cont -text {Continue from Last Stop} -variable $var \
> > + radiobutton $frame.cont -text {Continue from Last Stop} -value 1 -variable $var \
> > -command [code $this set_run run]
> >
> > set var [pref varname gdb/src/run_run]
> > - checkbutton $frame.run -text {Run Program} -variable $var \
> > + radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> > -command [code $this set_run cont]
> >
> > # The after attaching command entry
>
> --
> Fernando Nasser
> Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario M4P 2C9
--
.-. .-. .---. .---. .-..-. | "Bill Gates is just a monocle
| |__ / | \| |-< | |-< > / | and a Persian Cat away from
`----'`-^-'`-'`-'`-'`-' `-' | being one of the bad guys in a
My opinions only. | James Bond movie." -- D Miller
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-31 9:19 ` Larry Smith
@ 2000-10-31 9:23 ` Syd Polk
2000-10-31 10:06 ` Larry Smith
0 siblings, 1 reply; 13+ messages in thread
From: Syd Polk @ 2000-10-31 9:23 UTC (permalink / raw)
To: lsmith; +Cc: Fernando Nasser, gdb-patches, insight
Need a ChangeLog entry.
Now that the official policy has been clarified, patches should be submitted
just to insight@sources.redhat.com, not gdb-patches@sources.redhat.com.
And when you get a ChangeLog entry, please post a new message with [RFA]
starting the subject.
Larry Smith wrote:
>
> Fernando Nasser wrote:
> >
> > Good catch Larry. But please add a labeled frame around the radiobuttons,
> > will you? The target selection dialog expansion box does look weird with
> > two square buttons and two rounds with no explanation.
> >
> > "Run method" sounds right for the frame label.
> >
> > If you really want to fix this, make sure the option is set to "run" and
> > the buttons greyed if the target "exec" is selected.
>
> Okay, this is a bit more involved than the previous patch,
> but it seems to do what Fernando wants. It adds a new var
> to the header file to save the pathnames for the run method
> buttons, and when the target selection is changed to "exec",
> these buttons are greyed out (and "run" selected) and when
> it is anything else, the buttons are active and set to what-
> ever the program would have set them to.
>
> This has NOT been checked in or committed. Permission to
> do so?
>
> > cvs diff -r 1.2 targetselection.ith
> Index: targetselection.ith
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
> retrieving revision 1.2
> diff -r1.2 targetselection.ith
> 57a58,59
> >
> > variable run_method
> >
>
> > cvs diff -r 1.5 targetselection.itb
> Index: targetselection.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> retrieving revision 1.5
> diff -r1.5 targetselection.itb
> 489a490,493
> > set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw -labeltext "Run Method" ]
> > set run_method [ $rm_frame childsite ]
> >
> > set rm_label [label $frame.label -text "Run Method:"]
> 491c495
> < radiobutton $frame.cont -text {Continue from Last Stop} -value 1
> -variable $var \
> ---
> > radiobutton $run_method.cont -text {Continue from Last Stop} -value 1 -variable $var \
> 495c499
> < radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> ---
> > radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
> 501,504c505,516
> < grid $frame.attach $frame.run -sticky w
> < grid $frame.load $frame.cont -sticky w
> < grid $frame.afterl -sticky we -columnspan 2
> < grid $frame.aftere -sticky we -columnspan 2
> ---
> >
> > grid $frame.label -column 1 -row 0 -sticky w
> > grid $frame.attach -column 0 -row 1 -ipady 2
> > grid $frame.load -column 0 -row 2 -ipady 2
> >
> > grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
> > grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
> >
> > grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
> >
> > grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
> > grid $frame.aftere -sticky we -columnspan 2 -ipady 2
> 724a737,745
> >
> > if { "$target" == "exec" } {
> > $run_method.run configure -state disabled -value 1
> > $run_method.cont configure -state disabled
> > } else {
> > $run_method.run configure -state normal
> > $run_method.cont configure -state normal
> > }
> >
> >
>
> >
> > Cheers,
> > Fernando
> >
> > P.S.: Insight patches go to the insight list, not gdb-patches as the people
> > that wrote the code watch it more closely and there is a larger group of
> > users and contributors in this list that do not subscribe to gdb-patches.
> >
> > Larry Smith wrote:
> > >
> > > The following patch is for 100494, changing a pair of checkbuttons
> > > to radiobuttons. Since the proper behaviour was already enforced
> > > this is really only cosmetic, and changes no current control flow.
> > >
> > > I apologise for being unaware of proper protocol for doing patches
> > > on sourceware, this has already been checked in. I will try to be
> > > more circumspect in the future...
> > >
> > > regards,
> > > Larry
> > >
> > > 2000-10-26 Larry Smith <lsmith@redhat.com>
> > >
> > > * change targetselection.itb: Run Program and Continue From Last Stop
> > > are now radio buttons rather than checkbuttons
> > >
> > > Index: targetselection.itb
> > > ===================================================================
> > > RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> > > retrieving revision 1.4
> > > retrieving revision 1.5
> > > diff -u -r1.4 -r1.5
> > > --- targetselection.itb 2000/09/12 20:04:11 1.4
> > > +++ targetselection.itb 2000/10/26 20:47:57 1.5
> > > @@ -488,11 +488,11 @@
> > > checkbutton $frame.load -text {Download Program} -variable $var
> > >
> > > set var [pref varname gdb/src/run_cont]
> > > - checkbutton $frame.cont -text {Continue from Last Stop} -variable $var \
> > > + radiobutton $frame.cont -text {Continue from Last Stop} -value 1 -variable $var \
> > > -command [code $this set_run run]
> > >
> > > set var [pref varname gdb/src/run_run]
> > > - checkbutton $frame.run -text {Run Program} -variable $var \
> > > + radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> > > -command [code $this set_run cont]
> > >
> > > # The after attaching command entry
> >
> > --
> > Fernando Nasser
> > Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
> > 2323 Yonge Street, Suite #300
> > Toronto, Ontario M4P 2C9
>
> --
> .-. .-. .---. .---. .-..-. | "Bill Gates is just a monocle
> | |__ / | \| |-< | |-< > / | and a Persian Cat away from
> `----'`-^-'`-'`-'`-'`-' `-' | being one of the bad guys in a
> My opinions only. | James Bond movie." -- D Miller
^ permalink raw reply [flat|nested] 13+ messages in thread
* [RFA] 100494 fix
2000-10-31 9:23 ` Syd Polk
@ 2000-10-31 10:06 ` Larry Smith
2000-10-31 10:33 ` Syd Polk
2000-10-31 11:22 ` Fernando Nasser
0 siblings, 2 replies; 13+ messages in thread
From: Larry Smith @ 2000-10-31 10:06 UTC (permalink / raw)
To: Syd Polk; +Cc: Fernando Nasser, insight
2000-10-31 Larry Smith <lsmith@redhat.com>
* change targetselection.it*, put Run Program and Continue
From...
buttons into a frame and disables both of them when the target
is
"exec".
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
retrieving revision 1.2
diff -r1.2 targetselection.ith
57a58,59
>
> variable run_method
>
> cvs diff -r 1.5 targetselection.itb
Index: targetselection.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
retrieving revision 1.5
diff -r1.5 targetselection.itb
489a490,493
> set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw -labeltext "Run Method" ]
> set run_method [ $rm_frame childsite ]
>
> set rm_label [label $frame.label -text "Run Method:"]
491c495
< radiobutton $frame.cont -text {Continue from Last Stop} -value 1
-variable $var \
---
> radiobutton $run_method.cont -text {Continue from Last Stop} -value 1 -variable $var \
495c499
< radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
---
> radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
501,504c505,516
< grid $frame.attach $frame.run -sticky w
< grid $frame.load $frame.cont -sticky w
< grid $frame.afterl -sticky we -columnspan 2
< grid $frame.aftere -sticky we -columnspan 2
---
>
> grid $frame.label -column 1 -row 0 -sticky w
> grid $frame.attach -column 0 -row 1 -ipady 2
> grid $frame.load -column 0 -row 2 -ipady 2
>
> grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
> grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
>
> grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
>
> grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
> grid $frame.aftere -sticky we -columnspan 2 -ipady 2
724a737,745
>
> if { "$target" == "exec" } {
> $run_method.run configure -state disabled -value 1
> $run_method.cont configure -state disabled
> } else {
> $run_method.run configure -state normal
> $run_method.cont configure -state normal
> }
--
.-. .-. .---. .---. .-..-. | "Bill Gates is just a monocle
| |__ / | \| |-< | |-< > / | and a Persian Cat away from
`----'`-^-'`-'`-'`-'`-' `-' | being one of the bad guys in a
My opinions only. | James Bond movie." -- D Miller
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-31 10:06 ` Larry Smith
@ 2000-10-31 10:33 ` Syd Polk
2000-10-31 10:51 ` Fernando Nasser
2000-10-31 11:23 ` Larry Smith
2000-10-31 11:22 ` Fernando Nasser
1 sibling, 2 replies; 13+ messages in thread
From: Syd Polk @ 2000-10-31 10:33 UTC (permalink / raw)
To: lsmith; +Cc: Fernando Nasser, insight
At 01:07 PM 10/31/00 -0500, Larry Smith wrote:
>2000-10-31 Larry Smith <lsmith@redhat.com>
>
> * change targetselection.it*, put Run Program and Continue
>From...
> buttons into a frame and disables both of them when the target
>is
> "exec".
The proper format is:
* library/targetselection.ith (run_method): Add this variable.
* library/targetselection.itb (method name?): Change the run
method depending on state of "exec".
Or something similar. ChangeLogs are of the form:
* file (method_proc_or_variable): What changed.
Please refer to the GNU coding standards for more information.
This will go into gdbtk/ChangeLog, right?
>RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
>retrieving revision 1.2
>diff -r1.2 targetselection.ith
>57a58,59
> >
> > variable run_method
> >
>
> > cvs diff -r 1.5 targetselection.itb
>Index: targetselection.itb
>===================================================================
>RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
>retrieving revision 1.5
>diff -r1.5 targetselection.itb
>489a490,493
> > set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw
> -labeltext "Run Method" ]
> > set run_method [ $rm_frame childsite ]
> >
> > set rm_label [label $frame.label -text "Run Method:"]
>491c495
>< radiobutton $frame.cont -text {Continue from Last Stop} -value 1
>-variable $var \
>---
> > radiobutton $run_method.cont -text {Continue from Last Stop} -value 1
> -variable $var \
>495c499
>< radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
>---
> > radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
>501,504c505,516
>< grid $frame.attach $frame.run -sticky w
>< grid $frame.load $frame.cont -sticky w
>< grid $frame.afterl -sticky we -columnspan 2
>< grid $frame.aftere -sticky we -columnspan 2
>---
> >
> > grid $frame.label -column 1 -row 0 -sticky w
> > grid $frame.attach -column 0 -row 1 -ipady 2
> > grid $frame.load -column 0 -row 2 -ipady 2
> >
> > grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
> > grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
> >
> > grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
> >
> > grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
> > grid $frame.aftere -sticky we -columnspan 2 -ipady 2
>724a737,745
> >
> > if { "$target" == "exec" } {
> > $run_method.run configure -state disabled -value 1
> > $run_method.cont configure -state disabled
> > } else {
> > $run_method.run configure -state normal
> > $run_method.cont configure -state normal
> > }
>
>--
> .-. .-. .---. .---. .-..-. | "Bill Gates is just a monocle
> | |__ / | \| |-< | |-< > / | and a Persian Cat away from
> `----'`-^-'`-'`-'`-'`-' `-' | being one of the bad guys in a
> My opinions only. | James Bond movie." -- D Miller
Syd Polk spolk@redhat.com
Engineering Manager +1 415 777 9810 x 241
Red Hat, Inc.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-31 10:33 ` Syd Polk
@ 2000-10-31 10:51 ` Fernando Nasser
2000-10-31 11:23 ` Larry Smith
1 sibling, 0 replies; 13+ messages in thread
From: Fernando Nasser @ 2000-10-31 10:51 UTC (permalink / raw)
To: Syd Polk; +Cc: lsmith, insight
Syd Polk wrote:
>
> At 01:07 PM 10/31/00 -0500, Larry Smith wrote:
> >2000-10-31 Larry Smith <lsmith@redhat.com>
> >
> > * change targetselection.it*, put Run Program and Continue
> >From...
> > buttons into a frame and disables both of them when the target
> >is
> > "exec".
>
> The proper format is:
>
> * library/targetselection.ith (run_method): Add this variable.
> * library/targetselection.itb (method name?): Change the run
> method depending on state of "exec".
>
> Or something similar. ChangeLogs are of the form:
>
> * file (method_proc_or_variable): What changed.
>
> Please refer to the GNU coding standards for more information.
>
> This will go into gdbtk/ChangeLog, right?
>
We have separate ChangeLog files for gdbtk/library and gdbtk/generic
(I don't know why, it is just the way it is now).
So the entries will be
* targetselection.ith (run_method): Add this variable.
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-31 10:06 ` Larry Smith
2000-10-31 10:33 ` Syd Polk
@ 2000-10-31 11:22 ` Fernando Nasser
1 sibling, 0 replies; 13+ messages in thread
From: Fernando Nasser @ 2000-10-31 11:22 UTC (permalink / raw)
To: lsmith; +Cc: Syd Polk, insight
Nice work Larry.
But please rename run_method to rm_method (like rm_frame).
This way we do not confuse the state variables that indicate weather
we want to run or continue (run_run and run_cont) and the variables
that contain window paths.
Another thing: Your patch seem to have a mix of "diff" and "cvs diff".
"patch" didn't like it. I had to hand edit it several times in order
to try it.
cvs diff is the preferable method. Unless the contributor does not have
a cvs tree, the patch should be created by a cvs diff.
Thanks for the patch.
Regards,
Fernando
Larry Smith wrote:
>
> 2000-10-31 Larry Smith <lsmith@redhat.com>
>
> * change targetselection.it*, put Run Program and Continue
> From...
> buttons into a frame and disables both of them when the target
> is
> "exec".
>
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
> retrieving revision 1.2
> diff -r1.2 targetselection.ith
> 57a58,59
> >
> > variable run_method
> >
>
> > cvs diff -r 1.5 targetselection.itb
> Index: targetselection.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> retrieving revision 1.5
> diff -r1.5 targetselection.itb
> 489a490,493
> > set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw -labeltext "Run Method" ]
> > set run_method [ $rm_frame childsite ]
> >
> > set rm_label [label $frame.label -text "Run Method:"]
> 491c495
> < radiobutton $frame.cont -text {Continue from Last Stop} -value 1
> -variable $var \
> ---
> > radiobutton $run_method.cont -text {Continue from Last Stop} -value 1 -variable $var \
> 495c499
> < radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> ---
> > radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
> 501,504c505,516
> < grid $frame.attach $frame.run -sticky w
> < grid $frame.load $frame.cont -sticky w
> < grid $frame.afterl -sticky we -columnspan 2
> < grid $frame.aftere -sticky we -columnspan 2
> ---
> >
> > grid $frame.label -column 1 -row 0 -sticky w
> > grid $frame.attach -column 0 -row 1 -ipady 2
> > grid $frame.load -column 0 -row 2 -ipady 2
> >
> > grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
> > grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
> >
> > grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
> >
> > grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
> > grid $frame.aftere -sticky we -columnspan 2 -ipady 2
> 724a737,745
> >
> > if { "$target" == "exec" } {
> > $run_method.run configure -state disabled -value 1
> > $run_method.cont configure -state disabled
> > } else {
> > $run_method.run configure -state normal
> > $run_method.cont configure -state normal
> > }
>
> --
> .-. .-. .---. .---. .-..-. | "Bill Gates is just a monocle
> | |__ / | \| |-< | |-< > / | and a Persian Cat away from
> `----'`-^-'`-'`-'`-'`-' `-' | being one of the bad guys in a
> My opinions only. | James Bond movie." -- D Miller
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 13+ messages in thread
* [RFA] 100494 fix
2000-10-31 10:33 ` Syd Polk
2000-10-31 10:51 ` Fernando Nasser
@ 2000-10-31 11:23 ` Larry Smith
2000-10-31 11:30 ` Syd Polk
1 sibling, 1 reply; 13+ messages in thread
From: Larry Smith @ 2000-10-31 11:23 UTC (permalink / raw)
To: Syd Polk; +Cc: Fernando Nasser, insight
Better?
* change targetselection.ith (run_method): Add variable for
"Run Program" and "Continue..." buttons
* change targetselection.itb (build_win): put "Run Program" and
"Continue From..." buttons into a frame and save them in new
run_method variable.
* change targetselection.itb (change_target) disables "Run
Program" and "Continue..." buttons when the target is "exec",
enables them for all others.
Index: targetselection.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
retrieving revision 1.5
diff -u -r1.5 targetselection.itb
--- targetselection.itb 2000/10/26 20:47:57 1.5
+++ targetselection.itb 2000/10/31 19:20:03
@@ -487,21 +487,33 @@
set var [pref varname gdb/src/run_load]
checkbutton $frame.load -text {Download Program} -variable $var
+ set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw
-labeltext "Run Method" ]
+ set run_method [ $rm_frame childsite ]
+
+ set rm_label [label $frame.label -text "Run Method:"]
set var [pref varname gdb/src/run_cont]
- radiobutton $frame.cont -text {Continue from Last Stop} -value 1
-variable $var \
+ radiobutton $run_method.cont -text {Continue from Last Stop} -value 1
-variable $var \
-command [code $this set_run run]
set var [pref varname gdb/src/run_run]
- radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
+ radiobutton $run_method.run -text {Run Program} -value 1 -variable
$var \
-command [code $this set_run cont]
# The after attaching command entry
set _after_entry [entry $frame.aftere]
label $frame.afterl -text {Command to issue after attaching:}
- grid $frame.attach $frame.run -sticky w
- grid $frame.load $frame.cont -sticky w
- grid $frame.afterl -sticky we -columnspan 2
- grid $frame.aftere -sticky we -columnspan 2
+
+ grid $frame.label -column 1 -row 0 -sticky w
+ grid $frame.attach -column 0 -row 1 -ipady 2
+ grid $frame.load -column 0 -row 2 -ipady 2
+
+ grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
+ grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
+
+ grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
+
+ grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
+ grid $frame.aftere -sticky we -columnspan 2 -ipady 2
grid columnconfigure $frame 0 -weight 1
grid columnconfigure $frame 1 -weight 1
@@ -722,6 +734,15 @@
body TargetSelection::change_target {w {name ""}} {
if {$name == ""} {return}
set target [get_target $name]
+
+ if { "$target" == "exec" } {
+ $run_method.run configure -state disabled -value 1
+ $run_method.cont configure -state disabled
+ } else {
+ $run_method.run configure -state normal
+ $run_method.cont configure -state normal
+ }
+
debug "$target"
set defbaud $gdb_target($target,defbaud)
pref define gdb/load/$target-baud $defbaud
Index: targetselection.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
retrieving revision 1.2
diff -u -r1.2 targetselection.ith
--- targetselection.ith 2000/03/10 23:41:47 1.2
+++ targetselection.ith 2000/10/31 19:20:03
@@ -55,6 +55,8 @@
variable MoreButton
variable MoreFrame
variable MoreLabel
+
+ variable run_method
proc _init_prefs {}
proc default_port {}
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-31 11:23 ` Larry Smith
@ 2000-10-31 11:30 ` Syd Polk
0 siblings, 0 replies; 13+ messages in thread
From: Syd Polk @ 2000-10-31 11:30 UTC (permalink / raw)
To: lsmith; +Cc: Fernando Nasser, insight
At 02:22 PM 10/31/00 -0500, Larry Smith wrote:
>Better?
Close!
You still need the date and user id field.
> * change targetselection.ith (run_method): Add variable for
> "Run Program" and "Continue..." buttons
> * change targetselection.itb (build_win): put "Run Program" and
> "Continue From..." buttons into a frame and save them in new
> run_method variable.
> * change targetselection.itb (change_target) disables "Run
> Program" and "Continue..." buttons when the target is "exec",
> enables them for all others.
Also, see Fernando's other comments.
Hang it there; you are almost home.
>Index: targetselection.itb
>===================================================================
>RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
>retrieving revision 1.5
>diff -u -r1.5 targetselection.itb
>--- targetselection.itb 2000/10/26 20:47:57 1.5
>+++ targetselection.itb 2000/10/31 19:20:03
>@@ -487,21 +487,33 @@
> set var [pref varname gdb/src/run_load]
> checkbutton $frame.load -text {Download Program} -variable $var
>
>+ set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw
>-labeltext "Run Method" ]
>+ set run_method [ $rm_frame childsite ]
>+
>+ set rm_label [label $frame.label -text "Run Method:"]
> set var [pref varname gdb/src/run_cont]
>- radiobutton $frame.cont -text {Continue from Last Stop} -value 1
>-variable $var \
>+ radiobutton $run_method.cont -text {Continue from Last Stop} -value 1
>-variable $var \
> -command [code $this set_run run]
>
> set var [pref varname gdb/src/run_run]
>- radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
>+ radiobutton $run_method.run -text {Run Program} -value 1 -variable
>$var \
> -command [code $this set_run cont]
>
> # The after attaching command entry
> set _after_entry [entry $frame.aftere]
> label $frame.afterl -text {Command to issue after attaching:}
>- grid $frame.attach $frame.run -sticky w
>- grid $frame.load $frame.cont -sticky w
>- grid $frame.afterl -sticky we -columnspan 2
>- grid $frame.aftere -sticky we -columnspan 2
>+
>+ grid $frame.label -column 1 -row 0 -sticky w
>+ grid $frame.attach -column 0 -row 1 -ipady 2
>+ grid $frame.load -column 0 -row 2 -ipady 2
>+
>+ grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
>+ grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
>+
>+ grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
>+
>+ grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
>+ grid $frame.aftere -sticky we -columnspan 2 -ipady 2
> grid columnconfigure $frame 0 -weight 1
> grid columnconfigure $frame 1 -weight 1
>
>@@ -722,6 +734,15 @@
> body TargetSelection::change_target {w {name ""}} {
> if {$name == ""} {return}
> set target [get_target $name]
>+
>+ if { "$target" == "exec" } {
>+ $run_method.run configure -state disabled -value 1
>+ $run_method.cont configure -state disabled
>+ } else {
>+ $run_method.run configure -state normal
>+ $run_method.cont configure -state normal
>+ }
>+
> debug "$target"
> set defbaud $gdb_target($target,defbaud)
> pref define gdb/load/$target-baud $defbaud
>Index: targetselection.ith
>===================================================================
>RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
>retrieving revision 1.2
>diff -u -r1.2 targetselection.ith
>--- targetselection.ith 2000/03/10 23:41:47 1.2
>+++ targetselection.ith 2000/10/31 19:20:03
>@@ -55,6 +55,8 @@
> variable MoreButton
> variable MoreFrame
> variable MoreLabel
>+
>+ variable run_method
>
> proc _init_prefs {}
> proc default_port {}
Syd Polk spolk@redhat.com
Engineering Manager +1 415 777 9810 x 241
Red Hat, Inc.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-31 11:42 Larry Smith
2000-10-31 12:06 ` Fernando Nasser
@ 2000-10-31 12:10 ` Syd Polk
1 sibling, 0 replies; 13+ messages in thread
From: Syd Polk @ 2000-10-31 12:10 UTC (permalink / raw)
To: Larry Smith, insight
At 02:42 PM 10/31/00 -0500, Larry Smith wrote:
>2000-10-31 Larry Smith <lsmith@redhat.com>
>
> * change targetselection.ith (run_method): Add variable for
> "Run Program" and "Continue..." buttons
> * change targetselection.itb (build_win): put "Run Program" and
> "Continue From..." buttons into a frame and save them in new
> run_method variable.
> * change targetselection.itb (change_target) disables "Run
> Program" and "Continue..." buttons when the target is "exec",
> enables them for all others.
1. Take out the word "change".
* targetselection.ith (run_method): ...
2. Fernando asked you to change the name "run_method" to "rn_method".
Assuming you do these two things, this is approved.
>Index: targetselection.itb
>===================================================================
>RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
>retrieving revision 1.5
>diff -u -r1.5 targetselection.itb
>--- targetselection.itb 2000/10/26 20:47:57 1.5
>+++ targetselection.itb 2000/10/31 19:20:03
>@@ -487,21 +487,33 @@
> set var [pref varname gdb/src/run_load]
> checkbutton $frame.load -text {Download Program} -variable $var
>
>+ set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw
>-labeltext "Run Method" ]
>+ set run_method [ $rm_frame childsite ]
>+
>+ set rm_label [label $frame.label -text "Run Method:"]
> set var [pref varname gdb/src/run_cont]
>- radiobutton $frame.cont -text {Continue from Last Stop} -value 1
>-variable $var \
>+ radiobutton $run_method.cont -text {Continue from Last Stop} -value 1
>-variable $var \
> -command [code $this set_run run]
>
> set var [pref varname gdb/src/run_run]
>- radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
>+ radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
> -command [code $this set_run cont]
>
> # The after attaching command entry
> set _after_entry [entry $frame.aftere]
> label $frame.afterl -text {Command to issue after attaching:}
>- grid $frame.attach $frame.run -sticky w
>- grid $frame.load $frame.cont -sticky w
>- grid $frame.afterl -sticky we -columnspan 2
>- grid $frame.aftere -sticky we -columnspan 2
>+
>+ grid $frame.label -column 1 -row 0 -sticky w
>+ grid $frame.attach -column 0 -row 1 -ipady 2
>+ grid $frame.load -column 0 -row 2 -ipady 2
>+
>+ grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
>+ grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
>+
>+ grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
>+
>+ grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
>+ grid $frame.aftere -sticky we -columnspan 2 -ipady 2
> grid columnconfigure $frame 0 -weight 1
> grid columnconfigure $frame 1 -weight 1
>
>@@ -722,6 +734,15 @@
> body TargetSelection::change_target {w {name ""}} {
> if {$name == ""} {return}
> set target [get_target $name]
>+
>+ if { "$target" == "exec" } {
>+ $run_method.run configure -state disabled -value 1
>+ $run_method.cont configure -state disabled
>+ } else {
>+ $run_method.run configure -state normal
>+ $run_method.cont configure -state normal
>+ }
>+
> debug "$target"
> set defbaud $gdb_target($target,defbaud)
> pref define gdb/load/$target-baud $defbaud
>Index: targetselection.ith
>===================================================================
>RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
>retrieving revision 1.2
>diff -u -r1.2 targetselection.ith
>--- targetselection.ith 2000/03/10 23:41:47 1.2
>+++ targetselection.ith 2000/10/31 19:20:03
>@@ -55,6 +55,8 @@
> variable MoreButton
> variable MoreFrame
> variable MoreLabel
>+
>+ variable run_method
>
> proc _init_prefs {}
> proc default_port {}
Syd Polk spolk@redhat.com
Engineering Manager +1 415 777 9810 x 241
Red Hat, Inc.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFA] 100494 fix
2000-10-31 11:42 Larry Smith
@ 2000-10-31 12:06 ` Fernando Nasser
2000-10-31 12:10 ` Syd Polk
1 sibling, 0 replies; 13+ messages in thread
From: Fernando Nasser @ 2000-10-31 12:06 UTC (permalink / raw)
To: Larry Smith; +Cc: insight
Now I remember the convention. The run_method variable must be written as RunMethod.
Sorry I didn't say it before, I was working on something else and I just had the
deja vu feeling.
The patch is approved pending the renaming of the variable. You don't need to
repost, just rename and check it in.
It works really nice.
Thanks,
Fernando
Larry Smith wrote:
>
> 2000-10-31 Larry Smith <lsmith@redhat.com>
>
> * change targetselection.ith (run_method): Add variable for
> "Run Program" and "Continue..." buttons
> * change targetselection.itb (build_win): put "Run Program" and
> "Continue From..." buttons into a frame and save them in new
> run_method variable.
> * change targetselection.itb (change_target) disables "Run
> Program" and "Continue..." buttons when the target is "exec",
> enables them for all others.
>
> Index: targetselection.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> retrieving revision 1.5
> diff -u -r1.5 targetselection.itb
> --- targetselection.itb 2000/10/26 20:47:57 1.5
> +++ targetselection.itb 2000/10/31 19:20:03
> @@ -487,21 +487,33 @@
> set var [pref varname gdb/src/run_load]
> checkbutton $frame.load -text {Download Program} -variable $var
>
> + set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw -labeltext "Run Method" ]
> + set run_method [ $rm_frame childsite ]
> +
> + set rm_label [label $frame.label -text "Run Method:"]
> set var [pref varname gdb/src/run_cont]
> - radiobutton $frame.cont -text {Continue from Last Stop} -value 1 -variable $var \
> + radiobutton $run_method.cont -text {Continue from Last Stop} -value 1 -variable $var \
> -command [code $this set_run run]
>
> set var [pref varname gdb/src/run_run]
> - radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> + radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
> -command [code $this set_run cont]
>
> # The after attaching command entry
> set _after_entry [entry $frame.aftere]
> label $frame.afterl -text {Command to issue after attaching:}
> - grid $frame.attach $frame.run -sticky w
> - grid $frame.load $frame.cont -sticky w
> - grid $frame.afterl -sticky we -columnspan 2
> - grid $frame.aftere -sticky we -columnspan 2
> +
> + grid $frame.label -column 1 -row 0 -sticky w
> + grid $frame.attach -column 0 -row 1 -ipady 2
> + grid $frame.load -column 0 -row 2 -ipady 2
> +
> + grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
> + grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
> +
> + grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
> +
> + grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
> + grid $frame.aftere -sticky we -columnspan 2 -ipady 2
> grid columnconfigure $frame 0 -weight 1
> grid columnconfigure $frame 1 -weight 1
>
> @@ -722,6 +734,15 @@
> body TargetSelection::change_target {w {name ""}} {
> if {$name == ""} {return}
> set target [get_target $name]
> +
> + if { "$target" == "exec" } {
> + $run_method.run configure -state disabled -value 1
> + $run_method.cont configure -state disabled
> + } else {
> + $run_method.run configure -state normal
> + $run_method.cont configure -state normal
> + }
> +
> debug "$target"
> set defbaud $gdb_target($target,defbaud)
> pref define gdb/load/$target-baud $defbaud
> Index: targetselection.ith
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
> retrieving revision 1.2
> diff -u -r1.2 targetselection.ith
> --- targetselection.ith 2000/03/10 23:41:47 1.2
> +++ targetselection.ith 2000/10/31 19:20:03
> @@ -55,6 +55,8 @@
> variable MoreButton
> variable MoreFrame
> variable MoreLabel
> +
> + variable run_method
>
> proc _init_prefs {}
> proc default_port {}
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 13+ messages in thread
* [RFA] 100494 fix
@ 2000-10-31 11:42 Larry Smith
2000-10-31 12:06 ` Fernando Nasser
2000-10-31 12:10 ` Syd Polk
0 siblings, 2 replies; 13+ messages in thread
From: Larry Smith @ 2000-10-31 11:42 UTC (permalink / raw)
To: insight
2000-10-31 Larry Smith <lsmith@redhat.com>
* change targetselection.ith (run_method): Add variable for
"Run Program" and "Continue..." buttons
* change targetselection.itb (build_win): put "Run Program" and
"Continue From..." buttons into a frame and save them in new
run_method variable.
* change targetselection.itb (change_target) disables "Run
Program" and "Continue..." buttons when the target is "exec",
enables them for all others.
Index: targetselection.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
retrieving revision 1.5
diff -u -r1.5 targetselection.itb
--- targetselection.itb 2000/10/26 20:47:57 1.5
+++ targetselection.itb 2000/10/31 19:20:03
@@ -487,21 +487,33 @@
set var [pref varname gdb/src/run_load]
checkbutton $frame.load -text {Download Program} -variable $var
+ set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw -labeltext "Run Method" ]
+ set run_method [ $rm_frame childsite ]
+
+ set rm_label [label $frame.label -text "Run Method:"]
set var [pref varname gdb/src/run_cont]
- radiobutton $frame.cont -text {Continue from Last Stop} -value 1 -variable $var \
+ radiobutton $run_method.cont -text {Continue from Last Stop} -value 1 -variable $var \
-command [code $this set_run run]
set var [pref varname gdb/src/run_run]
- radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
+ radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
-command [code $this set_run cont]
# The after attaching command entry
set _after_entry [entry $frame.aftere]
label $frame.afterl -text {Command to issue after attaching:}
- grid $frame.attach $frame.run -sticky w
- grid $frame.load $frame.cont -sticky w
- grid $frame.afterl -sticky we -columnspan 2
- grid $frame.aftere -sticky we -columnspan 2
+
+ grid $frame.label -column 1 -row 0 -sticky w
+ grid $frame.attach -column 0 -row 1 -ipady 2
+ grid $frame.load -column 0 -row 2 -ipady 2
+
+ grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
+ grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
+
+ grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
+
+ grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
+ grid $frame.aftere -sticky we -columnspan 2 -ipady 2
grid columnconfigure $frame 0 -weight 1
grid columnconfigure $frame 1 -weight 1
@@ -722,6 +734,15 @@
body TargetSelection::change_target {w {name ""}} {
if {$name == ""} {return}
set target [get_target $name]
+
+ if { "$target" == "exec" } {
+ $run_method.run configure -state disabled -value 1
+ $run_method.cont configure -state disabled
+ } else {
+ $run_method.run configure -state normal
+ $run_method.cont configure -state normal
+ }
+
debug "$target"
set defbaud $gdb_target($target,defbaud)
pref define gdb/load/$target-baud $defbaud
Index: targetselection.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
retrieving revision 1.2
diff -u -r1.2 targetselection.ith
--- targetselection.ith 2000/03/10 23:41:47 1.2
+++ targetselection.ith 2000/10/31 19:20:03
@@ -55,6 +55,8 @@
variable MoreButton
variable MoreFrame
variable MoreLabel
+
+ variable run_method
proc _init_prefs {}
proc default_port {}
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2000-10-31 12:10 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200010272126.RAA02584@ozma.smith-house.org>
2000-10-30 12:53 ` [RFA] 100494 fix Fernando Nasser
2000-10-30 15:45 ` Larry Smith
2000-10-31 9:19 ` Larry Smith
2000-10-31 9:23 ` Syd Polk
2000-10-31 10:06 ` Larry Smith
2000-10-31 10:33 ` Syd Polk
2000-10-31 10:51 ` Fernando Nasser
2000-10-31 11:23 ` Larry Smith
2000-10-31 11:30 ` Syd Polk
2000-10-31 11:22 ` Fernando Nasser
2000-10-31 11:42 Larry Smith
2000-10-31 12:06 ` Fernando Nasser
2000-10-31 12:10 ` Syd Polk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).