* [PATCH] Target selection help
@ 2005-09-01 5:10 Keith Seitz
0 siblings, 0 replies; only message in thread
From: Keith Seitz @ 2005-09-01 5:10 UTC (permalink / raw)
To: insight
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
Hi,
I've committed the attached patch which:
* enables the Help button in the target selection dialog
* hides the "use xterm as inferior's tty" option on non-unix hosts
* updates the target selection dialog's help
Keith
ChangeLog
2005-08-31 Keith Seitz <keiths@redhat.com>
* library/help/target.html: Update dialog options.
* library/targetselection.itb (help): Implement.
(build_win): Don't disable help button.
Only display "use tty" option on unix hosts.
[-- Attachment #2: targetsel-help.patch --]
[-- Type: text/x-patch, Size: 3441 bytes --]
Index: library/targetselection.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
retrieving revision 1.16
diff -u -p -r1.16 targetselection.itb
--- library/targetselection.itb 2 Jul 2004 23:09:33 -0000 1.16
+++ library/targetselection.itb 1 Sep 2005 05:08:10 -0000
@@ -485,9 +485,12 @@ itcl::body TargetSelection::build_win {}
entry $f.fr.bp.func -textvariable [pref varname gdb/load/bp_func] -width 20
checkbutton $f.fr.verb -text [gettext "Display Download Dialog"] \
-variable [pref varname gdb/load/$target-verbose]
- checkbutton $f.fr.xterm -text [gettext "Use xterm as inferior's tty"] \
- -variable [pref varname gdb/process/xtermtty] \
- -onvalue yes -offvalue no
+
+ if {$tcl_platform(platform) == "unix"} {
+ checkbutton $f.fr.xterm -text [gettext "Use xterm as inferior's tty"] \
+ -variable [pref varname gdb/process/xtermtty] \
+ -onvalue yes -offvalue no
+ }
if {![pref get gdb/control_target]} {
$f.fr.main configure -state disabled
@@ -585,8 +588,8 @@ itcl::body TargetSelection::build_win {}
-default active
button $btns.cancel -text [gettext Cancel] -width 7 \
-command [code $this cancel]
- button $btns.help -text [gettext Help] -width 7 -command [code $this help] \
- -state disabled
+ button $btns.help -text [gettext Help] -width 7 -command [code $this help]
+
standard_button_box $btns
bind $btns.ok <Return> "$btns.ok flash; $btns.ok invoke"
bind $btns.cancel <Return> "$btns.cancel flash; $btns.cancel invoke"
@@ -974,6 +977,7 @@ itcl::body TargetSelection::set_check_bu
# METHOD: help - launches context sensitive help.
# ------------------------------------------------------------------
itcl::body TargetSelection::help {} {
+ open_help target.html
}
# ------------------------------------------------------------------
Index: library/help/target.html
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/help/target.html,v
retrieving revision 1.2
diff -u -p -r1.2 target.html
--- library/help/target.html 19 Dec 2002 21:28:09 -0000 1.2
+++ library/help/target.html 1 Sep 2005 05:08:10 -0000
@@ -20,7 +20,10 @@ options.</P>
<UL>
<LI><A HREF="#options_run_until_main">Run until 'main'</A></LI>
<LI><A HREF="#options_bp_at_exit">Set breakpoint at 'exit'</A></LI>
+<LI><A HREF="#options_set_bp_at">Set user-specifid breakpoint</A></LI>
<LI><A HREF="#options_download_dialog">Display Download Dialog</A></LI>
+<LI><A HREF="#options_use_xterm">Use xterm for inferior's tty (unix only)
+ </A></LI>
</UL>
<h3><A HREF="#more_options">More Options</A></h3>
@@ -60,9 +63,14 @@ Three run options which may be selected
<DD>Sets a breakpoint at main()
<DT><A NAME="options_bp_at_exit">Set breakpoint at 'exit'</A>
<DD>Sets a breakpoint at exit()
+ <DT><A NAME="options_set_bp_at">Set breakpoint at</A>
+ <DD>Sets a breakpoint at a user-specified locaiton</A>
<DT><A NAME="options_download_dialog">Display Download Dialog</A>
<DD>Displays a dialog showing the progress of the download to
the target section by section
+ <DT><A NAME="options_use_xterm">Use xterm as inferior's tty</A>
+ <DD>Causes insight to open a tty for inferior I/O (unix versions
+ only)
</DL>
<BR>
<H3><A NAME="more_options">More Options</A></H3>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-09-01 5:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-01 5:10 [PATCH] Target selection help Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).