[patch] cygwin -Werror build fix

[patch] cygwin -Werror build fix

[Brian Dessent]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]


This fixes building with -Werror (which is now enabled by default) under Cygwin.

2006-03-28  Brian Dessent  <brian@dessent.net>

	* generic/gdbtk-cmds.c: Include sys/cygwin.h if __CYGWIN__ defined.

[-- Attachment #2: insight_cygwin_werror.patch --]
[-- Type: text/plain, Size: 549 bytes --]

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.91
diff -u -p -r1.91 gdbtk-cmds.c
--- generic/gdbtk-cmds.c	23 Dec 2005 18:23:15 -0000	1.91
+++ generic/gdbtk-cmds.c	29 Mar 2006 00:51:15 -0000
@@ -64,6 +64,10 @@
 #include "dis-asm.h"
 #include "gdbcmd.h"
 
+#ifdef __CYGWIN__
+#include <sys/cygwin.h>		/* for cygwin32_conv_to_full_win32_path */
+#endif
+
 #ifdef HAVE_CTYPE_H
 #include <ctype.h>		/* for isprint() */
 #endif

Re: [patch] cygwin -Werror build fix

[Christopher Faylor]

On Tue, Mar 28, 2006 at 04:56:04PM -0800, Brian Dessent wrote:
>
>This fixes building with -Werror (which is now enabled by default) under Cygwin.
>
>2006-03-28  Brian Dessent  <brian@dessent.net>
>
>	* generic/gdbtk-cmds.c: Include sys/cygwin.h if __CYGWIN__ defined.
>Index: generic/gdbtk-cmds.c
>===================================================================
>RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
>retrieving revision 1.91
>diff -u -p -r1.91 gdbtk-cmds.c
>--- generic/gdbtk-cmds.c	23 Dec 2005 18:23:15 -0000	1.91
>+++ generic/gdbtk-cmds.c	29 Mar 2006 00:51:15 -0000
>@@ -64,6 +64,10 @@
> #include "dis-asm.h"
> #include "gdbcmd.h"
> 
>+#ifdef __CYGWIN__
>+#include <sys/cygwin.h>		/* for cygwin32_conv_to_full_win32_path */
>+#endif
>+
> #ifdef HAVE_CTYPE_H
> #include <ctype.h>		/* for isprint() */
> #endif

That looks like an obvious fix to me.  Please check it in.

In fact, if this function is still being referred to as
cygwin32_conv_to_full_win32_path then I'd appreciate it if you would change the
cygwin32 -> cygwin.

cgf

Re: [patch] cygwin -Werror build fix

[Brian Dessent]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Christopher Faylor wrote:

> That looks like an obvious fix to me.  Please check it in.
> 
> In fact, if this function is still being referred to as
> cygwin32_conv_to_full_win32_path then I'd appreciate it if you would change the
> cygwin32 -> cygwin.

Ok.  Committed the attached.

2006-03-29  Brian Dessent  <brian@dessent.net>

	* generic/gdbtk-cmds.c: Include sys/cygwin.h if __CYGWIN__ defined.
	(gdb_path_conv): Call cygwin_conv_to_full_win32_path instead.

[-- Attachment #2: insight_cygwin_werror_2.patch --]
[-- Type: text/plain, Size: 870 bytes --]

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.91
diff -u -p -r1.91 gdbtk-cmds.c
--- generic/gdbtk-cmds.c	23 Dec 2005 18:23:15 -0000	1.91
+++ generic/gdbtk-cmds.c	29 Mar 2006 13:36:51 -0000
@@ -64,6 +64,10 @@
 #include "dis-asm.h"
 #include "gdbcmd.h"
 
+#ifdef __CYGWIN__
+#include <sys/cygwin.h>		/* for cygwin_conv_to_full_win32_path */
+#endif
+
 #ifdef HAVE_CTYPE_H
 #include <ctype.h>		/* for isprint() */
 #endif
@@ -2825,7 +2829,7 @@ gdb_path_conv (ClientData clientData, Tc
   {
     char pathname[256], *ptr;
 
-    cygwin32_conv_to_full_win32_path (Tcl_GetStringFromObj (objv[1], NULL),
+    cygwin_conv_to_full_win32_path (Tcl_GetStringFromObj (objv[1], NULL),
 				      pathname);
     for (ptr = pathname; *ptr; ptr++)
       {