From: Denis PILAT <denis.pilat@st.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>, insight@sources.redhat.com
Cc: Denis PILAT <denis.pilat@st.com>
Subject: Re: testsuite/gdb.gdbtk
Date: Fri, 12 Sep 2008 14:20:00 -0000 [thread overview]
Message-ID: <48B6A06D.6080406@st.com> (raw)
In-Reply-To: <480F1BFF.5040305@st.com>
I forgot to ping you about this patch.
--
Denis
>
> About patches, would somebody accept the following one that avoid
> having an error when TCL_LIBRARY variable is not set ?
> Thanks,
>
> --
> Denis
>
> 2008-04-23 Denis Pilat <denis.pilat@st.com>
>
> * insight-support.exp (gdbtk_start): test TCL_LIBRARY env. variable
> before being unset.
>
>
> Index: insight-support.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.gdbtk/insight-support.exp,v
> retrieving revision 1.2
> diff -u -p -r1.2 insight-support.exp
> --- insight-support.exp 8 Feb 2007 17:12:50 -0000 1.2
> +++ insight-support.exp 23 Apr 2008 11:05:58 -0000
> @@ -98,8 +98,9 @@ proc gdbtk_start {test} {
> set env(SRCDIR) $abs_srcdir
> set env(GDBTK_VERBOSE) 1
> set env(GDBTK_LOGFILE) [to_tcl_path [file join $objdir gdb.log]]
> - unset -nocomplain env(TCL_LIBRARY)
> -
> + if {[info exists env(TCL_LIBRARY)]} {
> + unset -nocomplain env(TCL_LIBRARY)
> + }
> set err [catch {exec $INSIGHT -nx -q --tclcommand=$test} res]
> if { $err } {
> perror "Execing $INSIGHT failed: $res"
>
>
>
>
>
>
> Maciej W. Rozycki wrote:
>> On Tue, 22 Apr 2008, Denis PILAT wrote:
>>
>>
>>> I'm wondering why this directory is not delivered within insight
>>> distribution.
>>> Is there anybody who knows if this testsuite is maintained and
>>> working well ?
>>>
>>
>> It mostly worked for me for the mipsisa32-sde-elf target and the
>> mips-sim-sde32 target board the last time I tried -- that's a
>> configuration using the GNU simulator. There may have been two or three
>> failures which I had no time to investigate unfortunately, but the
>> majority of tests passed. I have no access to that configuration
>> anymore,
>> but I hope that sounds encouraging to you. As to maintenance, I
>> would not
>> call that very active, but I am sure if you find a bug and prepare a fix
>> which you will post here, it will be gladly accepted. :-)
>>
>> Maciej
>>
>>
>
next prev parent reply other threads:[~2008-08-28 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 6:51 testsuite/gdb.gdbtk Denis PILAT
2008-04-22 18:53 ` testsuite/gdb.gdbtk Maciej W. Rozycki
2008-04-23 11:23 ` testsuite/gdb.gdbtk Denis PILAT
2008-04-23 14:54 ` testsuite/gdb.gdbtk Maciej W. Rozycki
2008-04-23 18:12 ` testsuite/gdb.gdbtk Keith Seitz
2008-09-12 14:20 ` Denis PILAT [this message]
[not found] ` <48D30B30.4020407@redhat.com>
2008-09-20 20:41 ` testsuite/gdb.gdbtk Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B6A06D.6080406@st.com \
--to=denis.pilat@st.com \
--cc=insight@sources.redhat.com \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).