public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Dave Poston <dave@ideaworks3d.com>
To: insight@sourceware.org
Subject: fix for help with mingw build
Date: Wed, 08 Oct 2008 12:38:00 -0000	[thread overview]
Message-ID: <48ECA997.1050502@ideaworks3d.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hi,

      Insight 6.8 built under mingw fires an 'unknown command
ide_shell_execute' if you try to use help.

      Attached is a fix for this, registration of ide_shell_execute needs
to happen under mingw as well as cygwin.

      Also the ide_shell_execute command with 'open' as its operation
didn't work for me, whereas using "" (default action, equivalent to
double-clicking the file) did.

      I'm new to this business of sending patches around, let me know if
I've got anything wrong!

Dave









[-- Attachment #2: diff.txt --]
[-- Type: text/plain, Size: 1199 bytes --]

diff -Nurb insight-6.8-orig/insight-6.8/gdb/gdbtk/generic/gdbtk.c insight-6.8/insight-6.8/gdb/gdbtk/generic/gdbtk.c
--- insight-6.8-orig/insight-6.8/gdb/gdbtk/generic/gdbtk.c	Mon Mar  3 23:25:04 2008
+++ insight-6.8/insight-6.8/gdb/gdbtk/generic/gdbtk.c	Tue Oct  7 18:21:23 2008
@@ -537,9 +537,13 @@
   /* Path conversion functions.  */
   if (ide_create_cygwin_path_command (gdbtk_interp) != TCL_OK)
     error ("cygwin path command initialization failed");
+#endif
+
+#ifdef __WIN32__
   if (ide_create_shell_execute_command (gdbtk_interp) != TCL_OK)
     error ("cygwin shell execute command initialization failed");
 #endif
+
 
   /* Only for testing -- and only when it can't be done any
      other way. */
diff -Nurb insight-6.8-orig/insight-6.8/gdb/gdbtk/library/helpviewer.tcl insight-6.8/insight-6.8/gdb/gdbtk/library/helpviewer.tcl
--- insight-6.8-orig/insight-6.8/gdb/gdbtk/library/helpviewer.tcl	Sat Feb  9 01:23:42 2008
+++ insight-6.8/insight-6.8/gdb/gdbtk/library/helpviewer.tcl	Wed Oct  8 13:05:24 2008
@@ -25,7 +25,7 @@
 
   # windows is easy
   if {$::gdbtk_platform(platform) == "windows"} {
-    ide_shell_execute open $link
+    ide_shell_execute "" $link
     return
   }
 



                 reply	other threads:[~2008-10-08 12:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48ECA997.1050502@ideaworks3d.com \
    --to=dave@ideaworks3d.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).