public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* [OBV] Fix compilation failure
@ 2009-05-28 15:13 Pierre Muller
  2009-05-29  8:32 ` Keith Seitz
  0 siblings, 1 reply; 2+ messages in thread
From: Pierre Muller @ 2009-05-28 15:13 UTC (permalink / raw)
  To: insight

This commit
http://sourceware.org/ml/gdb-cvs/2009-05/msg00187.html

generated a compilation failure in gdbtk.

This patch below fixes the compilation failure.


Checked in as obvious

Keith, could you please double-check that 
this change is really what we want?


Pierre Muller
Pascal language support maintainer for GDB



ChangeLog entry:

2009-05-28  Pierre Muller  <muller@ics.u-strasbg.fr>

       * Adapt to VALUE_ADDRESS removal.
       generic/gdbtk-cmds.c (gdb_eval): Use value_address function instead
of
       VALUE_ADDRESS macro.


Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.110
diff -u -p -r1.110 gdbtk-cmds.c
--- generic/gdbtk-cmds.c        6 May 2009 15:52:11 -0000       1.110
+++ generic/gdbtk-cmds.c        28 May 2009 09:16:18 -0000
@@ -637,7 +637,7 @@ gdb_eval (ClientData clientData, Tcl_Int
   stb = mem_fileopen ();
   make_cleanup_ui_file_delete (stb);
   val_print (value_type (val), value_contents (val),
-            value_embedded_offset (val), VALUE_ADDRESS (val),
+            value_embedded_offset (val), value_address (val),
             stb, 0, &opts, current_language);
   result = ui_file_xstrdup (stb, &dummy);
   Tcl_SetObjResult (interp, Tcl_NewStringObj (result, -1));

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [OBV] Fix compilation failure
  2009-05-28 15:13 [OBV] Fix compilation failure Pierre Muller
@ 2009-05-29  8:32 ` Keith Seitz
  0 siblings, 0 replies; 2+ messages in thread
From: Keith Seitz @ 2009-05-29  8:32 UTC (permalink / raw)
  To: Pierre Muller; +Cc: insight

Pierre Muller wrote:

> Checked in as obvious

Thank you very much (again)!

> Keith, could you please double-check that 
> this change is really what we want?

If it isn't, I don't know what is! I've a similar change lying around 
here somewhere that I've been using for some time. Seems to work fine.

Keith

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-28 15:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-28 15:13 [OBV] Fix compilation failure Pierre Muller
2009-05-29  8:32 ` Keith Seitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).