libgui build machinery issues

libgui build machinery issues

[Ralf Wildenhues]

Hello libgui maintainers,

I'm working to update the src tree to newer autotools.  For this, I'm
looking at libgui, first trying to get it to build with old (2.59/1.9.6)
tools and --enable-maintainer-mode.

1) libgui/configure is not up to date, e.g., it doesn't have the changes
from this patch:

| config/ChangeLog:
| 2009-02-02  Doug Evans  <dje@google.com>
| 
|         * tcl.m4 (SC_PATH_TCLCONFIG): Don't exit 0 if tclconfig fails.
|         (SC_PATH_TKCONFIG): Don't exit 0 if tkconfig fails.
|         (SC_LOAD_TCLCONFIG): Quote all uses of TCL_BIN_DIR, it may contain
|         "# no Tcl configs found".
|         (SC_LOAD_TKCONFIG): Similarily for TK_BIN_DIR.

and I assume they ought to help also for libgui
(I can apply a patch to regenerate configure unless you disagree).


2) When run with --enable-maintainer-mode, libgui/library/Makefile
contains these expanded lines:
| TCLSH = @TCLSH@
[...]
| tclIndex: $(TCL)
|          echo "package require Itcl; auto_mkindex $(LIBGUI_LIBRARY_DIR) $(TCL)" | $(TCLSH)
| #tclIndex:

which leads to this error:

| make[4]: Entering directory `/tmp/build/libgui/library'
| echo "package require Itcl; auto_mkindex /tmp/src/libgui/library advice.tcl balloon.tcl bbox.tcl bgerror.tcl bindings.tcl canvas.tcl cframe.tcl center.tcl debug.tcl def.tcl internet.tcl font.tcl gensym.tcl gettext.tcl hooks.tcl lframe.tcl list.tcl looknfeel.tcl menu.tcl mono.tcl multibox.tcl parse_args.tcl path.tcl postghost.tcl prefs.tcl print.tcl sendpr.tcl topbind.tcl toolbar.tcl ulset.tcl wframe.tcl wingrab.tcl ventry.tcl combobox.tcl pane.tcl panedwindow.tcl" | @TCLSH@
| /bin/sh: @TCLSH@: command not found
| make[4]: *** [tclIndex] Error 127
| make[4]: Leaving directory `/tmp/build/libgui/library'

@TCLSH@ is not substituted by configure.  Maybe it was at some point
back?  Looking at the tree, I cannot tell what would be the right thing
here, or how this broke.  Maybe you need SC_PROG_TCLSH from
config/tcl.m4 and then use TCLSH_PROG, or BUILD_TCLSH?

To reproduce: I have configured my tree with
  '--enable-shared' '--disable-rda' '--enable-libgloss' '--enable-sim' \
  '--enable-maintainer-mode'


Thanks, and please Cc: me on replies.

Cheers,
Ralf

Re: libgui build machinery issues

[Keith Seitz]

On 08/17/2009 10:43 PM, Ralf Wildenhues wrote:
> | config/ChangeLog:
> | 2009-02-02  Doug Evans<dje@google.com>
> |
> |         * tcl.m4 (SC_PATH_TCLCONFIG): Don't exit 0 if tclconfig fails.
> |         (SC_PATH_TKCONFIG): Don't exit 0 if tkconfig fails.
> |         (SC_LOAD_TCLCONFIG): Quote all uses of TCL_BIN_DIR, it may contain
> |         "# no Tcl configs found".
> |         (SC_LOAD_TKCONFIG): Similarily for TK_BIN_DIR.
>
> and I assume they ought to help also for libgui
> (I can apply a patch to regenerate configure unless you disagree).

Yes, please. It was probably just on oversight on my part.

> @TCLSH@ is not substituted by configure.  Maybe it was at some point
> back?  Looking at the tree, I cannot tell what would be the right thing
> here, or how this broke.  Maybe you need SC_PROG_TCLSH from
> config/tcl.m4 and then use TCLSH_PROG, or BUILD_TCLSH?
>
> To reproduce: I have configured my tree with
>    '--enable-shared' '--disable-rda' '--enable-libgloss' '--enable-sim' \
>    '--enable-maintainer-mode'

Yes, I think that the old configure was substituting TCLSH, but that got 
borked at some time or another. Using SC_PROG_TCLSH should be good 
enough. I'm the only one that ever really tweaks it, and that is as 
little as I possibly can manage. ;-)

If there is anything you would like me to do, don't hesitate to ask.

Keith