Re: Build insight cvs-head get error

[Keith Seitz <keiths@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

On 01/25/2010 12:21 AM, Hui Zhu wrote:

> ../../src/gdb/gdbtk/generic/gdbtk-cmds.c: In function 'gdb_set_inferior_args':
> ../../src/gdb/gdbtk/generic/gdbtk-cmds.c:867: error: void value not
> ignored as it ought to be

I've checked in the attached patch for this.

Keith

ChangeLog
2010-01-25  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-cmds.c (gdb_set_inferior_args): set_inferior_args
	now works as expected. Do not strdup/free the argument string.


[-- Attachment #2: set_inferior_args.patch --]
[-- Type: text/plain, Size: 753 bytes --]

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.114
retrieving revision 1.115
diff -u -p -r1.114 -r1.115
--- generic/gdbtk-cmds.c	4 Jan 2010 20:14:46 -0000	1.114
+++ generic/gdbtk-cmds.c	25 Jan 2010 19:59:29 -0000	1.115
@@ -859,13 +859,7 @@ gdb_set_inferior_args (ClientData client
     }
 
   args = Tcl_GetStringFromObj (objv[1], NULL);
-
-  /* The xstrdup/xfree stuff is so that we maintain a coherent picture
-     for gdb.  I would expect the accessors to do this, but they
-     don't.  */
-  args = xstrdup (args);
-  args = set_inferior_args (args);
-  xfree (args);
+  set_inferior_args (args);
 
   return TCL_OK;
 }