From: Keith Seitz <keiths@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: insight@sourceware.org
Subject: Re: [OBV] Fix Build gdbtk-cmds.c get error
Date: Sat, 19 Jun 2010 18:01:00 -0000 [thread overview]
Message-ID: <4C1D05F8.7070208@redhat.com> (raw)
In-Reply-To: <001201cb0f35$04c60240$0e5206c0$@muller@ics-cnrs.unistra.fr>
On 06/18/2010 03:24 PM, Pierre Muller wrote:
> I checked the following in:
> Note that it fixes the val_print problem
> and also cygwin specific problems to
> allow compilation with both 1.5 and 1.7 cygwin...
Aside from the cygwin stuff, I had a similar patch that I simply forgot
to check in. Thank you for beating me to it! :-)
> For the cygwin_conv_path function,
> I used the same macros as in gdb/windows-nat.c source.
>
> Please feel free to suggest better
> fixes.
That all looks okay. If anything is amiss, it can be addressed in time.
> I didn't dare to change
> GDB_val_print function, as this could have implications
> for tcl/tk scripts... Am I right on this?
GDB_val_print is simply a wrapper which prevents gdb from longjmp'ing
out of the Tcl interpreter. With the advent of "exceptions," the
wrappers aren't really necessary any more. Maybe I'll clean this up some
time...
> PS: I only fixed compilation and I am still unable to
> really test cygwin insight :(
I can see if my twelve year old box still boots and give it a quick
sanity check.
Thanks again for the patch,
Keith
next prev parent reply other threads:[~2010-06-19 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 9:55 Hui Zhu
2010-06-17 2:18 ` Hui Zhu
2010-06-18 22:24 ` [OBV] Fix " Pierre Muller
2010-06-19 18:01 ` Keith Seitz [this message]
[not found] ` <4426260533430796929@unknownmsgid>
2010-06-19 15:46 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1D05F8.7070208@redhat.com \
--to=keiths@redhat.com \
--cc=insight@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).