public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: insight@sourceware.org
Subject: Re: Build gdbtk-cmds.c get error
Date: Sun, 04 Jul 2010 18:13:00 -0000	[thread overview]
Message-ID: <4C30CF29.7090009@redhat.com> (raw)
In-Reply-To: <AANLkTilE650elPh967paUiu7g1XSUoIS7j4zIQ6OqSzb@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On 07/04/2010 01:20 AM, Hui Zhu wrote:
> ../../src/gdb/gdbtk/generic/gdbtk-bp.c:558: error: too many arguments
> to function 'create_breakpoint'

I've committed the attached patch to fix this, another API change in gdb.

Thank you for bringing this to my attention.

Keith

ChangeLog
2010-07-04  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-bp.c (gdb_set_bp): Update arguments for API
	change in create_breakpoint.

[-- Attachment #2: update-create-breakpoint-api.patch --]
[-- Type: text/plain, Size: 696 bytes --]

Index: generic/gdbtk-bp.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v
retrieving revision 1.36
diff -u -p -r1.36 gdbtk-bp.c
--- generic/gdbtk-bp.c	2 Apr 2010 23:39:55 -0000	1.36
+++ generic/gdbtk-bp.c	4 Jul 2010 18:09:32 -0000
@@ -549,8 +549,7 @@ gdb_set_bp (ClientData clientData, Tcl_I
       create_breakpoint (get_current_arch (), address, condition, thread,
 			 0	/* condition and thread are valid */,
 			 temp,
-			 0	/* hardware flag */,
-			 0	/* trace flag */,
+			 bp_breakpoint /* type wanted */,
 			 ignore_count,
 			 (pending ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE),
 			 NULL	/* breakpoint ops */,

  reply	other threads:[~2010-07-04 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-04  8:20 Hui Zhu
2010-07-04 18:13 ` Keith Seitz [this message]
2010-07-05  5:54   ` Hui Zhu
  -- strict thread matches above, loose matches on Subject: below --
2010-06-14  9:55 Hui Zhu
2010-06-17  2:18 ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C30CF29.7090009@redhat.com \
    --to=keiths@redhat.com \
    --cc=insight@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).