[BUG] gdbtk-bp.c: got build error

[BUG] gdbtk-bp.c: got build error

[Hui Zhu]

gcc -g   -I. -I../../src/gdb -I../../src/gdb/common
-I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\""
-DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
-I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd
-I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber
-I../../src/gdb/../libdecnumber  -I../../src/gdb/gnulib -Ignulib
-DMI_OUT=1 -DTUI=1  -DGDBTK -I/usr/include -I/usr/include  -Wall
-Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral
-Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function
-Wno-switch -Wno-char-subscripts -Werror -c -o gdbtk-bp.o -MT
gdbtk-bp.o -MMD -MP -MF .deps/gdbtk-bp.Tpo
-I../../src/gdb/../libgui/src    -I/home/teawater/gdb/src/tcl/generic
-I/home/teawater/gdb/src/tk/generic
-DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\"
-DSRC_DIR=\"/home/teawater/gdb/src/gdb\"
../../src/gdb/gdbtk/generic/gdbtk-bp.c
../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_set_bp':
../../src/gdb/gdbtk/generic/gdbtk-bp.c:557: error: too few arguments
to function 'create_breakpoint'
make[2]: *** [gdbtk-bp.o] Error 1
make[2]: Leaving directory `/home/teawater/gdb/bgdbno/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `/home/teawater/gdb/bgdbno'
make: *** [all] Error 2

Re: [BUG] gdbtk-bp.c: got build error

[Keith Seitz]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On 11/13/2010 06:58 AM, Hui Zhu wrote:
> ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_set_bp':
> ../../src/gdb/gdbtk/generic/gdbtk-bp.c:557: error: too few arguments
> to function 'create_breakpoint'

Thank you for reporting this. I've committed the attached patch to fix this.

Keith

ChangeLog
2010-11-13  Keith Seitz  <keiths@valrhona.uglyboxes.com>

	* generic/gdbtk-bp.c (gdb_set_bp): Update for recent
	create_breakpoint API update.

[-- Attachment #2: create_breakpoint-update.patch --]
[-- Type: text/plain, Size: 542 bytes --]

Index: generic/gdbtk-bp.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v
retrieving revision 1.37
diff -u -p -r1.37 gdbtk-bp.c
--- generic/gdbtk-bp.c	4 Jul 2010 18:13:14 -0000	1.37
+++ generic/gdbtk-bp.c	13 Nov 2010 23:23:29 -0000
@@ -554,7 +554,7 @@ gdb_set_bp (ClientData clientData, Tcl_I
 			 (pending ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE),
 			 NULL	/* breakpoint ops */,
 			 0	/* from_tty */,
-			 enabled);
+			 enabled, 0);
     }
 
   if (e.reason < 0)

Re: [BUG] gdbtk-bp.c: got build error

[Hui Zhu]

It's OK now.  Thanks Keith.

Hui

On Sun, Nov 14, 2010 at 07:22, Keith Seitz <keiths@redhat.com> wrote:
> On 11/13/2010 06:58 AM, Hui Zhu wrote:
>>
>> ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_set_bp':
>> ../../src/gdb/gdbtk/generic/gdbtk-bp.c:557: error: too few arguments
>> to function 'create_breakpoint'
>
> Thank you for reporting this. I've committed the attached patch to fix this.
>
> Keith
>
> ChangeLog
> 2010-11-13  Keith Seitz  <keiths@valrhona.uglyboxes.com>
>
>        * generic/gdbtk-bp.c (gdb_set_bp): Update for recent
>        create_breakpoint API update.
>