From: Keith Seitz <keiths@redhat.com>
To: Jeffrey Armstrong <jeffrey.armstrong@approximatrix.com>
Cc: insight@sourceware.org
Subject: Re: Patch for setting breakpoints in source window
Date: Tue, 28 Feb 2012 21:58:00 -0000 [thread overview]
Message-ID: <4F4D4DEC.5030705@redhat.com> (raw)
In-Reply-To: <CAONw715PVBxwA=ieuh7=8LEDoLMZQDgV7ggKWf71o90cyjsqcg@mail.gmail.com>
On 12/06/2011 11:23 AM, Jeffrey Armstrong wrote:
> I've been experiencing issues with Insight compiled via MinGW under
> Windows where the user cannot set breakpoints via the source window
> under certain circumstances. The culprit appears to be a failure to
> wrap the filename in quotes when passing it to gdb. Normally this
> isn't a problem, but when a space is present in the full path name, as
> is so common on Windows, the breakpoint fails to be set. I've
> attached a simple patch below that shouldn't have any detrimental side
> effects on other OSes.
Hi,
Thank you for the patch. You're right, that should not present any
problems on any platforms. I've committed your patch with the following
ChangeLog:
2012-02-28 Keith Seitz <keiths@redhat.com>
From Jeffrey Armstrong <jeffrey.armstrong@approximatrix.com>:
* library/srctextwin.itb (lookup_line): Quote the filename
to gdb_set_bp.
Keith
prev parent reply other threads:[~2012-02-28 21:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 19:23 Jeffrey Armstrong
2012-02-28 21:58 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4D4DEC.5030705@redhat.com \
--to=keiths@redhat.com \
--cc=insight@sourceware.org \
--cc=jeffrey.armstrong@approximatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).