public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Roland Schwingel <roland@onevision.com>
To: insight@sourceware.org
Subject: [PATCH] Allow onlinehelp to work on native windows
Date: Mon, 19 Mar 2012 11:51:00 -0000	[thread overview]
Message-ID: <4F671D87.8060909@onevision.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hello,

Here comes a simple patch allowing insight's onlinehelp also to be 
opened on native windows, not only on cygwin.
It still continues to work on cygwin, too.

Changelog:

2012-03-19  Roland Schwingel <roland.schwingel@onevision.com>

         * generic/gdbtk.c: (gdbtk_init): Move call to 
ide_create_shell_execute_command
         to generic windows section.

Any comments? Is this ok?

Roland

[-- Attachment #2: mingw_onlinehelp_gdbtk.c.patch --]
[-- Type: text/plain, Size: 853 bytes --]

--- gdbtk_orig/generic/gdbtk.c	2012-03-19 11:21:15.542232400 +0100
+++ gdbtk/generic/gdbtk.c	2012-03-19 11:23:12.099170600 +0100
@@ -540,13 +540,13 @@
     error ("windows print code initialization failed");
   if (ide_create_win_grab_command (gdbtk_interp) != TCL_OK)
     error ("grab support command initialization failed");
+  if (ide_create_shell_execute_command (gdbtk_interp) != TCL_OK)
+    error ("cygwin shell execute command initialization failed");
 #endif
 #ifdef __CYGWIN32__
   /* Path conversion functions.  */
   if (ide_create_cygwin_path_command (gdbtk_interp) != TCL_OK)
     error ("cygwin path command initialization failed");
-  if (ide_create_shell_execute_command (gdbtk_interp) != TCL_OK)
-    error ("cygwin shell execute command initialization failed");
 #endif
 
   /* Only for testing -- and only when it can't be done any

             reply	other threads:[~2012-03-19 11:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 11:51 Roland Schwingel [this message]
2012-03-29 23:17 ` Keith Seitz
2012-03-30  7:09 Roland Schwingel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F671D87.8060909@onevision.com \
    --to=roland@onevision.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).