From: Roland Schwingel <roland@onevision.com>
To: Keith Seitz <keiths@redhat.com>, insight@sourceware.org
Subject: Re: [PATCH] Allow onlinehelp to work on native windows
Date: Fri, 30 Mar 2012 07:09:00 -0000 [thread overview]
Message-ID: <4F755BF5.6080005@onevision.com> (raw)
Hi Keith,
> > * generic/gdbtk.c: (gdbtk_init): Move call to
> ide_create_shell_execute_command
> > to generic windows section.
>
> This line is too long. Please wrap after "call". [We try to keep line
> lengths < 80 characters.]
Rewrapped the Changelog entry.
> > Any comments? Is this ok?
>
> Ok with that change.
In another email today you asked me to adapt copyright years on all
files I touch. In gdbtk.c the years have been also out of sync I
corrected that too and mentioned it in the changelog.
The change is now committed.
Thanks for taking a look,
Roland
next reply other threads:[~2012-03-30 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 7:09 Roland Schwingel [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-19 11:51 Roland Schwingel
2012-03-29 23:17 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F755BF5.6080005@onevision.com \
--to=roland@onevision.com \
--cc=insight@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).