From: Keith Seitz <keiths@redhat.com>
To: Roland Schwingel <roland@onevision.com>
Cc: insight@sourceware.org
Subject: Re: [PATCH] Compliancy to windows 64bit
Date: Thu, 29 Mar 2012 22:57:00 -0000 [thread overview]
Message-ID: <4F74E8B5.3000604@redhat.com> (raw)
In-Reply-To: <4F6721AE.1070406@onevision.com>
On 03/19/2012 05:08 AM, Roland Schwingel wrote:
> Any comments? Is this ok?
Wow, I had no idea we were harboring such evil code... Passing host
pointers into the interpreter and back again. Eeeew! [Alas, this portion
of insight is probably about the oldest...] This whole thing should have
been done some other way. [But that's probably not the comment you're
attempting to elicit. :-)]
Just a nit:
> --- gdbtk_orig/generic/gdbtk-stack.c 2012-03-05 09:19:01.000000000 +0100
> +++ gdbtk/generic/gdbtk-stack.c 2012-03-14 11:56:31.851248200 +0100
> @@ -289,7 +289,7 @@
> return TCL_ERROR;
> }
>
> - arguments = (long) clientData;
> + arguments = clientData!=NULL?1:0;
>
> /* Initialize the result pointer to an empty list. */
>
This isn't formatted properly. It should be:
arguments = clientData != NULL ? 1 : 0;
Okay with that change.
Keith
next prev parent reply other threads:[~2012-03-29 22:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 12:08 Roland Schwingel
2012-03-29 22:57 ` Keith Seitz [this message]
2012-03-30 7:39 Roland Schwingel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F74E8B5.3000604@redhat.com \
--to=keiths@redhat.com \
--cc=insight@sourceware.org \
--cc=roland@onevision.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).