From: Roland Schwingel <roland@onevision.com>
To: Keith Seitz <keiths@redhat.com>, insight@sourceware.org
Subject: Re: [PATCH] Compliancy to windows 64bit
Date: Fri, 30 Mar 2012 07:39:00 -0000 [thread overview]
Message-ID: <4F7562FE.5030308@onevision.com> (raw)
Hi...
Keith Seitz <keiths@redhat.com> wrote on 30.03.2012 00:56:53:
> Wow, I had no idea we were harboring such evil code... Passing host
> pointers into the interpreter and back again. Eeeew! [Alas, this portion
> of insight is probably about the oldest...] This whole thing should have
> been done some other way. [But that's probably not the comment you're
> attempting to elicit. :-)]
;-)
> Just a nit:
> > - arguments = (long) clientData;
> > + arguments = clientData!=NULL?1:0;
> This isn't formatted properly. It should be:
>
> arguments = clientData != NULL ? 1 : 0;
Fixed that on commit.
> Okay with that change.
I also updated copyright years in the 2 files touched by my changes and
mentioned that in Changelog.
Roland
next reply other threads:[~2012-03-30 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 7:39 Roland Schwingel [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-19 12:08 Roland Schwingel
2012-03-29 22:57 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7562FE.5030308@onevision.com \
--to=roland@onevision.com \
--cc=insight@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).