From: Keith Seitz <keiths@redhat.com>
To: insight <insight@sourceware.org>
Subject: [PATCH] Update API changes causing build errors
Date: Wed, 10 Oct 2012 17:54:00 -0000 [thread overview]
Message-ID: <5075B07B.6040106@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
Hi,
Gdb recently had some APIs updated, and insight was left unbuildable.
This patch should correct any problems.
Keith
ChangeLog
2012-10-10 Keith Seitz <keiths@redhat.com>
* generic/gdbtk-hooks.c (gdbtk_memory_changed): Change LEN
from int to ssize_t to match changes in the API.
(x_event): Use set_quit_flag to set the quit_flag.
* generic/gdbtk-cmds.c (gdb_stop): Likewise.
[-- Attachment #2: build-errors.patch --]
[-- Type: text/x-patch, Size: 2242 bytes --]
Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.55
diff -u -p -r1.55 gdbtk-hooks.c
--- generic/gdbtk-hooks.c 25 May 2012 11:36:08 -0000 1.55
+++ generic/gdbtk-hooks.c 10 Oct 2012 17:27:16 -0000
@@ -1,7 +1,7 @@
/* Startup code for Insight.
Copyright (C) 1994, 1995, 1996, 1997, 1998, 2000, 200, 2002, 2003, 2004,
- 2008, 2010, 2011 Free Software Foundation, Inc.
+ 2008, 2010, 2011, 2012 Free Software Foundation, Inc.
Written by Stu Grossman <grossman@cygnus.com> of Cygnus Support.
@@ -94,7 +94,7 @@ static void gdbtk_pre_add_symbol (const
static void gdbtk_print_frame_info (struct symtab *, int, int, int);
static void gdbtk_post_add_symbol (void);
static void gdbtk_register_changed (int regno);
-static void gdbtk_memory_changed (CORE_ADDR addr, int len,
+static void gdbtk_memory_changed (CORE_ADDR addr, ssize_t len,
const bfd_byte *data);
static void gdbtk_selected_frame_changed (int);
static void gdbtk_context_change (int);
@@ -399,7 +399,7 @@ gdbtk_register_changed (int regno)
}
static void
-gdbtk_memory_changed (CORE_ADDR addr, int len, const bfd_byte *data)
+gdbtk_memory_changed (CORE_ADDR addr, ssize_t len, const bfd_byte *data)
{
if (Tcl_Eval (gdbtk_interp, "gdbtk_memory_changed") != TCL_OK)
report_error ();
@@ -472,7 +472,7 @@ x_event (int signo)
}
if ((Tcl_GetIntFromObj (gdbtk_interp, varname, &val) == TCL_OK) && val)
{
- quit_flag = 1;
+ set_quit_flag ();
#ifdef REQUEST_QUIT
REQUEST_QUIT;
#else
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.128
diff -u -p -r1.128 gdbtk-cmds.c
--- generic/gdbtk-cmds.c 8 Aug 2012 13:50:32 -0000 1.128
+++ generic/gdbtk-cmds.c 10 Oct 2012 17:27:17 -0000
@@ -598,7 +598,7 @@ gdb_stop (ClientData clientData, Tcl_Int
if (target_ignore != (void (*) (void)) current_target.to_stop)
target_stop (gdbtk_get_ptid ());
else
- quit_flag = 1; /* hope something sees this */
+ set_quit_flag (); /* hope something sees this */
}
return TCL_OK;
reply other threads:[~2012-10-10 17:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5075B07B.6040106@redhat.com \
--to=keiths@redhat.com \
--cc=insight@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).