public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: "Andrew Burgess" <aburgess@broadcom.com>
To: insight@sourceware.org
Subject: [PATCH 0/2] Memory corruption caused by failure to notice architecture change.
Date: Thu, 05 Sep 2013 14:24:00 -0000	[thread overview]
Message-ID: <5228941F.8080601@broadcom.com> (raw)

Turns out that in a particular use case insight does not spot a change
of architecture, and then starts corrupting memory by accessing off the
end of the register cache.

I've got two patches,

[1/2] - Adds an assert that would detect this bug.

[2/2] - My attempt at a fix.  I've only had a quick look over the tcl
code, (and I'm no tcl expert), so I suspect some feedback on this one.

Cheers,
Andrew

             reply	other threads:[~2013-09-05 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 14:24 Andrew Burgess [this message]
2013-09-05 14:26 ` [PATCH 1/2] Add an assert that we're not overflowing the register cache Andrew Burgess
2013-09-05 18:55   ` Keith Seitz
2013-09-06  9:36     ` Andrew Burgess
2013-09-05 14:27 ` [PATCH 2/2] Notice architecture changes even when the register window is not open Andrew Burgess
2013-09-05 19:53   ` Keith Seitz
2013-09-06  9:21     ` Andrew Burgess
2013-09-06  9:40     ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5228941F.8080601@broadcom.com \
    --to=aburgess@broadcom.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).