building Tk from the src tree

building Tk from the src tree

[Ben Elliston]

I'm trying to build Tcl/Tk from the src tree on a Cygwin system that
has no previous installation of Tcl/Tk.  I'm striking a problem
whereby tk/win/configure invokes SC_PROG_TCLSH to find a tclsh shell
for building purposes -- it searches the user's $PATH and the build
tree for tclsh, but the tcl build directory will have only been
configured, not built.  How is this meant to work?

Is it the case that configure-tk should depend on all-tcl at the
top-level?

Thanks,
Ben

Re: building Tk from the src tree

[Keith Seitz]

On Sun, 2003-10-12 at 23:20, Ben Elliston wrote:
> I'm trying to build Tcl/Tk from the src tree on a Cygwin system that
> has no previous installation of Tcl/Tk.  I'm striking a problem
> whereby tk/win/configure invokes SC_PROG_TCLSH to find a tclsh shell
> for building purposes -- it searches the user's $PATH and the build
> tree for tclsh, but the tcl build directory will have only been
> configured, not built.  How is this meant to work?
> 

I just noticed this myself. Since we now use the same configury as the
standard Tcl and Tk (the installation dir tweak aside), I would say this
is a problem with Tk configury upstream.

Nonetheless, it seems to me that we should be able to fix this
ourselves. Have you tried making configure-tk depend on all-tcl? I doubt
that it would work (at least on Cygwin) without some more tweaking...

I haven't looked at it any, though.
Keith

Re: building Tk from the src tree

[Martin M. Hunt]

On Mon, 2003-10-13 at 08:42, Keith Seitz wrote:
> On Sun, 2003-10-12 at 23:20, Ben Elliston wrote:
> > I'm trying to build Tcl/Tk from the src tree on a Cygwin system that
> > has no previous installation of Tcl/Tk.  I'm striking a problem
> > whereby tk/win/configure invokes SC_PROG_TCLSH to find a tclsh shell
> > for building purposes -- it searches the user's $PATH and the build
> > tree for tclsh, but the tcl build directory will have only been
> > configured, not built.  How is this meant to work?
> > 
> 
> I just noticed this myself. Since we now use the same configury as the
> standard Tcl and Tk (the installation dir tweak aside), I would say this
> is a problem with Tk configury upstream.

Actually we don't really use the same configury.  Importing tcl/tk 8.4.1
and getting Insight to use it was trivial.  But I spent days on
configury stuff trying to get it to work in our framework.  It wouldn't
surprise me at all to find there were lots of errors in it. 

-- 
Martin M. Hunt <hunt@redhat.com>
Red Hat Inc.

Re: building Tk from the src tree

[Ben Elliston]

"Martin M. Hunt" <hunt@redhat.com> writes:

> Actually we don't really use the same configury.  Importing tcl/tk
> 8.4.1 and getting Insight to use it was trivial.  But I spent days
> on configury stuff trying to get it to work in our framework.  It
> wouldn't surprise me at all to find there were lots of errors in it.

Here is a patch that solved the problem I described. Okay to commit?

2003-10-14  Ben Elliston  <bje@wasabisystems.com>

	* win/tcl.m4 (SC_PROG_TCLSH): Replace with version from tcl/win.
	* win/configure: Regenerate.

Index: win/tcl.m4
===================================================================
RCS file: /cvsroot/gnu/tk/win/tcl.m4,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -p -r1.2 -r1.3
--- win/tcl.m4	11 Apr 2003 02:14:05 -0000	1.2
+++ win/tcl.m4	14 Oct 2003 02:06:32 -0000	1.3
@@ -694,7 +694,12 @@ AC_DEFUN(SC_PROG_TCLSH, [
     ])
 
     if test -f "$ac_cv_path_tclsh" ; then
-	TCLSH_PROG=$ac_cv_path_tclsh
+	TCLSH_PROG="$ac_cv_path_tclsh"
+	AC_MSG_RESULT($TCLSH_PROG)
+    elif test -f "$TCL_BIN_DIR/tclConfig.sh" ; then
+	# One-tree build.
+	ac_cv_path_tclsh="$TCL_BIN_DIR/tclsh"
+	TCLSH_PROG="$ac_cv_path_tclsh"
 	AC_MSG_RESULT($TCLSH_PROG)
     else
 	AC_MSG_ERROR(No tclsh found in PATH:  $search_path)

Re: building Tk from the src tree

[Keith Seitz]

On Tue, 2003-10-14 at 04:24, Ben Elliston wrote:
> Here is a patch that solved the problem I described. Okay to commit?

Abolsolutely! Thanks!

Keith

> 2003-10-14  Ben Elliston  <bje@wasabisystems.com>
> 
> 	* win/tcl.m4 (SC_PROG_TCLSH): Replace with version from tcl/win.
> 	* win/configure: Regenerate.
> 
> Index: win/tcl.m4
> ===================================================================
> RCS file: /cvsroot/gnu/tk/win/tcl.m4,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -p -r1.2 -r1.3
> --- win/tcl.m4	11 Apr 2003 02:14:05 -0000	1.2
> +++ win/tcl.m4	14 Oct 2003 02:06:32 -0000	1.3
> @@ -694,7 +694,12 @@ AC_DEFUN(SC_PROG_TCLSH, [
>      ])
>  
>      if test -f "$ac_cv_path_tclsh" ; then
> -	TCLSH_PROG=$ac_cv_path_tclsh
> +	TCLSH_PROG="$ac_cv_path_tclsh"
> +	AC_MSG_RESULT($TCLSH_PROG)
> +    elif test -f "$TCL_BIN_DIR/tclConfig.sh" ; then
> +	# One-tree build.
> +	ac_cv_path_tclsh="$TCL_BIN_DIR/tclsh"
> +	TCLSH_PROG="$ac_cv_path_tclsh"
>  	AC_MSG_RESULT($TCLSH_PROG)
>      else
>  	AC_MSG_ERROR(No tclsh found in PATH:  $search_path)
>