build failure

build failure

[Tom Tromey]

I updated and built the trunk today.  It failed like so:

gcc -c -g -O2    -I. -I../../src/gdb -I../../src/gdb/config -DLOCALEDIR="\"/home/tromey/gnu/baseline-gdb/install/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd  -I../../src/gdb/../include -I../intl -I../../src/gdb/../intl  -DMI_OUT=1 -DGDBTK -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized  -I../../src/gdb/../libgui/src  -I/home/tromey/gnu/baseline-gdb/src/itcl/itcl/generic \
-I/home/tromey/gnu/baseline-gdb/src/tcl/generic -I/home/tromey/gnu/baseline-gdb/src/tk/generic  -I/usr/X11R6/include -fwritable-strings \
	../../src/gdb/gdbtk/generic/gdbtk-interp.c
../../src/gdb/gdbtk/generic/gdbtk-interp.c: In function `gdbtk_interpreter_init':
../../src/gdb/gdbtk/generic/gdbtk-interp.c:62: parse error before `struct'
../../src/gdb/gdbtk/generic/gdbtk-interp.c:67: `alias' undeclared (first use in this function)
../../src/gdb/gdbtk/generic/gdbtk-interp.c:67: (Each undeclared identifier is reported only once
../../src/gdb/gdbtk/generic/gdbtk-interp.c:67: for each function it appears in.)../../src/gdb/gdbtk/generic/gdbtk-interp.c:67: `prefix' undeclared (first use in this function)
../../src/gdb/gdbtk/generic/gdbtk-interp.c:67: `cmd' undeclared (first use in this function)


I'm using x86 Red Hat Linux 7.3.  I built with the system compiler.

I'm checking in the appended patch as obvious.

Tom


Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* generic/gdbtk-interp.c (gdbtk_interpreter_init): Declare locals
	before code.

Index: generic/gdbtk-interp.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-interp.c,v
retrieving revision 1.1
diff -u -r1.1 gdbtk-interp.c
--- generic/gdbtk-interp.c 18 Feb 2003 23:33:05 -0000 1.1
+++ generic/gdbtk-interp.c 21 Feb 2003 17:24:39 -0000
@@ -56,13 +56,13 @@
 static void *
 gdbtk_interpreter_init (void)
 {
-  gdbtk_init ();
-
   /* Disable interpreter-exec. It causes us big trouble right now. */
   struct cmd_list_element *cmd = NULL;
   struct cmd_list_element *alias = NULL;
   struct cmd_list_element *prefix = NULL;
   struct cmd_list_element *c;
+
+  gdbtk_init ();
 
   if (lookup_cmd_composition ("interpreter-exec", &alias, &prefix, &cmd))
     {

Re: build failure

[Keith Seitz]

On Fri, 2003-02-21 at 09:17, Tom Tromey wrote:

> I'm using x86 Red Hat Linux 7.3.  I built with the system compiler.
> 
> I'm checking in the appended patch as obvious.

Wow, I must really be losing my mind. Too much Java and C++? I'm sure I
checked all that before I checked it in.

Oh well. Good catch. Thanks for the patch. I'll go back to being a
mindless zombie now.

Keith

Re: build failure

[Keith Seitz]

On Fri, 2003-02-21 at 09:54, Keith Seitz wrote:
> On Fri, 2003-02-21 at 09:17, Tom Tromey wrote:
> 
> > I'm using x86 Red Hat Linux 7.3.  I built with the system compiler.
> > 
> > I'm checking in the appended patch as obvious.
> 
> Wow, I must really be losing my mind. Too much Java and C++? I'm sure I
> checked all that before I checked it in.

Hmm. I just checked it again. It built just fine! Goofy.

Keith

Re: build failure

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Wow, I must really be losing my mind. 

You're probably using a newer gcc.

I probably have the details wrong, but I think this is a C99 feature
that is now enabled by default in gcc.  I did this build with 2.96,
though, which doesn't have this.

I've occasionally let `//' comments slip into C code, just because
some version of gcc or another didn't warn about that (and, of course,
too much Java programming).  It's really easy to fall into this.

Tom

Re: build failure

[Christopher Faylor]

On Fri, Feb 21, 2003 at 09:55:36AM -0800, Keith Seitz wrote:
>On Fri, 2003-02-21 at 09:54, Keith Seitz wrote:
>> On Fri, 2003-02-21 at 09:17, Tom Tromey wrote:
>> 
>> > I'm using x86 Red Hat Linux 7.3.  I built with the system compiler.
>> > 
>> > I'm checking in the appended patch as obvious.
>> 
>> Wow, I must really be losing my mind. Too much Java and C++? I'm sure I
>> checked all that before I checked it in.
>
>Hmm. I just checked it again. It built just fine! Goofy.

It worked for me, too, Keith.  So (and this will come as no surprise to
anyone) we are both crazy.

cgf

Re: build failure

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:

Keith> Shouldn't happen. I checked in a fix for that this
Keith> morning. Does gdbtk.c include cli-out.h? Mine does: it's in
Keith> version 1.13.

Argh, thanks.  I checked out the wrong module, so gdbtk didn't get
updated.  Sorry about that.

Tom

Re: build failure

[Keith Seitz]

On 10 May 2001, Tom Tromey wrote:

> I just updated and rebuilt gdb and got this:
>
> gcc -c -g -O2    -I. -I../../src/gdb -I../../src/gdb/config -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd  -I../../src/gdb/../include -I../intl -I../../src/gdb/../intl  -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized  -I../../src/gdb/../libgui/src  -I/x2/egcs-stuff/gdb/src/itcl/itcl/generic \
>         -I/x2/egcs-stuff/gdb/src/itcl/itk/generic -I/x2/egcs-stuff/gdb/src/tix/generic \
> -I/x2/egcs-stuff/gdb/src/tcl/generic -I/x2/egcs-stuff/gdb/src/tk/generic -I/x2/egcs-stuff/gdb/src/tk/generic -I/usr/X11R6/include \
> 	../../src/gdb/gdbtk/generic/gdbtk.c -DGDBTK_LIBRARY=\"/x2/egcs-stuff/gdb/install/share/gdbtcl\"
> ../../src/gdb/gdbtk/generic/gdbtk.c: In function `gdbtk_init':
> ../../src/gdb/gdbtk/generic/gdbtk.c:389: warning: implicit declaration of function `cli_out_new'
> ../../src/gdb/gdbtk/generic/gdbtk.c:389: warning: assignment makes pointer from integer without a cast

Shouldn't happen. I checked in a fix for that this morning. Does gdbtk.c
include cli-out.h? Mine does: it's in version 1.13.

Keith

Re: build failure

[Fernando Nasser]

Try cvs update again.  I just updated and it builds cleanly.

Fernando


Tom Tromey wrote:
> 
> I just updated and rebuilt gdb and got this:
> 
> gcc -c -g -O2    -I. -I../../src/gdb -I../../src/gdb/config -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd  -I../../src/gdb/../include -I../intl -I../../src/gdb/../intl  -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized  -I../../src/gdb/../libgui/src  -I/x2/egcs-stuff/gdb/src/itcl/itcl/generic \
>         -I/x2/egcs-stuff/gdb/src/itcl/itk/generic -I/x2/egcs-stuff/gdb/src/tix/generic \
> -I/x2/egcs-stuff/gdb/src/tcl/generic -I/x2/egcs-stuff/gdb/src/tk/generic -I/x2/egcs-stuff/gdb/src/tk/generic -I/usr/X11R6/include \
>         ../../src/gdb/gdbtk/generic/gdbtk.c -DGDBTK_LIBRARY=\"/x2/egcs-stuff/gdb/install/share/gdbtcl\"
> ../../src/gdb/gdbtk/generic/gdbtk.c: In function `gdbtk_init':
> ../../src/gdb/gdbtk/generic/gdbtk.c:389: warning: implicit declaration of function `cli_out_new'
> ../../src/gdb/gdbtk/generic/gdbtk.c:389: warning: assignment makes pointer from integer without a cast
> 
> Tom

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

build failure

[Tom Tromey]

I just updated and rebuilt gdb and got this:

gcc -c -g -O2    -I. -I../../src/gdb -I../../src/gdb/config -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd  -I../../src/gdb/../include -I../intl -I../../src/gdb/../intl  -DGDBTK -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized  -I../../src/gdb/../libgui/src  -I/x2/egcs-stuff/gdb/src/itcl/itcl/generic \
        -I/x2/egcs-stuff/gdb/src/itcl/itk/generic -I/x2/egcs-stuff/gdb/src/tix/generic \
-I/x2/egcs-stuff/gdb/src/tcl/generic -I/x2/egcs-stuff/gdb/src/tk/generic -I/x2/egcs-stuff/gdb/src/tk/generic -I/usr/X11R6/include \
	../../src/gdb/gdbtk/generic/gdbtk.c -DGDBTK_LIBRARY=\"/x2/egcs-stuff/gdb/install/share/gdbtcl\"
../../src/gdb/gdbtk/generic/gdbtk.c: In function `gdbtk_init':
../../src/gdb/gdbtk/generic/gdbtk.c:389: warning: implicit declaration of function `cli_out_new'
../../src/gdb/gdbtk/generic/gdbtk.c:389: warning: assignment makes pointer from integer without a cast

Tom