Feature request

Feature request

[Laurent Duperval]

Hi,

I have a line that looks like this:

 rc = Tcl_GlobalEval(htmlPtr->interp, Tcl_DStringValue(&cmd));

I'd like to put a breakpoint on Tcl_DStrinvValue by using the right mouse
button. It currently isn't possible. Does anyone else feel this would be
useful?

L

-- 
MY EMAIL ADDRESS HAS CHANGED --> UPDATE YOUR ADDRESSBOOK

Laurent Duperval                   "Montreal winters are an intelligence test,
Netergy Networks - Java Center            and we who are here have failed it."
Phone: (514) 282-8484 ext. 228                                   -Doug Camilli
mailto:laurent.duperval@netergynet.com           Penguin Power!

Re: Feature request

[Fernando Nasser]

Laurent Duperval wrote:
> 
> Hi,
> 
> I have a line that looks like this:
> 
>  rc = Tcl_GlobalEval(htmlPtr->interp, Tcl_DStringValue(&cmd));
> 
> I'd like to put a breakpoint on Tcl_DStrinvValue by using the right mouse
> button. It currently isn't possible. Does anyone else feel this would be
> useful?
> 

It is certainly useful.  I imagine it is not hard to implement either, but I can't
swear on that.

The bug database available from the Insight page at sources.redhat.com is also
supposed to be used to register enhancement suggestions.  Do you care to add
your suggestion in there so it does not get forgotten?

Thanks for the suggestion.

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: Feature request

[Tom Tromey]

>>>>> "Laurent" == Laurent Duperval <laurent.duperval@netergynet.com> writes:

Laurent>  rc = Tcl_GlobalEval(htmlPtr->interp, Tcl_DStringValue(&cmd));

Laurent> I'd like to put a breakpoint on Tcl_DStrinvValue by using the
Laurent> right mouse button. It currently isn't possible. Does anyone
Laurent> else feel this would be useful?

I think so.
Here is a trivial patch to implement it.

Is there a way to ask gdb whether a given piece of text is the name of
a function?  If so then it would be nice to make this menu item
conditional on the text actually naming a function.

I couldn't find a way to do that.  However if someone else knows
better, and tells me, I will update the patch.

If the powers that be like this patch I will check it in.


2000-11-21  Tom Tromey  <tromey@cygnus.com>

	* srctextwin.itb (SrcTextWin::do_source_popup): Added "Set
	Breakpoint" to popup menu.

Tom

Index: gdbtk/library/srctextwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
retrieving revision 1.11
diff -u -r1.11 srctextwin.itb
--- srctextwin.itb	2000/10/11 22:37:30	1.11
+++ srctextwin.itb	2000/11/21 23:10:14
@@ -1997,6 +1997,8 @@
 	  -command [list $this addToWatch $variable]
 	$popups(source) add command -label "Dump Memory at $variable" \
 	  -command [list ManagedWin::open MemWin -force -addr_exp $variable]
+	$popups(source) add command -label "Set Breakpoint at $variable" \
+	  -command [list gdb_cmd "break $variable"]
 	$popups(source) add separator
       }
     }

Re: Feature request

[Fernando Nasser]

Yes, there are ways to check if things are valid functions but imagine
if the symbol table is too large and the search takes a little longer,
it will add a funny delay on the menu creation.

I know it is not fancy letting the user make the distinction but the feature
is a useful one.

So please check it in.

Thanks for the patch.
Fernando


Tom Tromey wrote:
> 
> >>>>> "Laurent" == Laurent Duperval <laurent.duperval@netergynet.com> writes:
> 
> Laurent>  rc = Tcl_GlobalEval(htmlPtr->interp, Tcl_DStringValue(&cmd));
> 
> Laurent> I'd like to put a breakpoint on Tcl_DStrinvValue by using the
> Laurent> right mouse button. It currently isn't possible. Does anyone
> Laurent> else feel this would be useful?
> 
> I think so.
> Here is a trivial patch to implement it.
> 
> Is there a way to ask gdb whether a given piece of text is the name of
> a function?  If so then it would be nice to make this menu item
> conditional on the text actually naming a function.
> 
> I couldn't find a way to do that.  However if someone else knows
> better, and tells me, I will update the patch.
> 
> If the powers that be like this patch I will check it in.
> 
> 2000-11-21  Tom Tromey  <tromey@cygnus.com>
> 
>         * srctextwin.itb (SrcTextWin::do_source_popup): Added "Set
>         Breakpoint" to popup menu.
> 
> Tom
> 
> Index: gdbtk/library/srctextwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
> retrieving revision 1.11
> diff -u -r1.11 srctextwin.itb
> --- srctextwin.itb      2000/10/11 22:37:30     1.11
> +++ srctextwin.itb      2000/11/21 23:10:14
> @@ -1997,6 +1997,8 @@
>           -command [list $this addToWatch $variable]
>         $popups(source) add command -label "Dump Memory at $variable" \
>           -command [list ManagedWin::open MemWin -force -addr_exp $variable]
> +       $popups(source) add command -label "Set Breakpoint at $variable" \
> +         -command [list gdb_cmd "break $variable"]
>         $popups(source) add separator
>        }
>      }

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9