[RFA] Change Windows menu font.

[RFA] Change Windows menu font.

[Ian Roxborough]

Hi,

this little patch makes the fonts in the menus
consistant with the menu bars for MS-Windows.

Ian.


ChangeLog:
2002-02-25  Ian Roxborough  <irox@redhat.com>

        * src/library/looknfeel.tcl (standard_look_and_feel):
        Hard code Windows menu font name to MS Sans Serif 8.


Index: looknfeel.tcl
===================================================================
RCS file: /cvs/src/src/libgui/library/looknfeel.tcl,v
retrieving revision 1.3
diff -u -2 -r1.3 looknfeel.tcl
--- looknfeel.tcl       2001/10/11 03:29:54     1.3
+++ looknfeel.tcl       2002/02/25 20:15:09
@@ -33,5 +33,5 @@
     set actual(-slant) italic
     eval define_font global/italic [array get actual]
-    define_font global/menu -family windows-menu
+    define_font global/menu -family {MS Sans Serif} -size 8
   } else {
     set size 12

Re: [RFA] Change Windows menu font.

[Keith Seitz]

On Mon, 25 Feb 2002, Ian Roxborough wrote:

> this little patch makes the fonts in the menus
> consistant with the menu bars for MS-Windows.

Approved, but could you add a comment about how we used to use the defined
fonts "windows-menu" and friends, but the necessary machinery in the tk
core is no longer available (because apparently scriptics didn't care).

Keith

> ChangeLog:
> 2002-02-25  Ian Roxborough  <irox@redhat.com>
>
>         * src/library/looknfeel.tcl (standard_look_and_feel):
>         Hard code Windows menu font name to MS Sans Serif 8.
>
>
> Index: looknfeel.tcl
> ===================================================================
> RCS file: /cvs/src/src/libgui/library/looknfeel.tcl,v
> retrieving revision 1.3
> diff -u -2 -r1.3 looknfeel.tcl
> --- looknfeel.tcl       2001/10/11 03:29:54     1.3
> +++ looknfeel.tcl       2002/02/25 20:15:09
> @@ -33,5 +33,5 @@
>      set actual(-slant) italic
>      eval define_font global/italic [array get actual]
> -    define_font global/menu -family windows-menu
> +    define_font global/menu -family {MS Sans Serif} -size 8
>    } else {
>      set size 12
>

Re: [RFA] Change Windows menu font.

[Ian Roxborough]

Keith Seitz wrote:
> 
> On Mon, 25 Feb 2002, Ian Roxborough wrote:
> 
> > this little patch makes the fonts in the menus
> > consistant with the menu bars for MS-Windows.
> 
> Approved, but could you add a comment about how we used to use the defined
> fonts "windows-menu" and friends, but the necessary machinery in the tk
> core is no longer available (because apparently scriptics didn't care).

I've checked it in, here's the patch with additional comments,
for the archives.

Ian.

Index: library/looknfeel.tcl
===================================================================
RCS file: /cvs/src/src/libgui/library/looknfeel.tcl,v
retrieving revision 1.3
diff -u -2 -r1.3 looknfeel.tcl
--- looknfeel.tcl	2001/10/11 03:29:54	1.3
+++ looknfeel.tcl	2002/02/26 00:07:46
@@ -33,5 +33,9 @@
     set actual(-slant) italic
     eval define_font global/italic [array get actual]
-    define_font global/menu -family windows-menu
+
+    # The menu font used to be set via the "windows-menu"
+    # font family, however this seems to have been deprecated
+    # for Tcl/Tk version 8.3, so we hard code it instead.
+    define_font global/menu -family {MS Sans Serif} -size 8
   } else {
     set size 12

Re: [RFA] Change Windows menu font.

[Keith Seitz]

On Mon, 25 Feb 2002, Ian Roxborough wrote:

> +
> +    # The menu font used to be set via the "windows-menu"
> +    # font family, however this seems to have been deprecated
> +    # for Tcl/Tk version 8.3, so we hard code it instead.
> +    define_font global/menu -family {MS Sans Serif} -size 8

For the record, there were several fonts that Ian Lance Taylor added to
our copy of Tk8.0 which propagated the Window's Display Control Panel
settings for fonts. These were called "windows-menu", "windows-status",
and a few others.

If you run Insight 5.1 and use the Display Control Panel to alter the menu
font for your desktop, Insight will change. CVS, however, will not, since
scriptics did not do anything with Ian's patches. As a result, using the
Display Control Panel to alter fonts will do nothing.

I wish scriptics hadn't dropped the ball on this, since it really makes a
huge difference for the user...

Keith

Re: [RFA] Change Windows menu font.

[Ian Roxborough]

Keith Seitz wrote:
> 
> On Mon, 25 Feb 2002, Ian Roxborough wrote:
> 
> > +
> > +    # The menu font used to be set via the "windows-menu"
> > +    # font family, however this seems to have been deprecated
> > +    # for Tcl/Tk version 8.3, so we hard code it instead.
> > +    define_font global/menu -family {MS Sans Serif} -size 8
> 
> For the record, there were several fonts that Ian Lance Taylor added to
> our copy of Tk8.0 which propagated the Window's Display Control Panel
> settings for fonts. These were called "windows-menu", "windows-status",
> and a few others.

I really like this feature and in the interests of Windows look'n'feel
I think we should add Ian Lance Taylor's patch to Tk8.3 (and resubmit
the patch the current Tk maintainers).  I'll take a look at it
as somepoint (unless somebody else does it first).

Ian.

Re: [RFA] Change Windows menu font.

[Keith Seitz]

On Mon, 25 Feb 2002, Ian Roxborough wrote:

> I really like this feature and in the interests of Windows look'n'feel
> I think we should add Ian Lance Taylor's patch to Tk8.3 (and resubmit
> the patch the current Tk maintainers).  I'll take a look at it
> as somepoint (unless somebody else does it first).

Yes, I like it, too. I looked at it a little while ago (when I figured all
this out), and Ian's patch could be adapted. The problem will be the Tk
community. They ignored it once, and, well, I fear they'll do the same
again.

I guess all we can do is submit the patch and offer to help knock it into
shape for acceptance.

Keith

Re: [RFA] Change Windows menu font.

[Syd Polk]

On Monday, February 25, 2002, at 04:37 , Keith Seitz wrote:

> On Mon, 25 Feb 2002, Ian Roxborough wrote:
>
>> +
>> +    # The menu font used to be set via the "windows-menu"
>> +    # font family, however this seems to have been deprecated
>> +    # for Tcl/Tk version 8.3, so we hard code it instead.
>> +    define_font global/menu -family {MS Sans Serif} -size 8
>
> For the record, there were several fonts that Ian Lance Taylor added to
> our copy of Tk8.0 which propagated the Window's Display Control Panel
> settings for fonts. These were called "windows-menu", "windows-status",
> and a few others.
>
> If you run Insight 5.1 and use the Display Control Panel to alter the 
> menu
> font for your desktop, Insight will change. CVS, however, will not, 
> since
> scriptics did not do anything with Ian's patches. As a result, using the
> Display Control Panel to alter fonts will do nothing.
>
> I wish scriptics hadn't dropped the ball on this, since it really 
> makes a
> huge difference for the user...

I was the developer of Windows Font Menu stuff and one of the people in 
the Font system itself. We had plans for this while Tcl/Tk was at Sun. I 
left to go to Cygnus, and nobody else picked up the ball and ran with 
it. Then Scriptics spun off and spent most of their time doing something 
other than Tk. Then Scriptics was bought by Interwoven, and, well....

>
> Keith
>
>
Syd Polk
jazzman@bayarea.net                 http://www.bayarea.net/~jazzman
"Let the music be your light." -- Dave Edwards, KUHF-FM, 1982

Re: [RFA] Change Windows menu font.

[Ian Roxborough]

Keith Seitz wrote:
> 
> On Mon, 25 Feb 2002, Ian Roxborough wrote:
> 
> > I really like this feature and in the interests of Windows look'n'feel
> > I think we should add Ian Lance Taylor's patch to Tk8.3 (and resubmit
> > the patch the current Tk maintainers).  I'll take a look at it
> > as somepoint (unless somebody else does it first).
> 
> Yes, I like it, too. I looked at it a little while ago (when I figured all
> this out), and Ian's patch could be adapted. The problem will be the Tk
> community. They ignored it once, and, well, I fear they'll do the same
> again.

They've done it with Windows look'n'feel patches I've submitted
in the past as well. (Although they where kind enough to put the
patch on there web site.)

> I guess all we can do is submit the patch and offer to help knock it into
> shape for acceptance.

Maybe this will be easier the next time.  When I was
researching the problem I came across a page on:

 "Improvements to Windows Font Handling" w.r.t. Tk8.4.
 http://tcl.activestate.com/cgi-bin/tct/tip/64.html

Things kind of look promising for the future, but I
feel they have not paid much attention to Windows look'n'feel
since MS-Window 3.1.

Ian.