From: Hui Zhu <teawater@gmail.com>
To: Keith Seitz <keiths@redhat.com>
Cc: insight <insight@sourceware.org>
Subject: Re: [BUG] build trunk error
Date: Sat, 14 May 2011 03:42:00 -0000 [thread overview]
Message-ID: <BANLkTi=eLRngtWP-xMbLzxVrOWbH5XLKyQ@mail.gmail.com> (raw)
In-Reply-To: <4DCC7D3A.5060206@redhat.com>
Thanks Keith. My part is OK.
Best,
Hui
On Fri, May 13, 2011 at 08:37, Keith Seitz <keiths@redhat.com> wrote:
> On 05/08/2011 09:05 PM, Hui Zhu wrote:
>>
>> ../../src/gdb/gdbtk/generic/gdbtk-hooks.c: In function 'gdbtk_add_hooks':
>> ../../src/gdb/gdbtk/generic/gdbtk-hooks.c:126: error: passing argument
>> 1 of 'observer_attach_breakpoint_created' from incompatible pointer
>> type
>
> [snip]
>
> I've committed the attached patch to address this. IMO this patch should
> have been necessary years ago! [Better late than never, gdb! :-)]
>
> Thank you for notifying me.
>
> Keith
>
> ChangeLog
> 2011-05-12 Keith Seitz <keiths@redhat.com>
>
> * generic/gdbtk-hooks.c (gdbtk_create_breakpoint): Change
> parameter from `int' to `struct breakpoint *'.
> (gdbtk_delete_breakpoint): Likewise.
> (gdbtk_modify_breakpoint): Likewise.
> * generic/gdbtk-bp.c (ALL_BREAKPOINTS): Define.
> (breakpoint_list): Remove.
> (breakpoint_list_size): Remove.
> (Gdbtk_Breakpoint_Init): Remove initialization of breakpoint_list.
> (gdb_find_bp_at_addr): Rewrite using ALL_BREAKPOINTS.
> (gdb_find_bp_at_line): Likewise.
> (gdb_get_breakpoint_info): Likewise.
> (gdb_get_breakpoint_list): Likewise.
> (gdbtk_create_breakpoint): Change parameter from `int' to
> `struct breakpoint *' and update function.
> (gdbtk_delete_breakpoint): Likewise.
> (gdbtk_modify_breakpoint): Likewise.
> (breakpoint_notify): Rewrite using ALL_BREAKPOINTS.
>
prev parent reply other threads:[~2011-05-14 3:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 4:06 Hui Zhu
2011-05-13 0:37 ` Keith Seitz
2011-05-14 3:42 ` Hui Zhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=eLRngtWP-xMbLzxVrOWbH5XLKyQ@mail.gmail.com' \
--to=teawater@gmail.com \
--cc=insight@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).