public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* [RFA] patch to gdbtk-register.c
@ 2001-07-20 14:39 Martin M. Hunt
  2001-07-20 14:55 ` Keith Seitz
  0 siblings, 1 reply; 2+ messages in thread
From: Martin M. Hunt @ 2001-07-20 14:39 UTC (permalink / raw)
  To: insight

2001-07-20  Martin M. Hunt  <hunt@redhat.com>

	* generic/gdbtk-register.c (gdb_regnames): Fix 'if'
	statement so count is decremented only if "-numbers"
	is the first arg.

Index: generic/gdbtk-register.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v
retrieving revision 1.1
diff -u -p -r1.1 gdbtk-register.c
--- gdbtk-register.c	2001/05/10 18:04:23	1.1
+++ gdbtk-register.c	2001/07/20 21:37:46
@@ -158,9 +158,11 @@ gdb_regnames (clientData, interp, objc, 
     {
       char *s = Tcl_GetStringFromObj (objv[0], NULL);
       if (STREQ (s, "-numbers"))
-	numbers = 1;
-      objc--;
-      objv++;
+	{
+	  numbers = 1;
+	  objc--;
+	  objv++;
+	}
     }
 
   return map_arg_registers (objc, objv, get_register_name, &numbers);
\x11

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFA] patch to gdbtk-register.c
  2001-07-20 14:39 [RFA] patch to gdbtk-register.c Martin M. Hunt
@ 2001-07-20 14:55 ` Keith Seitz
  0 siblings, 0 replies; 2+ messages in thread
From: Keith Seitz @ 2001-07-20 14:55 UTC (permalink / raw)
  To: Martin M. Hunt; +Cc: insight

On Fri, 20 Jul 2001, Martin M. Hunt wrote:

> 2001-07-20  Martin M. Hunt  <hunt@redhat.com>
>
> 	* generic/gdbtk-register.c (gdb_regnames): Fix 'if'
> 	statement so count is decremented only if "-numbers"
> 	is the first arg.

I must be losing my mind. Didn't I just check this in? (Or did I massively
massage gdbtk-register.c?)

Anyway, I know about this bug, and have fixed done this in my sandbox,
too, so please check it in.

I have a relatively large massaging of gdbtk-register.c in my sandbox, and
I will make sure that this is in there.

Keith


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-07-20 14:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-07-20 14:39 [RFA] patch to gdbtk-register.c Martin M. Hunt
2001-07-20 14:55 ` Keith Seitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).