public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@cygnus.com>
To: Ian Roxborough <irox@redhat.com>
Cc: <insight@sources.redhat.com>
Subject: Re: [PATCH] Set path to iwidgets...
Date: Mon, 10 Sep 2001 08:15:00 -0000	[thread overview]
Message-ID: <Pine.GSO.4.33.0109100812090.1665-100000@makita.cygnus.com> (raw)
In-Reply-To: <3B9BC001.9B1B9DD@redhat.com>

On Sun, 9 Sep 2001, Ian Roxborough wrote:

(I presume you mean for that to read '[RFA] Set path to iwidgets...', or
you've already committed this change...)

> this patch sets the IWIDGETS_LIBRARY environment variable
> if Insight is ran from the build directory.
>
> Once the Tcl/Tk upgrade is complete Insight won't run out
> of the build directory without this patch. It'll give an
> error saying the IWidgets cannot be found.

Hmmmm. Why should this be necessary? We already have something in main.tcl
to search for this directory.

Given the complexities of that procedure, and how simple this patch is, I
would ask that you review "find_iwidgets_library" and whack it if at all
possible. I think this proc exists solely for this purpose, too.

Heaven knows that will be one less complication/headache in the code...

Keith



      reply	other threads:[~2001-09-10  8:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-09 12:16 Ian Roxborough
2001-09-10  8:15 ` Keith Seitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.33.0109100812090.1665-100000@makita.cygnus.com \
    --to=keiths@cygnus.com \
    --cc=insight@sources.redhat.com \
    --cc=irox@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).