public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Set path to iwidgets...
@ 2001-09-09 12:16 Ian Roxborough
  2001-09-10  8:15 ` Keith Seitz
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Roxborough @ 2001-09-09 12:16 UTC (permalink / raw)
  To: insight

Hi,

this patch sets the IWIDGETS_LIBRARY environment variable
if Insight is ran from the build directory.

Once the Tcl/Tk upgrade is complete Insight won't run out
of the build directory without this patch. It'll give an
error saying the IWidgets cannot be found.

  Ian.
--

ChangeLog:
2001-09-09  Ian Roxborough <irox@redhat.com>
 
 	* generic/gdbtk.c (gdbtk_init): Set IWIDGETS_LIBRARY if
 	Insight is launched from within the build directory.
 


Index: generic/gdbtk.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.c,v
retrieving revision 1.20
diff -p -r1.20 gdbtk.c
*** gdbtk.c	2001/08/21 19:29:00	1.20
--- gdbtk.c	2001/09/09 19:09:30
*************** gdbtk_init (argv0)
*** 423,428 ****
--- 423,432 ----
  	      set env(ITK_LIBRARY) [file join $srcDir itcl itk library]\n\
  	  }\n\
  \
+ 	  if {![info exists env(IWIDGETS_LIBRARY)]} {\n\
+ 	      set env(IWIDGETS_LIBRARY) [file join $srcDir itcl iwidgets3.0.0]\n\
+ 	  }\n\
+ \
  	  if {![info exists env(TIX_LIBRARY)]} {\n\
  	      set env(TIX_LIBRARY) [file join $srcDir tix library]\n\
  	  }\n\

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Set path to iwidgets...
  2001-09-09 12:16 [PATCH] Set path to iwidgets Ian Roxborough
@ 2001-09-10  8:15 ` Keith Seitz
  0 siblings, 0 replies; 2+ messages in thread
From: Keith Seitz @ 2001-09-10  8:15 UTC (permalink / raw)
  To: Ian Roxborough; +Cc: insight

On Sun, 9 Sep 2001, Ian Roxborough wrote:

(I presume you mean for that to read '[RFA] Set path to iwidgets...', or
you've already committed this change...)

> this patch sets the IWIDGETS_LIBRARY environment variable
> if Insight is ran from the build directory.
>
> Once the Tcl/Tk upgrade is complete Insight won't run out
> of the build directory without this patch. It'll give an
> error saying the IWidgets cannot be found.

Hmmmm. Why should this be necessary? We already have something in main.tcl
to search for this directory.

Given the complexities of that procedure, and how simple this patch is, I
would ask that you review "find_iwidgets_library" and whack it if at all
possible. I think this proc exists solely for this purpose, too.

Heaven knows that will be one less complication/headache in the code...

Keith



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-09-10  8:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-09-09 12:16 [PATCH] Set path to iwidgets Ian Roxborough
2001-09-10  8:15 ` Keith Seitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).