public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* [rfa/patch] string <-> core_addr conversions
@ 2001-10-16 19:57 Andrew Cagney
  2001-10-17 11:22 ` Keith Seitz
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cagney @ 2001-10-16 19:57 UTC (permalink / raw)
  To: insight; +Cc: gdb-patches

Hello,

The attached patch changes the way Insight converts from a tcl string to 
a CORE_ADDR.  Without the patch Insight would use 
parse_and_eval_address() when converting an address (in ascii) into a 
CORE_ADDR.  Unfortunatly, that function, on harvard architectures, does 
strange and wonderful things.

You can see the problems if you try to use the memory window to modify 
locations.

This code adds a very simple (?) function for converting the tcl integer 
directly into a core_addr.  It also adds a function to convert a 
core_addr to a string (not yet used), I suspect Insight needs an audit 
and should ensure that these functions are always used.

Comments? Ok (tcl)?  The utils.c change is pretty straightforward.

Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [rfa/patch] string <-> core_addr conversions
  2001-10-16 19:57 [rfa/patch] string <-> core_addr conversions Andrew Cagney
@ 2001-10-17 11:22 ` Keith Seitz
  0 siblings, 0 replies; 2+ messages in thread
From: Keith Seitz @ 2001-10-17 11:22 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: Insight Maling List

On Tue, 16 Oct 2001, Andrew Cagney wrote:

> Comments? Ok (tcl)?  The utils.c change is pretty straightforward.

I think this code is long overdue, and I will be very happy to see it
checked in. Everything looks just fine.

Thanks!
Keith



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-10-17 11:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-16 19:57 [rfa/patch] string <-> core_addr conversions Andrew Cagney
2001-10-17 11:22 ` Keith Seitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).