* [RFA] reconfig fixes
@ 2001-11-02 15:37 Martin M. Hunt
2001-11-03 11:25 ` Keith Seitz
0 siblings, 1 reply; 2+ messages in thread
From: Martin M. Hunt @ 2001-11-02 15:37 UTC (permalink / raw)
To: Insight Mailing List
When preferences change, such as fonts, the debugger windows should show this
change. Currently that does not always happen, or worse, the window
reconfigures itself incorrectly and is blank. This happens with several
windows, mostly when running on Windows. The following patch fixes this.
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
2001-11-01 Martin M. Hunt <hunt@redhat.com>
* library/stackwin.itb (StcakWin::reconfig): Destroy sbox
if it exists.
* library/process.itb (ProcessWin::reconfig): Destroy sbox
if it exists. This fixes reconfig failures on Windows. Also
destroy slbox.
* library/bpwin.itb (BpWin::reconfig): Destroy sbox if
it exists.This fixes reconfig failures on Windows. Also
destroy sf
* library/tdump.tcl (TdumpWin::reconfig): Delete sbox
and stext then rebuild window.
Index: library/process.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/process.itb,v
retrieving revision 1.6
diff -u -p -r1.6 process.itb
--- process.itb 2001/08/29 00:23:30 1.6
+++ process.itb 2001/11/02 23:35:15
@@ -139,6 +139,8 @@ body ProcessWin::destructor {} {
# ------------------------------------------------------------------
body ProcessWin::reconfig {} {
destroy $itk_interior.s
+ if {[winfo exists $itk_interior.sbox]} { destroy $itk_interior.sbox }
+ if {[winfo exists $itk_interior.slbox]} { destroy $itk_interior.slbox }
build_win
}
Index: library/stackwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/stackwin.itb,v
retrieving revision 1.5
diff -u -p -r1.5 stackwin.itb
--- stackwin.itb 2001/08/20 19:14:09 1.5
+++ stackwin.itb 2001/11/02 23:35:15
@@ -134,6 +134,7 @@ body StackWin::change_frame {} {
# ------------------------------------------------------------------
body StackWin::reconfig {} {
destroy $itk_interior.s
+ if {[winfo exists $itk_interior.sbox]} { destroy $itk_interior.sbox }
build_win
}
Index: library/bpwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/bpwin.itb,v
retrieving revision 1.8
diff -u -p -r1.8 bpwin.itb
--- bpwin.itb 2001/08/29 00:23:30 1.8
+++ bpwin.itb 2001/11/02 23:35:15
@@ -698,6 +698,8 @@ body BpWin::toggle_threads {} {
body BpWin::reconfig {} {
if {[winfo exists $itk_interior.f]} { destroy $itk_interior.f }
if {[winfo exists $itk_interior.m]} { destroy $itk_interior.m }
+ if {[winfo exists $itk_interior.sbox]} { destroy $itk_interior.sbox }
+ if {[winfo exists $itk_interior.sf]} { destroy $itk_interior.sf }
if {[winfo exists $itk_interior.pop]} { destroy $itk_interior.pop }
build_win
}
Index: library/tdump.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/tdump.tcl,v
retrieving revision 1.3
diff -u -p -r1.3 tdump.tcl
--- tdump.tcl 2001/08/28 23:38:01 1.3
+++ tdump.tcl 2001/11/02 23:35:15
@@ -96,6 +96,9 @@ class TdumpWin {
# METHOD: reconfig - used when preferences change
# ------------------------------------------------------------------
method reconfig {} {
+ if {[winfo exists $itk_interior.sbox]} { destroy $itk_interior.sbox }
+ if {[winfo exists $itk_interior.stext]} { destroy $itk_interior.stext }
+ build_win
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA] reconfig fixes
2001-11-02 15:37 [RFA] reconfig fixes Martin M. Hunt
@ 2001-11-03 11:25 ` Keith Seitz
0 siblings, 0 replies; 2+ messages in thread
From: Keith Seitz @ 2001-11-03 11:25 UTC (permalink / raw)
To: Martin M. Hunt; +Cc: Insight Mailing List
On Fri, 2 Nov 2001, Martin M. Hunt wrote:
> When preferences change, such as fonts, the debugger windows should show this
> change. Currently that does not always happen, or worse, the window
> reconfigures itself incorrectly and is blank. This happens with several
> windows, mostly when running on Windows. The following patch fixes this.
I'll be honest... I don't even want to look at these. Preferences are so
badly managed, it makes me ill.
Just check them in. (I'll assume you've tested on Windows and Unix.)
Keith
> 2001-11-01 Martin M. Hunt <hunt@redhat.com>
>
> * library/stackwin.itb (StcakWin::reconfig): Destroy sbox
> if it exists.
>
> * library/process.itb (ProcessWin::reconfig): Destroy sbox
> if it exists. This fixes reconfig failures on Windows. Also
> destroy slbox.
>
> * library/bpwin.itb (BpWin::reconfig): Destroy sbox if
> it exists.This fixes reconfig failures on Windows. Also
> destroy sf
>
> * library/tdump.tcl (TdumpWin::reconfig): Delete sbox
> and stext then rebuild window.
>
> Index: library/process.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/process.itb,v
> retrieving revision 1.6
> diff -u -p -r1.6 process.itb
> --- process.itb 2001/08/29 00:23:30 1.6
> +++ process.itb 2001/11/02 23:35:15
> @@ -139,6 +139,8 @@ body ProcessWin::destructor {} {
> # ------------------------------------------------------------------
> body ProcessWin::reconfig {} {
> destroy $itk_interior.s
> + if {[winfo exists $itk_interior.sbox]} { destroy $itk_interior.sbox }
> + if {[winfo exists $itk_interior.slbox]} { destroy $itk_interior.slbox }
> build_win
> }
>
> Index: library/stackwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/stackwin.itb,v
> retrieving revision 1.5
> diff -u -p -r1.5 stackwin.itb
> --- stackwin.itb 2001/08/20 19:14:09 1.5
> +++ stackwin.itb 2001/11/02 23:35:15
> @@ -134,6 +134,7 @@ body StackWin::change_frame {} {
> # ------------------------------------------------------------------
> body StackWin::reconfig {} {
> destroy $itk_interior.s
> + if {[winfo exists $itk_interior.sbox]} { destroy $itk_interior.sbox }
> build_win
> }
>
> Index: library/bpwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/bpwin.itb,v
> retrieving revision 1.8
> diff -u -p -r1.8 bpwin.itb
> --- bpwin.itb 2001/08/29 00:23:30 1.8
> +++ bpwin.itb 2001/11/02 23:35:15
> @@ -698,6 +698,8 @@ body BpWin::toggle_threads {} {
> body BpWin::reconfig {} {
> if {[winfo exists $itk_interior.f]} { destroy $itk_interior.f }
> if {[winfo exists $itk_interior.m]} { destroy $itk_interior.m }
> + if {[winfo exists $itk_interior.sbox]} { destroy $itk_interior.sbox }
> + if {[winfo exists $itk_interior.sf]} { destroy $itk_interior.sf }
> if {[winfo exists $itk_interior.pop]} { destroy $itk_interior.pop }
> build_win
> }
> Index: library/tdump.tcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/tdump.tcl,v
> retrieving revision 1.3
> diff -u -p -r1.3 tdump.tcl
> --- tdump.tcl 2001/08/28 23:38:01 1.3
> +++ tdump.tcl 2001/11/02 23:35:15
> @@ -96,6 +96,9 @@ class TdumpWin {
> # METHOD: reconfig - used when preferences change
> # ------------------------------------------------------------------
> method reconfig {} {
> + if {[winfo exists $itk_interior.sbox]} { destroy $itk_interior.sbox }
> + if {[winfo exists $itk_interior.stext]} { destroy $itk_interior.stext }
> + build_win
> }
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-11-03 11:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-11-02 15:37 [RFA] reconfig fixes Martin M. Hunt
2001-11-03 11:25 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).