feature suggestion

feature suggestion

[Tom Tromey]

I typically use the console window.
It would be helpful to me if the (mouse) cursor changed to a watch
over the console window when the inferior is executing.
I find the current situation constantly confusing, and I never
remember to look at the state of the buttons on the source window to
see what is going on.

Tom

Re: feature suggestion

[Keith Seitz]

On 3 Dec 2001, Tom Tromey wrote:

> It would be helpful to me if the (mouse) cursor changed to a watch
> over the console window when the inferior is executing.

Try this patch. If it works, I'll check something in.

Keith

Index: library/console.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/console.itb,v
retrieving revision 1.14
diff -u -p -r1.14 console.itb
--- library/console.itb	2001/10/17 20:30:29	1.14
+++ library/console.itb	2001/12/04 19:36:22
@@ -205,6 +205,7 @@ body Console::_build_win {} {

 body Console::idle {event} {
   set _running 0
+  $_top configure -cursor {}
 }

 # ------------------------------------------------------------------
@@ -212,6 +213,7 @@ body Console::idle {event} {
 # ------------------------------------------------------------------
 body Console::busy {event} {
   set _running 1
+  $_top configure -cursor watch
 }

 # ------------------------------------------------------------------

Re: feature suggestion

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:

>> It would be helpful to me if the (mouse) cursor changed to a watch
>> over the console window when the inferior is executing.

Keith> Try this patch. If it works, I'll check something in.

It works fine.
Thanks!

Tom

Re: feature suggestion

[Keith Seitz]

On 4 Dec 2001, Tom Tromey wrote:

> Keith> Try this patch. If it works, I'll check something in.
>
> It works fine.

Ok, checked in.

Keith

Re: feature suggestion

[Keith Seitz]

On 4 Dec 2001, Tom Tromey wrote:

> Keith> Try this patch. If it works, I'll check something in.
>
> It works fine.

Ok, checked in.

Keith

Re: feature suggestion

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@cygnus.com> writes:

>> It would be helpful to me if the (mouse) cursor changed to a watch
>> over the console window when the inferior is executing.

Keith> Try this patch. If it works, I'll check something in.

It works fine.
Thanks!

Tom

Re: feature suggestion

[Keith Seitz]

On 3 Dec 2001, Tom Tromey wrote:

> It would be helpful to me if the (mouse) cursor changed to a watch
> over the console window when the inferior is executing.

Try this patch. If it works, I'll check something in.

Keith

Index: library/console.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/console.itb,v
retrieving revision 1.14
diff -u -p -r1.14 console.itb
--- library/console.itb	2001/10/17 20:30:29	1.14
+++ library/console.itb	2001/12/04 19:36:22
@@ -205,6 +205,7 @@ body Console::_build_win {} {

 body Console::idle {event} {
   set _running 0
+  $_top configure -cursor {}
 }

 # ------------------------------------------------------------------
@@ -212,6 +213,7 @@ body Console::idle {event} {
 # ------------------------------------------------------------------
 body Console::busy {event} {
   set _running 1
+  $_top configure -cursor watch
 }

 # ------------------------------------------------------------------

feature suggestion

[Tom Tromey]

I typically use the console window.
It would be helpful to me if the (mouse) cursor changed to a watch
over the console window when the inferior is executing.
I find the current situation constantly confusing, and I never
remember to look at the state of the buttons on the source window to
see what is going on.

Tom

feature suggestion

[Tom Tromey]

I think that B3 on the breakpoint window should automatically select
the breakpoint under the mouse.  I keep trying to use the right button
to bring up the menu, but first I have to select the item I'm
interested in.  This has happened 4-5 times already ... changing this
would be convenient.

Tom

Re: feature suggestion

[Keith Seitz]

On 20 Dec 2001, Tom Tromey wrote:

> I think that B3 on the breakpoint window should automatically select
> the breakpoint under the mouse.  I keep trying to use the right button
> to bring up the menu, but first I have to select the item I'm
> interested in.  This has happened 4-5 times already ... changing this
> would be convenient.

Your wish is my command...

Try this and let me know if you find any problems with it.

Keith

Index: gdbtk/library/bpwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/bpwin.itb,v
retrieving revision 1.9
diff -u -p -r1.9 bpwin.itb
--- gdbtk/library/bpwin.itb	2001/11/05 19:15:17	1.9
+++ gdbtk/library/bpwin.itb	2001/12/21 06:16:52
@@ -265,6 +265,7 @@ body BpWin::bp_add {bp_event {tracepoint
     foreach thing $zz {
       bind $twin.${thing}${i} <1> "$this bp_select $i"
       bind $twin.${thing}${i} <Double-1> "$this goto_bp $i"
+      bind $twin.${thing}${i} <3> [code $this _select_and_popup $i %X %Y]
     }
   }

@@ -368,7 +369,6 @@ body BpWin::bp_select { r } {

     foreach thing $zz {
       $twin.${thing}${i}  configure -fg [pref get gdb/font/select_fg] -bg $bg1
-      bind $twin.${thing}${i} <3> break
     }
   }

@@ -386,17 +386,12 @@ body BpWin::bp_select { r } {
     $itk_interior.m.bp entryconfigure "Disabled" -state disabled
     $itk_interior.m.bp entryconfigure "Remove" -state disabled

-    foreach thing $zz {
-      bind $twin.${thing}${r} <3> break
-    }
-
     return
   }

   foreach thing $zz {
     $twin.${thing}${r} configure -fg [pref get gdb/font/select_fg] \
       -bg [pref get gdb/font/select_bg]
-    bind $twin.${thing}${r}  <3> "tk_popup $Menu %X %Y"
   }

   if {$tracepoints == 0} {
@@ -424,6 +419,21 @@ body BpWin::bp_select { r } {
   $Menu entryconfigure "Remove" -command "$this bp_remove $r" -state normal

   set selected $r
+}
+
+# ------------------------------------------------------------------
+#  NAME:         private method BpWin::_select_and_popup
+#  DESCRIPTION:  Select the given breakpoint and popup the options
+#                menu at the given location.
+#
+#  ARGUMENTS:    None
+#  RETURNS:      Nothing
+# ------------------------------------------------------------------
+body BpWin::_select_and_popup {bp X Y} {
+  if {$selected != $bp} {
+    bp_select $bp
+  }
+  tk_popup $Menu $X $Y
 }

 # ------------------------------------------------------------------
Index: gdbtk/library/bpwin.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/bpwin.ith,v
retrieving revision 1.2
diff -u -p -r1.2 bpwin.ith
--- gdbtk/library/bpwin.ith	2001/04/19 22:51:02	1.2
+++ gdbtk/library/bpwin.ith	2001/12/21 06:16:52
@@ -53,6 +53,7 @@ class BpWin {
     method bp_add {bp_event {tracepoint 0}}
     method bp_modify {bp_event {tracepoint 0}}
     method bp_delete {bp_event}
+    method _select_and_popup {bp X Y}
   }

 }

Re: feature suggestion

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

>> I think that B3 on the breakpoint window should automatically select
>> the breakpoint under the mouse.  I keep trying to use the right button
>> to bring up the menu, but first I have to select the item I'm
>> interested in.  This has happened 4-5 times already ... changing this
>> would be convenient.

Keith> Your wish is my command...
Keith> Try this and let me know if you find any problems with it.

Wow, that was quick.
I tried it and it works great for me.
Thanks.

Tom

Re: feature suggestion

[Keith Seitz]

On 21 Dec 2001, Tom Tromey wrote:

> Wow, that was quick.
> I tried it and it works great for me.
> Thanks.

Cool!

Committed.

Keith

Re: feature suggestion

[Keith Seitz]

On 21 Dec 2001, Tom Tromey wrote:

> Wow, that was quick.
> I tried it and it works great for me.
> Thanks.

Cool!

Committed.

Keith

Re: feature suggestion

[Tom Tromey]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

>> I think that B3 on the breakpoint window should automatically select
>> the breakpoint under the mouse.  I keep trying to use the right button
>> to bring up the menu, but first I have to select the item I'm
>> interested in.  This has happened 4-5 times already ... changing this
>> would be convenient.

Keith> Your wish is my command...
Keith> Try this and let me know if you find any problems with it.

Wow, that was quick.
I tried it and it works great for me.
Thanks.

Tom

Re: feature suggestion

[Keith Seitz]

On 20 Dec 2001, Tom Tromey wrote:

> I think that B3 on the breakpoint window should automatically select
> the breakpoint under the mouse.  I keep trying to use the right button
> to bring up the menu, but first I have to select the item I'm
> interested in.  This has happened 4-5 times already ... changing this
> would be convenient.

Your wish is my command...

Try this and let me know if you find any problems with it.

Keith

Index: gdbtk/library/bpwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/bpwin.itb,v
retrieving revision 1.9
diff -u -p -r1.9 bpwin.itb
--- gdbtk/library/bpwin.itb	2001/11/05 19:15:17	1.9
+++ gdbtk/library/bpwin.itb	2001/12/21 06:16:52
@@ -265,6 +265,7 @@ body BpWin::bp_add {bp_event {tracepoint
     foreach thing $zz {
       bind $twin.${thing}${i} <1> "$this bp_select $i"
       bind $twin.${thing}${i} <Double-1> "$this goto_bp $i"
+      bind $twin.${thing}${i} <3> [code $this _select_and_popup $i %X %Y]
     }
   }

@@ -368,7 +369,6 @@ body BpWin::bp_select { r } {

     foreach thing $zz {
       $twin.${thing}${i}  configure -fg [pref get gdb/font/select_fg] -bg $bg1
-      bind $twin.${thing}${i} <3> break
     }
   }

@@ -386,17 +386,12 @@ body BpWin::bp_select { r } {
     $itk_interior.m.bp entryconfigure "Disabled" -state disabled
     $itk_interior.m.bp entryconfigure "Remove" -state disabled

-    foreach thing $zz {
-      bind $twin.${thing}${r} <3> break
-    }
-
     return
   }

   foreach thing $zz {
     $twin.${thing}${r} configure -fg [pref get gdb/font/select_fg] \
       -bg [pref get gdb/font/select_bg]
-    bind $twin.${thing}${r}  <3> "tk_popup $Menu %X %Y"
   }

   if {$tracepoints == 0} {
@@ -424,6 +419,21 @@ body BpWin::bp_select { r } {
   $Menu entryconfigure "Remove" -command "$this bp_remove $r" -state normal

   set selected $r
+}
+
+# ------------------------------------------------------------------
+#  NAME:         private method BpWin::_select_and_popup
+#  DESCRIPTION:  Select the given breakpoint and popup the options
+#                menu at the given location.
+#
+#  ARGUMENTS:    None
+#  RETURNS:      Nothing
+# ------------------------------------------------------------------
+body BpWin::_select_and_popup {bp X Y} {
+  if {$selected != $bp} {
+    bp_select $bp
+  }
+  tk_popup $Menu $X $Y
 }

 # ------------------------------------------------------------------
Index: gdbtk/library/bpwin.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/bpwin.ith,v
retrieving revision 1.2
diff -u -p -r1.2 bpwin.ith
--- gdbtk/library/bpwin.ith	2001/04/19 22:51:02	1.2
+++ gdbtk/library/bpwin.ith	2001/12/21 06:16:52
@@ -53,6 +53,7 @@ class BpWin {
     method bp_add {bp_event {tracepoint 0}}
     method bp_modify {bp_event {tracepoint 0}}
     method bp_delete {bp_event}
+    method _select_and_popup {bp X Y}
   }

 }

feature suggestion

[Tom Tromey]

I think that B3 on the breakpoint window should automatically select
the breakpoint under the mouse.  I keep trying to use the right button
to bring up the menu, but first I have to select the item I'm
interested in.  This has happened 4-5 times already ... changing this
would be convenient.

Tom