public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* [Patch] remove iwidgets symlink when installing
@ 2002-08-06  1:53 Mo DeJong
  2002-08-06 12:25 ` Keith Seitz
  0 siblings, 1 reply; 2+ messages in thread
From: Mo DeJong @ 2002-08-06  1:53 UTC (permalink / raw)
  To: Insight

For some reason, the iwidgets package creates a .../lib/iwidgets symlink
when installing. I am at a loss to explain why this symlink is in there,
but it seems to be pointless since Insight works just fine without it.
This patch removes the symlink and will make it easier to build
a Source-Navigator RPM. Source-Navigator does not actually
use iwidgets, but they get installed as part of the build.

cheers
Mo

2002-08-05  Mo Dejong  <supermo@bayarea.net>

	* iwidgets3.0.0/Makefile.in: Don't create a
	$exec_prefix/lib/iwidgets symlink to
	$exec_prefix/share/iwidgets3.0.1. This symlink
	is not needed and causes problems when builing
	a relocatable RPM since the symlink uses a
	fully qualified path name. Remove LN_S and
	LIB_INSTALL_DIR variables also.

Index: iwidgets3.0.0/Makefile.in
===================================================================
RCS file: /cvs/src/src/itcl/iwidgets3.0.0/Makefile.in,v
retrieving revision 1.2
diff -u -r1.2 Makefile.in
--- iwidgets3.0.0/Makefile.in	11 Jan 2002 20:18:03 -0000	1.2
+++ iwidgets3.0.0/Makefile.in	6 Aug 2002 05:39:32 -0000
@@ -45,9 +45,6 @@
 SCRIPT_INSTALL_DIR = @datadir@/iwidgets$(VERSION)
 # END CYGNUS LOCAL
 
-# Directory in which to install the archive libtcl.a:
-LIB_INSTALL_DIR = $(INSTALL_ROOT)$(exec_prefix)/lib
-
 # Directory in which to install the program tclsh:
 BIN_INSTALL_DIR = $(INSTALL_ROOT)$(exec_prefix)/bin
 
@@ -116,7 +113,6 @@
 INSTALL_SCRIPT =	$(INSTALL) -m 555
 MKINSTALLDIRS =		$(srcdir)/../config/mkinstalldirs
 RANLIB =		@RANLIB@
-LN_S =			ln -s
 TOP_DIR =		$(srcdir)
 GENERIC_DIR =		$(TOP_DIR)/generic
 UNIX_DIR =		$(TOP_DIR)/unix
@@ -166,9 +162,7 @@
 install-binaries:
 
 install-libraries:
-	@$(MKINSTALLDIRS) $(SCRIPT_INSTALL_DIR) $(LIB_INSTALL_DIR)
-	@rm -f $(LIB_INSTALL_DIR)/iwidgets
-	$(LN_S) $(SCRIPT_INSTALL_DIR) $(LIB_INSTALL_DIR)/iwidgets
+	@$(MKINSTALLDIRS) $(SCRIPT_INSTALL_DIR)
 	@$(MKINSTALLDIRS) $(SCRIPT_INSTALL_DIR)/scripts
 	@echo "Installing files from $(GENERIC_DIR) into $(SCRIPT_INSTALL_DIR)"
 	@for i in $(GENERIC_DIR)/*.itk $(GENERIC_DIR)/*.itcl $(GENERIC_DIR)/tclIndex $(GENERIC_DIR)/*.gif ; \

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch] remove iwidgets symlink when installing
  2002-08-06  1:53 [Patch] remove iwidgets symlink when installing Mo DeJong
@ 2002-08-06 12:25 ` Keith Seitz
  0 siblings, 0 replies; 2+ messages in thread
From: Keith Seitz @ 2002-08-06 12:25 UTC (permalink / raw)
  To: Mo DeJong; +Cc: Insight

On Mon, 5 Aug 2002, Mo DeJong wrote:

> For some reason, the iwidgets package creates a .../lib/iwidgets symlink
> when installing. I am at a loss to explain why this symlink is in there,
> but it seems to be pointless since Insight works just fine without it.
> This patch removes the symlink and will make it easier to build
> a Source-Navigator RPM. Source-Navigator does not actually
> use iwidgets, but they get installed as part of the build.

Approved and committed.
Keith

> 2002-08-05  Mo Dejong  <supermo@bayarea.net>
> 
> 	* iwidgets3.0.0/Makefile.in: Don't create a
> 	$exec_prefix/lib/iwidgets symlink to
> 	$exec_prefix/share/iwidgets3.0.1. This symlink
> 	is not needed and causes problems when builing
> 	a relocatable RPM since the symlink uses a
> 	fully qualified path name. Remove LN_S and
> 	LIB_INSTALL_DIR variables also.
> 
> Index: iwidgets3.0.0/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/itcl/iwidgets3.0.0/Makefile.in,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile.in
> --- iwidgets3.0.0/Makefile.in	11 Jan 2002 20:18:03 -0000	1.2
> +++ iwidgets3.0.0/Makefile.in	6 Aug 2002 05:39:32 -0000
> @@ -45,9 +45,6 @@
>  SCRIPT_INSTALL_DIR = @datadir@/iwidgets$(VERSION)
>  # END CYGNUS LOCAL
>  
> -# Directory in which to install the archive libtcl.a:
> -LIB_INSTALL_DIR = $(INSTALL_ROOT)$(exec_prefix)/lib
> -
>  # Directory in which to install the program tclsh:
>  BIN_INSTALL_DIR = $(INSTALL_ROOT)$(exec_prefix)/bin
>  
> @@ -116,7 +113,6 @@
>  INSTALL_SCRIPT =	$(INSTALL) -m 555
>  MKINSTALLDIRS =		$(srcdir)/../config/mkinstalldirs
>  RANLIB =		@RANLIB@
> -LN_S =			ln -s
>  TOP_DIR =		$(srcdir)
>  GENERIC_DIR =		$(TOP_DIR)/generic
>  UNIX_DIR =		$(TOP_DIR)/unix
> @@ -166,9 +162,7 @@
>  install-binaries:
>  
>  install-libraries:
> -	@$(MKINSTALLDIRS) $(SCRIPT_INSTALL_DIR) $(LIB_INSTALL_DIR)
> -	@rm -f $(LIB_INSTALL_DIR)/iwidgets
> -	$(LN_S) $(SCRIPT_INSTALL_DIR) $(LIB_INSTALL_DIR)/iwidgets
> +	@$(MKINSTALLDIRS) $(SCRIPT_INSTALL_DIR)
>  	@$(MKINSTALLDIRS) $(SCRIPT_INSTALL_DIR)/scripts
>  	@echo "Installing files from $(GENERIC_DIR) into $(SCRIPT_INSTALL_DIR)"
>  	@for i in $(GENERIC_DIR)/*.itk $(GENERIC_DIR)/*.itcl $(GENERIC_DIR)/tclIndex $(GENERIC_DIR)/*.gif ; \
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-08-06 19:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-06  1:53 [Patch] remove iwidgets symlink when installing Mo DeJong
2002-08-06 12:25 ` Keith Seitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).