public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: insight@sources.redhat.com
Subject: [PATCH] Re: Insight -Werrors
Date: Wed, 04 Dec 2002 08:20:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.44.0212040817560.1506-100000@valrhona.uglyboxes.com> (raw)
In-Reply-To: <3DE91483.1020704@redhat.com>

On Sat, 30 Nov 2002, Andrew Cagney wrote:

> gdbtk-cmds.c:1600: warning: implicit declaration of function 
> `Tk_NameToWindow'
> gdbtk-cmds.c:1601: warning: implicit declaration of function `Tk_MainWindow'
> 
> gdbtk-hooks.c:392: warning: implicit declaration of function `Tk_MainLoop'
> 
> when building configured with --enable-gdb-build-warnings=,-Werror 
> (which, for GDB, is pretty much the norm).

I checked in the following patches which correct these problems.

Thanks for the pointer.

Keith

ChangeLog
2002-12-04  Keith Seitz  <keiths@redhat.com>

        * generic/gdbtk-hooks.c: Include tcl.h and tk.h to pull
        in declarations for some Tk functions used in this file.
        * generic/gdbtk-cmds.c: Likewise.


Patch
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.63
diff -p -r1.63 gdbtk-cmds.c
*** generic/gdbtk-cmds.c	30 Nov 2002 17:49:21 -0000	1.63
--- generic/gdbtk-cmds.c	4 Dec 2002 16:20:36 -0000
***************
*** 40,45 ****
--- 40,47 ----
  #define HAS_STDARG 1
  
  #include <itcl.h>
+ #include <tcl.h>
+ #include <tk.h>
  
  #include "guitcl.h"
  #include "gdbtk.h"
Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.28
diff -p -r1.28 gdbtk-hooks.c
*** generic/gdbtk-hooks.c	27 Nov 2002 19:09:17 -0000	1.28
--- generic/gdbtk-hooks.c	4 Dec 2002 16:20:36 -0000
***************
*** 43,48 ****
--- 43,50 ----
  #define HAS_STDARG 1
  
  #include <itcl.h>
+ #include <tcl.h>
+ #include <tk.h>
  #include "guitcl.h"
  #include "gdbtk.h"
  

      reply	other threads:[~2002-12-04 16:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-30 11:57 Andrew Cagney
2002-12-04  8:20 ` Keith Seitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0212040817560.1506-100000@valrhona.uglyboxes.com \
    --to=keiths@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=insight@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).