Proposal to move tkTreeTable back into sourcenav

Proposal to move tkTreeTable back into sourcenav

[Mo DeJong]

Hi all.

We are going to remove the custom treetable
from snav at some point, but until then we will
need to keep changing it. This is a problem because
is not on sourceware yet and we end up checking
everything in twice. I suggest that code for
the treetable widget be moved from libgui back into
the snavigator module. Insight does not use it
and we are going to get rid of it soon, so there
is no reason to keep it in libgui.

Here are the changes on the libgui side.


( move back into snavigator/hyper )
libgui/src/tkTreeTable.c
libgui/src/tkTreeTable.h


( diffs in libgui )

Index: README
===================================================================
RCS file: /cvs/cvsfiles/devo/libgui/README,v
retrieving revision 1.1
diff -u -r1.1 README
--- README	1997/12/16 14:02:10	1.1
+++ README	2000/07/06 23:35:25
@@ -130,11 +130,6 @@
       to the toplevel to avoid the problems associated with putting
       bindings directly on toplevels.
 
-  treetable.tcl
-    Code that is useful when using the treetable widget.
-    Applications should run "multix_treetable_bindings TreeTable"
-    at startup.
-
   ulset.tcl
     Attempt to make setting the -underline option easier.  This is
     particular good when using gettext.  Unfortunately the interface
@@ -190,13 +185,3 @@
     Patched versions (ugh) of the corresponding Tk files, and some new
     files.  These files implement graph layout for canvases.
 
-  tkTreeTable.c tkTreeTable.c
-    The treetable widget.  This is essentially a hierarchical listbox
-    widget.  As far as I know, there is no documentation.  At some
-    point, maybe I'll write some up.  This widget came from S-N (but
-    they got it from somewhere else), but I've changed it somewhat.
-
-    We'll be merging our version with S-N at some point.
-
-    Your package should run create_treetable_command to make the
-    treetable widget.  Only do this after running Tk_Init.
Index: src/Makefile.am
===================================================================
RCS file: /cvs/cvsfiles/devo/libgui/src/Makefile.am,v
retrieving revision 1.15
diff -u -r1.15 Makefile.am
--- Makefile.am	1999/01/28 01:18:26	1.15
+++ Makefile.am	2000/07/06 23:35:25
@@ -47,7 +47,7 @@
 -DTCL_RUNTIME=\"tkTable.tcl\"
 
 libgui_a_SOURCES = guitcl.h paths.c subcommand.c subcommand.h \
-tkTreeTable.c tkTreeTable.h xpmlib.c tclmain.c tkGraphCanvas.c \
+xpmlib.c tclmain.c tkGraphCanvas.c \
 tkCanvEdge.c tkCanvLayout.c tkCanvLayout.h tclhelp.c tclgetdir.c \
 tclwinprint.c tclsizebox.c tclshellexe.c tclmapi.c tclwinfont.c	\
 tclwingrab.c tclwinmode.c tclwinpath.c tclmsgbox.c tclcursor.c \
@@ -61,7 +61,6 @@
 tkCanvEdge.$(OBJEXT): tkCanvEdge.c ../config.h
 tkCanvLayout.$(OBJEXT): tkCanvLayout.c ../config.h tkCanvLayout.h
 tkGraphCanvas.$(OBJEXT): tkGraphCanvas.c tkCanvLayout.h
-tkTreeTable.$(OBJEXT): tkTreeTable.c tkTreeTable.h
 xpmlib.$(OBJEXT): xpmlib.c guitcl.h
 assertions.$(OBJEXT): assertions.c ../config.h assertions.h
 tclcursor.$(OBJEXT): tclcursor.c ../config.h guitcl.h subcommand.h
Index: src/guitcl.h
===================================================================
RCS file: /cvs/cvsfiles/devo/libgui/src/guitcl.h,v
retrieving revision 1.3
diff -u -r1.3 guitcl.h
--- guitcl.h	1999/09/19 01:20:08	1.3
+++ guitcl.h	2000/07/06 23:35:25
@@ -37,12 +37,6 @@
 extern int
 ide_run_app_script (Tcl_Interp *);
 
-/* This adds the new Tk widget `treetable' to the interpreter
-   IDE_INTERP.
-   Returns a standard Tcl result.  */
-extern int
-create_treetable_command (Tcl_Interp *ide_interp);
-
 /* This adds the new graph command for manipulating graphs to the
    interpreter IDE_INTERP.  
    Returns a standard Tcl result.  */


Mo DeJong
Red Hat Inc

Re: Proposal to move tkTreeTable back into sourcenav

[Syd Polk]

Aren't there a couple of tcl files in libgui/library which only apply to 
Source-Navigator? These should be moved also.

At 04:47 PM 7/6/00 -0700, Mo DeJong wrote:
>Hi all.
>
>We are going to remove the custom treetable
>from snav at some point, but until then we will
>need to keep changing it. This is a problem because
>is not on sourceware yet and we end up checking
>everything in twice. I suggest that code for
>the treetable widget be moved from libgui back into
>the snavigator module. Insight does not use it
>and we are going to get rid of it soon, so there
>is no reason to keep it in libgui.
>
>Here are the changes on the libgui side.
>
>
>( move back into snavigator/hyper )
>libgui/src/tkTreeTable.c
>libgui/src/tkTreeTable.h
>
>
>( diffs in libgui )
>
>Index: README
>===================================================================
>RCS file: /cvs/cvsfiles/devo/libgui/README,v
>retrieving revision 1.1
>diff -u -r1.1 README
>--- README      1997/12/16 14:02:10     1.1
>+++ README      2000/07/06 23:35:25
>@@ -130,11 +130,6 @@
>        to the toplevel to avoid the problems associated with putting
>        bindings directly on toplevels.
>
>-  treetable.tcl
>-    Code that is useful when using the treetable widget.
>-    Applications should run "multix_treetable_bindings TreeTable"
>-    at startup.
>-
>    ulset.tcl
>      Attempt to make setting the -underline option easier.  This is
>      particular good when using gettext.  Unfortunately the interface
>@@ -190,13 +185,3 @@
>      Patched versions (ugh) of the corresponding Tk files, and some new
>      files.  These files implement graph layout for canvases.
>
>-  tkTreeTable.c tkTreeTable.c
>-    The treetable widget.  This is essentially a hierarchical listbox
>-    widget.  As far as I know, there is no documentation.  At some
>-    point, maybe I'll write some up.  This widget came from S-N (but
>-    they got it from somewhere else), but I've changed it somewhat.
>-
>-    We'll be merging our version with S-N at some point.
>-
>-    Your package should run create_treetable_command to make the
>-    treetable widget.  Only do this after running Tk_Init.
>Index: src/Makefile.am
>===================================================================
>RCS file: /cvs/cvsfiles/devo/libgui/src/Makefile.am,v
>retrieving revision 1.15
>diff -u -r1.15 Makefile.am
>--- Makefile.am 1999/01/28 01:18:26     1.15
>+++ Makefile.am 2000/07/06 23:35:25
>@@ -47,7 +47,7 @@
>  -DTCL_RUNTIME=\"tkTable.tcl\"
>
>  libgui_a_SOURCES = guitcl.h paths.c subcommand.c subcommand.h \
>-tkTreeTable.c tkTreeTable.h xpmlib.c tclmain.c tkGraphCanvas.c \
>+xpmlib.c tclmain.c tkGraphCanvas.c \
>  tkCanvEdge.c tkCanvLayout.c tkCanvLayout.h tclhelp.c tclgetdir.c \
>  tclwinprint.c tclsizebox.c tclshellexe.c tclmapi.c tclwinfont.c        \
>  tclwingrab.c tclwinmode.c tclwinpath.c tclmsgbox.c tclcursor.c \
>@@ -61,7 +61,6 @@
>  tkCanvEdge.$(OBJEXT): tkCanvEdge.c ../config.h
>  tkCanvLayout.$(OBJEXT): tkCanvLayout.c ../config.h tkCanvLayout.h
>  tkGraphCanvas.$(OBJEXT): tkGraphCanvas.c tkCanvLayout.h
>-tkTreeTable.$(OBJEXT): tkTreeTable.c tkTreeTable.h
>  xpmlib.$(OBJEXT): xpmlib.c guitcl.h
>  assertions.$(OBJEXT): assertions.c ../config.h assertions.h
>  tclcursor.$(OBJEXT): tclcursor.c ../config.h guitcl.h subcommand.h
>Index: src/guitcl.h
>===================================================================
>RCS file: /cvs/cvsfiles/devo/libgui/src/guitcl.h,v
>retrieving revision 1.3
>diff -u -r1.3 guitcl.h
>--- guitcl.h    1999/09/19 01:20:08     1.3
>+++ guitcl.h    2000/07/06 23:35:25
>@@ -37,12 +37,6 @@
>  extern int
>  ide_run_app_script (Tcl_Interp *);
>
>-/* This adds the new Tk widget `treetable' to the interpreter
>-   IDE_INTERP.
>-   Returns a standard Tcl result.  */
>-extern int
>-create_treetable_command (Tcl_Interp *ide_interp);
>-
>  /* This adds the new graph command for manipulating graphs to the
>     interpreter IDE_INTERP.
>     Returns a standard Tcl result.  */
>
>
>Mo DeJong
>Red Hat Inc

Syd Polk		spolk@redhat.com
Engineering Manager	+1 415 777 9810 x 241
Red Hat, Inc.

Re: Proposal to move tkTreeTable back into sourcenav

[Mo DeJong]

On Thu, 6 Jul 2000, Syd Polk wrote:

> Aren't there a couple of tcl files in libgui/library which only apply to 
> Source-Navigator? These should be moved also.

Yeah, you need this patch too.

Index: library/Makefile.am
===================================================================
RCS file: /cvs/cvsfiles/devo/libgui/library/Makefile.am,v
retrieving revision 1.30
diff -u -r1.30 Makefile.am
--- Makefile.am 2000/04/20 00:38:18     1.30
+++ Makefile.am 2000/07/07 00:02:08
@@ -8,8 +8,8 @@
 font.tcl gensym.tcl gettext.tcl hooks.tcl lframe.tcl list.tcl \
 looknfeel.tcl menu.tcl mono.tcl multibox.tcl parse_args.tcl path.tcl \
 postghost.tcl prefs.tcl print.tcl sendpr.tcl topbind.tcl toolbar.tcl \
-treetable.tcl ulset.tcl wframe.tcl wingrab.tcl ventry.tcl combobox.tcl \
-pane.tcl panedwindow.tcl tree.tcl
+ulset.tcl wframe.tcl wingrab.tcl ventry.tcl combobox.tcl \
+pane.tcl panedwindow.tcl
 
 PACKAGES = combobox.tcl

Mo DeJong
Red Hat Inc

Re: Proposal to move tkTreeTable back into sourcenav

[Mo DeJong]

Syd gave me the ok to move tkTreeTable and friends back into
sourcenav so I am going to do that now and check it into
devo and sourceware.

Mo DeJong  
Red Hat Inc