Re: TODO list (REPOST)

[Mo DeJong <mdejong@cygnus.com>]

On Tue, 10 Oct 2000, Fernando Nasser wrote:

(Bunch of stuff about what to fix in insight)


With all this talk of "fixing" insight, I thought I
would bring up the old name issue again. The #1
question people have when starting out with
insight is "how do I run it?". People automatically
assume that the name of the executable is insight.

Lets just change the name of the executable to
insight, it is the right thing to do. This
also gets around the problem of typing % gdb
and getting insight when you expected to get
the cmd line gdb from the distro.

Here is my patch to implement the change
(minus the patch for configure itself).

Ok to check in?

Mo DeJong
Red Hat Inc

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.702
diff -u -r1.702 ChangeLog
--- ChangeLog	2000/10/10 05:17:25	1.702
+++ ChangeLog	2000/10/11 06:12:33
@@ -1,3 +1,11 @@
+2000-10-10  Mo DeJong  <mdejong@redhat.com>
+
+	* Makefile.in: Add GDB variable, it will be set to
+	gdb or insight, depending on what mode is used.
+	* configure: Regen.
+	* configure.in: Add GDB variable, pass it to Makefile.in.
+	* gdbtk/README.GDBTK: Fixed minor little typo.
+
 2000-10-09  Kevin Buettner  <kevinb@redhat.com>
 
 	* remote-nindy.c (non_dle, nindy_xfer_inferior_memory): Protoize.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.44
diff -u -r1.44 Makefile.in
--- Makefile.in	2000/10/08 22:31:22	1.44
+++ Makefile.in	2000/10/11 06:12:35
@@ -62,6 +62,9 @@
 WINDRES = @WINDRES@
 MIG = @MIG@
 
+# Name of gdb executable, set to "insight" in gdbtk mode
+GDB = @GDB@
+
 # Flags that describe where you can find the termcap library.
 # This can be overridden in the host Makefile fragment file.
 TERMCAP = @TERM_LIB@
@@ -669,7 +672,7 @@
 .c.o:
 	$(CC) -c $(INTERNAL_CFLAGS) $<
 
-all: gdb$(EXEEXT) $(CONFIG_ALL)
+all: $(GDB)$(EXEEXT) $(CONFIG_ALL)
 	@$(MAKE) $(FLAGS_TO_PASS) DO=all "DODIRS=`echo $(SUBDIRS) | sed 
's/testsuite//'`" subdir_do
 
 installcheck:
@@ -700,23 +703,23 @@
 install: all install-only
 install-only: $(CONFIG_INSTALL)
 	transformed_name=`t='$(program_transform_name)'; \
-			  echo gdb | sed -e $$t` ; \
+			  echo $(GDB) | sed -e $$t` ; \
 		if test "x$$transformed_name" = x; then \
-		  transformed_name=gdb ; \
+		  transformed_name=$(GDB) ; \
 		else \
 		  true ; \
 		fi ; \
 		$(srcdir)/../mkinstalldirs $(bindir) ; \
-		$(INSTALL_PROGRAM) gdb$(EXEEXT) 
$(bindir)/$$transformed_name$(EXEEXT) ; \
+		$(INSTALL_PROGRAM) $(GDB)$(EXEEXT) 
$(bindir)/$$transformed_name$(EXEEXT) ; \
 		$(srcdir)/../mkinstalldirs $(man1dir) ; \
 		$(INSTALL_DATA) $(srcdir)/gdb.1 $(man1dir)/$$transformed_name.1
 	@$(MAKE) DO=install "DODIRS=$(SUBDIRS)" $(FLAGS_TO_PASS) 
subdir_do 
 
 uninstall: force $(CONFIG_UNINSTALL)
 	transformed_name=`t='$(program_transform_name)'; \
-			  echo gdb | sed -e $$t` ; \
+			  echo $(GDB) | sed -e $$t` ; \
 		if test "x$$transformed_name" = x; then \
-		  transformed_name=gdb ; \
+		  transformed_name=$(GDB) ; \
 		else \
 		  true ; \
 		fi ; \
@@ -783,9 +786,9 @@
 init.o: init.c $(defs_h) $(call_cmds_h)
 
 # Removing the old gdb first works better if it is running, at least on 
SunOS.
-gdb$(EXEEXT): main.o libgdb.a $(ADD_DEPS) $(CDEPS) $(TDEPLIBS)
-	rm -f gdb$(EXEEXT)
-	$(HLDENV) $(CC_LD) $(INTERNAL_LDFLAGS) $(WIN32LDAPP) -o 
gdb$(EXEEXT) main.o libgdb.a $(TDEPLIBS) $(TUI_LIBRARY) $(CLIBS) $(LOADLIBES)
+$(GDB)$(EXEEXT): main.o libgdb.a $(ADD_DEPS) $(CDEPS) $(TDEPLIBS)
+	rm -f $(GDB)$(EXEEXT)
+	$(HLDENV) $(CC_LD) $(INTERNAL_LDFLAGS) $(WIN32LDAPP) -o 
$(GDB)$(EXEEXT) main.o libgdb.a $(TDEPLIBS) $(TUI_LIBRARY) $(CLIBS) 
$(LOADLIBES)
 
 nlm:	force
 	rootme=`pwd`; export rootme; $(MAKE) $(TARGET_FLAGS_TO_PASS) 
DO=all DODIRS=nlm subdir_do
@@ -838,7 +841,7 @@
 # in another process.
 gdb1$(EXEEXT): gdb$(EXEEXT)
 	rm -f gdb1$(EXEEXT)
-	cp gdb$(EXEEXT) gdb1$(EXEEXT)
+	cp $(GDB)$(EXEEXT) gdb1$(EXEEXT)
 
 # FIXME. These are not generated by "make depend" because they only are 
there
 # for some machines.
@@ -883,7 +886,7 @@
 	@$(MAKE) $(FLAGS_TO_PASS) DO=clean "DODIRS=$(SUBDIRS)" subdir_do 
 	rm -f *.o *.a $(ADD_FILES) *~ init.c-tmp init.l-tmp
 	rm -f init.c version.c
-	rm -f gdb$(EXEEXT) core make.log
+	rm -f $(GDB)$(EXEEXT) core make.log
 	rm -f gdb[0-9]$(EXEEXT)
 
 # This used to depend on c-exp.tab.c m2-exp.tab.c TAGS
Index: configure.in
===================================================================
RCS file: /cvs/src/src/gdb/configure.in,v
retrieving revision 1.44
diff -u -r1.44 configure.in
--- configure.in	2000/09/11 17:57:07	1.44
+++ configure.in	2000/10/11 06:12:35
@@ -759,9 +759,13 @@
 
 configdir="unix"
 
+# This will be set to "insight" if using gdbtk
+GDB=gdb
+
 GDBTKLIBS=
 if test "${enable_gdbtk}" = "yes"; then
 
+    GDB=insight
     CY_AC_PATH_TCLCONFIG
     if test -z "${no_tcl}"; then
 	CY_AC_LOAD_TCLCONFIG
@@ -869,6 +873,7 @@
 AC_SUBST(ITK_DEPS)
 AC_SUBST(TIXLIB)
 AC_SUBST(TIX_DEPS)
+AC_SUBST(GDB)
 AC_SUBST(GDBTKLIBS)
 AC_SUBST(GDBTK_CFLAGS)
 
Index: gdbtk/README.GDBTK
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/README.GDBTK,v
retrieving revision 1.2
diff -u -r1.2 README.GDBTK
--- README.GDBTK	2000/04/17 20:20:20	1.2
+++ README.GDBTK	2000/10/11 06:12:36
@@ -10,7 +10,7 @@
 ============
 
 GDBtk is a version of GDB that uses Tcl/Tk to implement a graphical
-user inter-face.  It is a fully integrated GUI, not a separate
+user interface.  It is a fully integrated GUI, not a separate
 front-end program.  The interface consists of several seperate
 windows, which use standard elements like buttons, scrollbars, entry
 boxes and such to create a fairly easy to use interface.  Each window