public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* Make "Choose Color" dialog a Modal dialog
@ 2005-08-05  5:19 Aditya Katti
  2005-08-05  9:48 ` Dave Korn
  0 siblings, 1 reply; 2+ messages in thread
From: Aditya Katti @ 2005-08-05  5:19 UTC (permalink / raw)
  To: insight

Hi,
Please find below a patch for Insight (srcpref.itb). Previously multiple "Choose Color" dialogs were being opened. This patch will make "Choose Color" dialog a Modal dialog.


For gdb/gdbtk/ChangeLog:
============================================gdb/gdbtk/ChangeLog===============================================

2005-08-03  Aditya Katti  <adityak@kpitcummins.com>

  * library/srcpref.itb (_pick): Makes "Choose Color" dialog a Modal dialog

==============================================================================================================

For gdb/gdbtk/library/srcpref.itb:
========================================gdb/gdbtk/library/srcpref.itb=========================================

*** insight-6.1/gdb/gdbtk/library/srcpref.itb.orig	Wed Aug  3 12:37:30 2005
--- insight-6.1/gdb/gdbtk/library/srcpref.itb	Wed Aug  3 12:37:52 2005
***************
*** 270,274 ****
  # ------------------------------------------------------------------
  itcl::body SrcPref::_pick {color win tag} {
!   set new_color [tk_chooseColor -initialcolor $color -title "Choose color"]
    if {$new_color != $color && $new_color != {}} {
      set _new(gdb/src/$tag) $new_color
--- 270,274 ----
  # ------------------------------------------------------------------
  itcl::body SrcPref::_pick {color win tag} {
!   set new_color [tk_chooseColor -initialcolor $color -title "Choose color" -parent $win]
    if {$new_color != $color && $new_color != {}} {
      set _new(gdb/src/$tag) $new_color

================================================End Of Patch==================================================


Regards,
Aditya Katti
KPIT Cummins Infosystems Limited
Pune, INDIA

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: Make "Choose Color" dialog a Modal dialog
  2005-08-05  5:19 Make "Choose Color" dialog a Modal dialog Aditya Katti
@ 2005-08-05  9:48 ` Dave Korn
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Korn @ 2005-08-05  9:48 UTC (permalink / raw)
  To: 'Aditya Katti', insight

----Original Message----
>From: Aditya Katti
>Sent: 05 August 2005 06:19

> Hi,
> Please find below a patch for Insight (srcpref.itb). Previously multiple
> "Choose Color" dialogs were being opened. This patch will make "Choose
> Color" dialog a Modal dialog.  

  I don't have any approval rights, but I can confirm the problem exists and
that the patch fixes it.  Thanks! :)

  [ NB. to the list: It might not seem a problem allowing multiple "Choose
color" dialogs open if they all updated their correct colours in the
palette, but in fact when several are open they fail to redraw properly, so
making it modal is a good idea. ]


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-08-05  9:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-08-05  5:19 Make "Choose Color" dialog a Modal dialog Aditya Katti
2005-08-05  9:48 ` Dave Korn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).