public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* Insight broken with latest tcl/tk
@ 2009-05-03 17:35 Dave Lawrence
  2009-05-04 21:41 ` Kevin Buettner
                   ` (3 more replies)
  0 siblings, 4 replies; 21+ messages in thread
From: Dave Lawrence @ 2009-05-03 17:35 UTC (permalink / raw)
  To: insight

It would appear that insight no longer works with the latest tcl/tk.

The following error
Can't find a usable tk.tcl in the following directories:
    /usr/local/share/tk8.4 /usr/local/lib/tk8.4 /usr/lib/tk8.4
/usr/local/library /usr/library /usr/tk8.4.1/library /tk8.4.1/library

or similar seems to have been reported on several newsgroups / blogs etc
however I have never seen a solution.

Crucially I think we need to determine what "useable" means in this
context.  I certainly do have a tk.tcl file in /usr/local/share/tk8.4/,
which is included in that search path.

I am compiling this on Ubuntu 9.04.  I have previously successfully
compiled and run insight on a Ubuntu 8.10 host, targeted for both arm
and sh platforms.  Also, one Ubuntu 8.10 host which I upgraded to 9.04
still has both arm-elf and sh-elf targets working.

I specifically installed tk8.4-dev (rather than tk-dev) - note that
tk8.5 dev gives an error at compile time.

I also tried a snapshot of the latest insight sources, attempting to
build these gives me various undefined references at build time, I'll
list a few below:
c_parse
c_error
f_parse
f_error
objc_parse
java_error

From google I see that this is broken on various platforms and it mainly
seems to be associated with the version of tk/tcl - but strangely I
can't fix it even by installing a specific version.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-03 17:35 Insight broken with latest tcl/tk Dave Lawrence
@ 2009-05-04 21:41 ` Kevin Buettner
  2009-05-05  5:37 ` Gene Smith
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 21+ messages in thread
From: Kevin Buettner @ 2009-05-04 21:41 UTC (permalink / raw)
  To: insight

On Sun, 03 May 2009 14:08:51 +0100
Dave Lawrence <dlawrence@ad-holdings.co.uk> wrote:

> It would appear that insight no longer works with the latest tcl/tk.

FWIW, I'm working on merging Tcl/Tk 8.5.7 and itcl/itk/iwidgets CVS HEAD
(from sourceforge) into the sourceware repository.

I've gotten it to build and run with insight on Linux (Fedora 10), but
am still working on the Cygwin build.  I'll post a message to this list
when I'm ready to commit.

Kevin

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-03 17:35 Insight broken with latest tcl/tk Dave Lawrence
  2009-05-04 21:41 ` Kevin Buettner
@ 2009-05-05  5:37 ` Gene Smith
  2009-05-05 13:44   ` Gene Smith
  2009-05-06  4:13 ` Gene Smith
  2009-06-14  4:40 ` Gene Smith
  3 siblings, 1 reply; 21+ messages in thread
From: Gene Smith @ 2009-05-05  5:37 UTC (permalink / raw)
  To: insight

Dave Lawrence wrote:
> It would appear that insight no longer works with the latest tcl/tk.
> 
> The following error
> Can't find a usable tk.tcl in the following directories:
>     /usr/local/share/tk8.4 /usr/local/lib/tk8.4 /usr/lib/tk8.4
> /usr/local/library /usr/library /usr/tk8.4.1/library /tk8.4.1/library
> 

Same error for me on u9.04. File is definitely present at
<install-point>/share/tk8.4/tk.tcl.  Tried making it executable but
didn't matter. Then it then tries to use it but gets a bunch of errors:

    <begin error output>
<install-point>/share/tk8.4/tk.tcl: no event type or button # or keysym
no event type or button # or keysym

    while executing

"bind Listbox <MouseWheel> {

    %W yview scroll [expr {- (%D / 120) * 4}] units

}"

    (file "<install-point>/share/tk8.4/listbox.tcl" line 182)
    invoked from within

"source <install-point>/share/tk8.4/listbox.tcl"
    (in namespace eval "::" script line 1)

    invoked from within

"namespace eval :: [list source [file join $::tk_library $file.tcl]]"

    (procedure "SourceLibFile" line 2)

    invoked from within

"SourceLibFile listbox"

    (in namespace eval "::tk" script line 4)

    invoked from within

"namespace eval ::tk {
        SourceLibFile button
        SourceLibFile entry
        SourceLibFile listbox
        SourceLibFile menu
        SourceLibFile panedwindow
        SourceLibFile ..."
    invoked from within
"if {$::tk_library ne ""} {
    if {$tcl_platform(platform) eq "macintosh"} {
        proc ::tk::SourceLibFile {file} {
            if {[catch {
                namespace eval :: ..."
    (file "<install-point>/share/tk8.4/tk.tcl" line 407)
    invoked from within
"source <install-point>/share/tk8.4/tk.tcl"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 [list source $file]"


This probably means that tk wasn't installed properly.
<end of error output>

Could this have anything to do with my system being x86_64? Also, when
compiling just gdb and now insight/gdb I had to set -Wno-error in CFLAGS
since it kept stopping on warnings. Never need to do this in i386 or
older gcc on fedora8.

-gene

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-05  5:37 ` Gene Smith
@ 2009-05-05 13:44   ` Gene Smith
  2009-05-05 17:37     ` Kevin Buettner
  0 siblings, 1 reply; 21+ messages in thread
From: Gene Smith @ 2009-05-05 13:44 UTC (permalink / raw)
  To: insight

Gene Smith wrote:
> Dave Lawrence wrote:
>> It would appear that insight no longer works with the latest tcl/tk.
>>
>> The following error
>> Can't find a usable tk.tcl in the following directories:
>>     /usr/local/share/tk8.4 /usr/local/lib/tk8.4 /usr/lib/tk8.4
>> /usr/local/library /usr/library /usr/tk8.4.1/library /tk8.4.1/library
>>
> 
> Same error for me on u9.04. File is definitely present at
> <install-point>/share/tk8.4/tk.tcl.  Tried making it executable but
> didn't matter. Then it then tries to use it but gets a bunch of errors:
> 
>     <begin error output>
> <install-point>/share/tk8.4/tk.tcl: no event type or button # or keysym
> no event type or button # or keysym
> 
>     while executing
> 
> "bind Listbox <MouseWheel> {
> 
>     %W yview scroll [expr {- (%D / 120) * 4}] units
> 
> }"
> 
>     (file "<install-point>/share/tk8.4/listbox.tcl" line 182)
>     invoked from within
> 
> "source <install-point>/share/tk8.4/listbox.tcl"
>     (in namespace eval "::" script line 1)
> 
>     invoked from within
> 
> "namespace eval :: [list source [file join $::tk_library $file.tcl]]"
> 
>     (procedure "SourceLibFile" line 2)
> 
>     invoked from within
> 
> "SourceLibFile listbox"
> 
>     (in namespace eval "::tk" script line 4)
> 
>     invoked from within
> 
> "namespace eval ::tk {
>         SourceLibFile button
>         SourceLibFile entry
>         SourceLibFile listbox
>         SourceLibFile menu
>         SourceLibFile panedwindow
>         SourceLibFile ..."
>     invoked from within
> "if {$::tk_library ne ""} {
>     if {$tcl_platform(platform) eq "macintosh"} {
>         proc ::tk::SourceLibFile {file} {
>             if {[catch {
>                 namespace eval :: ..."
>     (file "<install-point>/share/tk8.4/tk.tcl" line 407)
>     invoked from within
> "source <install-point>/share/tk8.4/tk.tcl"
>     ("uplevel" body line 1)
>     invoked from within
> "uplevel #0 [list source $file]"
> 
> 
> This probably means that tk wasn't installed properly.
> <end of error output>
> 
> Could this have anything to do with my system being x86_64? Also, when
> compiling just gdb and now insight/gdb I had to set -Wno-error in CFLAGS
> since it kept stopping on warnings. Never need to do this in i386 or
> older gcc on fedora8.
> 
> -gene
> 
> 

Here they claim to be able to fix it by editing a couple tcl files. 
Don't have the system with me right now to try it.

http://forums.fedoraforum.org/showthread.php?t=213441

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-05 13:44   ` Gene Smith
@ 2009-05-05 17:37     ` Kevin Buettner
  2009-05-05 18:43       ` Gene Smith
  0 siblings, 1 reply; 21+ messages in thread
From: Kevin Buettner @ 2009-05-05 17:37 UTC (permalink / raw)
  To: insight

On Tue, 05 May 2009 09:44:12 -0400
Gene Smith <gds@chartertn.net> wrote:

> Here they claim to be able to fix it by editing a couple tcl files. 
> Don't have the system with me right now to try it.
> 
> http://forums.fedoraforum.org/showthread.php?t=213441

That "fix" should be considered, at best, a workaround.  I've backported
the correct fix to the sourceware tk sources.  For more information, see:

    http://sources.redhat.com/ml/insight/2009-q1/msg00010.html

Kevin

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-05 17:37     ` Kevin Buettner
@ 2009-05-05 18:43       ` Gene Smith
  2009-05-05 20:17         ` Kevin Buettner
  0 siblings, 1 reply; 21+ messages in thread
From: Gene Smith @ 2009-05-05 18:43 UTC (permalink / raw)
  To: insight

Kevin Buettner wrote:
> On Tue, 05 May 2009 09:44:12 -0400
> Gene Smith <gds@chartertn.net> wrote:
> 
>> Here they claim to be able to fix it by editing a couple tcl files. 
>> Don't have the system with me right now to try it.
>>
>> http://forums.fedoraforum.org/showthread.php?t=213441
> 
> That "fix" should be considered, at best, a workaround.  I've backported
> the correct fix to the sourceware tk sources.  For more information, see:
> 
>     http://sources.redhat.com/ml/insight/2009-q1/msg00010.html
> 
> Kevin
> 

Thanks for the quick work! But I'm not exactly sure where to find this 
fix. Insight or tk CVS? Insight FTP/snapshots? Or should I just apply 
the patch to my current insight sources files?

-gene

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-05 18:43       ` Gene Smith
@ 2009-05-05 20:17         ` Kevin Buettner
  2009-05-06  2:17           ` Gene Smith
  0 siblings, 1 reply; 21+ messages in thread
From: Kevin Buettner @ 2009-05-05 20:17 UTC (permalink / raw)
  To: insight

On Tue, 05 May 2009 14:42:35 -0400
Gene Smith <gds@chartertn.net> wrote:

> Thanks for the quick work! But I'm not exactly sure where to find this 
> fix. Insight or tk CVS? Insight FTP/snapshots? Or should I just apply 
> the patch to my current insight sources files?

The patch that I posted is in sourceware CVS.  The fix is also in
sourceforge CVS; that's where I got it from.

Kevin

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-05 20:17         ` Kevin Buettner
@ 2009-05-06  2:17           ` Gene Smith
  2009-05-06  3:04             ` Gene Smith
  0 siblings, 1 reply; 21+ messages in thread
From: Gene Smith @ 2009-05-06  2:17 UTC (permalink / raw)
  To: insight

Kevin Buettner wrote:
> On Tue, 05 May 2009 14:42:35 -0400
> Gene Smith <gds@chartertn.net> wrote:
> 
>> Thanks for the quick work! But I'm not exactly sure where to find this 
>> fix. Insight or tk CVS? Insight FTP/snapshots? Or should I just apply 
>> the patch to my current insight sources files?
> 
> The patch that I posted is in sourceware CVS.  The fix is also in
> sourceforge CVS; that's where I got it from.
> 
> Kevin
> 

I see that the three changed tk files were actually put into Insight
back in Feb 2009 and are present in the latest snapshot on ftp, 0427.
However, when I try to build that version there are errors. So I copied
the 3 files back to the Insight 6.8 tree and rebuilt 6.8. This builds OK
on u9.04, x86_64, gcc 4.3.3 and Insight runs. However, had to configure
with CFLAG setting of -Wno-error to avoid failing the build on numerous
warnings.
-gene

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-06  2:17           ` Gene Smith
@ 2009-05-06  3:04             ` Gene Smith
  0 siblings, 0 replies; 21+ messages in thread
From: Gene Smith @ 2009-05-06  3:04 UTC (permalink / raw)
  To: insight

Gene Smith wrote:

> However, when I try to build that version there are errors. 

Tried again to build insight-weekly-CVS-6.8.50-20090427.tar.bz2 and this
time it worked and runs. I must have done something wrong the first time
I tried. Have not tried the CVS head version.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-03 17:35 Insight broken with latest tcl/tk Dave Lawrence
  2009-05-04 21:41 ` Kevin Buettner
  2009-05-05  5:37 ` Gene Smith
@ 2009-05-06  4:13 ` Gene Smith
  2009-05-06  4:53   ` Gene Smith
  2009-06-14  4:40 ` Gene Smith
  3 siblings, 1 reply; 21+ messages in thread
From: Gene Smith @ 2009-05-06  4:13 UTC (permalink / raw)
  To: insight

Dave Lawrence wrote:
> 
> I also tried a snapshot of the latest insight sources, attempting to
> build these gives me various undefined references at build time, I'll
> list a few below:
> c_parse
> c_error
> f_parse
> f_error
> objc_parse
> java_error
> 

With the current CVS head I get this error. "read_pc" function (function
ptr?) is implicitly declared. How would you fix this? This is u9.04 and
x86_64.

gdb/../bfd -I../../insight_sources/gdb/../include -I../libdecnumber
-I../../insight_sources/gdb/../libdecnumber
-I../../insight_sources/gdb/gnulib -Ignulib  -DMI_OUT=1 -DTUI=1  -DGDBTK
 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral
-Wno-pointer-sign -Wno-unused -Wno-switch -Wno-char-subscripts -Werror
-c -o gdbtk-cmds.o -MT gdbtk-cmds.o -MMD -MP -MF .deps/gdbtk-cmds.Tpo
-I../../insight_sources/gdb/../libgui/src
-I/home/gene/insight/insight_sources/tcl/generic
-I/home/gene/insight/insight_sources/tk/generic
-DGDBTK_LIBRARY=\"/home/gene/eabi/install/share/insight1.0\"
-DSRC_DIR=\"/home/gene/insight/insight_sources/gdb\"
../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c
cc1: warnings being treated as errors
../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c: In function ‘gdb_loc’:
../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c:2147: error:
implicit declaration of function ‘read_pc’
make[2]: *** [gdbtk-cmds.o] Error 1

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-06  4:13 ` Gene Smith
@ 2009-05-06  4:53   ` Gene Smith
  2009-05-06 15:30     ` Keith Seitz
  0 siblings, 1 reply; 21+ messages in thread
From: Gene Smith @ 2009-05-06  4:53 UTC (permalink / raw)
  To: insight

Gene Smith wrote:
> Dave Lawrence wrote:
>> I also tried a snapshot of the latest insight sources, attempting to
>> build these gives me various undefined references at build time, I'll
>> list a few below:
>> c_parse
>> c_error
>> f_parse
>> f_error
>> objc_parse
>> java_error
>>
> 
> With the current CVS head I get this error. "read_pc" function (function
> ptr?) is implicitly declared. How would you fix this? This is u9.04 and
> x86_64.
> 
> gdb/../bfd -I../../insight_sources/gdb/../include -I../libdecnumber
> -I../../insight_sources/gdb/../libdecnumber
> -I../../insight_sources/gdb/gnulib -Ignulib  -DMI_OUT=1 -DTUI=1  -DGDBTK
>  -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral
> -Wno-pointer-sign -Wno-unused -Wno-switch -Wno-char-subscripts -Werror
> -c -o gdbtk-cmds.o -MT gdbtk-cmds.o -MMD -MP -MF .deps/gdbtk-cmds.Tpo
> -I../../insight_sources/gdb/../libgui/src
> -I/home/gene/insight/insight_sources/tcl/generic
> -I/home/gene/insight/insight_sources/tk/generic
> -DGDBTK_LIBRARY=\"/home/gene/eabi/install/share/insight1.0\"
> -DSRC_DIR=\"/home/gene/insight/insight_sources/gdb\"
> ../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c
> cc1: warnings being treated as errors
> ../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c: In function ‘gdb_loc’:
> ../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c:2147: error:
> implicit declaration of function ‘read_pc’
> make[2]: *** [gdbtk-cmds.o] Error 1

Well, I forced it to ignore errors but now on link I get undefined
reference to read_pc:
gcc -Wno-error      \
                -o gdb gdb.o libgdb.a \
                  ../sim/arm/libsim.a ../readline/libreadline.a
../opcodes/libopcodes.a ../bfd/libbfd.a  ../libiberty/libiberty.a
../libdecnumber/libdecnumber.a   ../libgui/src/libgui.a
-L/home/gene/insight/insight_build/tk/unix -ltk8.4
-L/home/gene/insight/insight_build/tcl/unix -ltcl8.4   -lX11 -ldl
-lieee -lm -lncurses -lm     -lpython2.6  ../libiberty/libiberty.a
gnulib/libgnu.a
libgdb.a(gdbtk-cmds.o): In function `gdb_loc':
gdbtk-cmds.c:(.text+0x3503): undefined reference to `read_pc'
gdbtk-cmds.c:(.text+0x3533): undefined reference to `read_pc'
collect2: ld returned 1 exit status

I give up!



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-06  4:53   ` Gene Smith
@ 2009-05-06 15:30     ` Keith Seitz
  2009-05-06 15:46       ` Pierre Muller
  0 siblings, 1 reply; 21+ messages in thread
From: Keith Seitz @ 2009-05-06 15:30 UTC (permalink / raw)
  To: Gene Smith; +Cc: insight

Gene Smith wrote:

>> ../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c: In function ‘gdb_loc’:
>> ../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c:2147: error:
>> implicit declaration of function ‘read_pc’
>> make[2]: *** [gdbtk-cmds.o] Error 1
[snip]
> gdbtk-cmds.c:(.text+0x3503): undefined reference to `read_pc'
> gdbtk-cmds.c:(.text+0x3533): undefined reference to `read_pc'
> collect2: ld returned 1 exit status

These are the same problem. On May 5 (yesterday), someone checked in a 
patch to remove read_pc. It is now apparently called "regcache_read_pc".

I'll fix this later today. Busy morning.

Keith

^ permalink raw reply	[flat|nested] 21+ messages in thread

* RE: Insight broken with latest tcl/tk
  2009-05-06 15:30     ` Keith Seitz
@ 2009-05-06 15:46       ` Pierre Muller
  2009-05-06 15:48         ` Keith Seitz
  0 siblings, 1 reply; 21+ messages in thread
From: Pierre Muller @ 2009-05-06 15:46 UTC (permalink / raw)
  To: 'Keith Seitz', 'Gene Smith'; +Cc: insight

 I wrote a minimal patch...
allows insight to compile again...
Should I commit it?

Pierre Muller
Pascal language support maintainer for GDB

PS: It compiles but is still unusable on my cygwin machine :(

> -----Message d'origine-----
> De : insight-owner@sourceware.org [mailto:insight-owner@sourceware.org]
> De la part de Keith Seitz
> Envoyé : Wednesday, May 06, 2009 5:30 PM
> À : Gene Smith
> Cc : insight@sources.redhat.com
> Objet : Re: Insight broken with latest tcl/tk
> 
> Gene Smith wrote:
> 
> >> ../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c: In function
> ‘gdb_loc’:
> >> ../../insight_sources/gdb/gdbtk/generic/gdbtk-cmds.c:2147: error:
> >> implicit declaration of function ‘read_pc’
> >> make[2]: *** [gdbtk-cmds.o] Error 1
> [snip]
> > gdbtk-cmds.c:(.text+0x3503): undefined reference to `read_pc'
> > gdbtk-cmds.c:(.text+0x3533): undefined reference to `read_pc'
> > collect2: ld returned 1 exit status
> 
> These are the same problem. On May 5 (yesterday), someone checked in a
> patch to remove read_pc. It is now apparently called
> "regcache_read_pc".
> 
> I'll fix this later today. Busy morning.
> 
> Keith
ChangeLog entry:

2009-05-06  Pierre Muller  <muller@ics.u-strasbg.fr>

        * Adapt to read_pc function removal.
        * genric/gdbtk-cmds.c: Add "cache.h" include.
        (gdb_loc): Use regcache_read_pc instead of read_pc.


$ cvs diff -up gdbtk/generic/gdbtk-cmds.c
Index: gdbtk/generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.109
diff -u -p -r1.109 gdbtk-cmds.c
--- gdbtk/generic/gdbtk-cmds.c  6 Apr 2009 23:33:32 -0000       1.109
+++ gdbtk/generic/gdbtk-cmds.c  6 May 2009 15:39:45 -0000
@@ -44,6 +44,7 @@
 #include "language.h"
 #include "target.h"
 #include "valprint.h"
+#include "regcache.h"

 /* tcl header files includes varargs.h unless HAS_STDARG is defined,
    but gdb uses stdarg.h, so make sure HAS_STDARG is defined.  */
@@ -2141,10 +2142,13 @@ gdb_loc (ClientData clientData, Tcl_Inte
       else
        {
          struct frame_info *frame;
+         CORE_ADDR frame_pc, current_pc;

          frame = get_selected_frame (NULL);
-
-         if (get_frame_pc (frame) != read_pc ())
+         current_pc = regcache_read_pc (get_current_regcache ());
+         frame_pc = get_frame_pc (frame);
+
+         if (frame_pc != current_pc)
            {
              /* Note - this next line is not correct on all architectures.
                 For a graphical debugger we really want to highlight the
@@ -2152,12 +2156,12 @@ gdb_loc (ClientData clientData, Tcl_Inte
                 Many architectures have the next instruction saved as the
                 pc on the stack, so what happens is the next instruction
                 is highlighted. FIXME */
-             pc = get_frame_pc (frame);
+             pc = frame_pc;
              find_frame_sal (frame, &sal);
            }
          else
            {
-             pc = read_pc ();
+             pc = current_pc;
              sal = find_pc_line (pc, 0);
            }
        }

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-06 15:46       ` Pierre Muller
@ 2009-05-06 15:48         ` Keith Seitz
  2009-05-06 15:53           ` Pierre Muller
  0 siblings, 1 reply; 21+ messages in thread
From: Keith Seitz @ 2009-05-06 15:48 UTC (permalink / raw)
  To: Pierre Muller; +Cc: insight

Pierre Muller wrote:
>  I wrote a minimal patch...
> allows insight to compile again...
> Should I commit it?

Yes, please! Thank you!

> PS: It compiles but is still unusable on my cygwin machine :(

I haven't forgotten about this (although it may seem so). I'll respond 
to that thread shortly.

Keith

^ permalink raw reply	[flat|nested] 21+ messages in thread

* RE: Insight broken with latest tcl/tk
  2009-05-06 15:48         ` Keith Seitz
@ 2009-05-06 15:53           ` Pierre Muller
  2009-05-07  4:02             ` Gene Smith
  0 siblings, 1 reply; 21+ messages in thread
From: Pierre Muller @ 2009-05-06 15:53 UTC (permalink / raw)
  To: 'Keith Seitz'; +Cc: insight



> -----Message d'origine-----
> De : insight-owner@sourceware.org [mailto:insight-owner@sourceware.org]
> De la part de Keith Seitz
> Envoyé : Wednesday, May 06, 2009 5:49 PM
> À : Pierre Muller
> Cc : insight@sources.redhat.com
> Objet : Re: Insight broken with latest tcl/tk
> 
> Pierre Muller wrote:
> >  I wrote a minimal patch...
> > allows insight to compile again...
> > Should I commit it?
> 
> Yes, please! Thank you!

  Thanks, committed.
 
> > PS: It compiles but is still unusable on my cygwin machine :(
> 
> I haven't forgotten about this (although it may seem so). I'll respond
> to that thread shortly.

  I will be happy if you found something out...

Pierre

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-06 15:53           ` Pierre Muller
@ 2009-05-07  4:02             ` Gene Smith
  2009-05-11 16:52               ` Dave Lawrence
  0 siblings, 1 reply; 21+ messages in thread
From: Gene Smith @ 2009-05-07  4:02 UTC (permalink / raw)
  To: insight

Pierre Muller wrote:
> 
>> -----Message d'origine-----
>> De : insight-owner@sourceware.org [mailto:insight-owner@sourceware.org]
>> De la part de Keith Seitz
>> Envoyé : Wednesday, May 06, 2009 5:49 PM
>> À : Pierre Muller
>> Cc : insight@sources.redhat.com
>> Objet : Re: Insight broken with latest tcl/tk
>>
>> Pierre Muller wrote:
>>>  I wrote a minimal patch...
>>> allows insight to compile again...
>>> Should I commit it?
>> Yes, please! Thank you!
> 
>   Thanks, committed.
>  
>>> PS: It compiles but is still unusable on my cygwin machine :(
>> I haven't forgotten about this (although it may seem so). I'll respond
>> to that thread shortly.
> 
>   I will be happy if you found something out...
> 
> Pierre
> 

After "cvs update" now builds OK on u9.04/x86_64 and runs as
6.8.50.20090507-cvs (from Help/About). Have not yet tried to debug and
ARM with it yet.  Thanks.

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-07  4:02             ` Gene Smith
@ 2009-05-11 16:52               ` Dave Lawrence
  2009-05-11 18:13                 ` Keith Seitz
  0 siblings, 1 reply; 21+ messages in thread
From: Dave Lawrence @ 2009-05-11 16:52 UTC (permalink / raw)
  To: insight

Gene Smith wrote:
> 
> After "cvs update" now builds OK on u9.04/x86_64 and runs as
> 6.8.50.20090507-cvs (from Help/About). Have not yet tried to debug and
> ARM with it yet.  Thanks.
> 
> 

Not for me it doesn't, I still get those undefined references at link
time.  eg

libgdb.a(ada-lang.o):(.rodata+0x1bf0): undefined reference to `ada_error'
libgdb.a(c-lang.o):(.rodata+0x348): undefined reference to `c_parse'
libgdb.a(c-lang.o):(.rodata+0x350): undefined reference to `c_error'
libgdb.a(c-lang.o):(.rodata+0x448): undefined reference to `c_parse'
libgdb.a(c-lang.o):(.rodata+0x450): undefined reference to `c_error'
libgdb.a(c-lang.o):(.rodata+0x548): undefined reference to `c_parse'
[snip]


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-11 16:52               ` Dave Lawrence
@ 2009-05-11 18:13                 ` Keith Seitz
  2009-05-12  9:41                   ` Dave Lawrence
  0 siblings, 1 reply; 21+ messages in thread
From: Keith Seitz @ 2009-05-11 18:13 UTC (permalink / raw)
  To: Dave Lawrence; +Cc: insight

Dave Lawrence wrote:

> libgdb.a(ada-lang.o):(.rodata+0x1bf0): undefined reference to `ada_error'
> libgdb.a(c-lang.o):(.rodata+0x348): undefined reference to `c_parse'
> libgdb.a(c-lang.o):(.rodata+0x350): undefined reference to `c_error'
> libgdb.a(c-lang.o):(.rodata+0x448): undefined reference to `c_parse'
> libgdb.a(c-lang.o):(.rodata+0x450): undefined reference to `c_error'
> libgdb.a(c-lang.o):(.rodata+0x548): undefined reference to `c_parse'
> [snip]

These functions are defined by c-exp.y. Do you have flex and bison 
installed?

Did c-exp.c get generated in your (gdb) build directory?

Keith

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-11 18:13                 ` Keith Seitz
@ 2009-05-12  9:41                   ` Dave Lawrence
  0 siblings, 0 replies; 21+ messages in thread
From: Dave Lawrence @ 2009-05-12  9:41 UTC (permalink / raw)
  To: Keith Seitz; +Cc: insight

Keith Seitz wrote:
>
> These functions are defined by c-exp.y. Do you have flex and bison
> installed?
>
I was missing bison.
> Did c-exp.c get generated in your (gdb) build directory?
>
Yes it did actually, but it just contained an empty declaration of main
(that also caused a compiler warning - type defaults to int). 
Installing bison fixed it, however I did have to delete the directory
and start again - make clean and make distclean didn't quite do the
job.  Fortunately I had taken a copy of the cvs checkout before I
attempted to do any builds so I could restore it to a genuine clean state.

I now have arm-elf-insight and sh-elf-insight installed successfully.  I
haven't really tried using them yet though.  I use remote serial on sh,
and both remote serial and remote jtag via tcp on arm - this isn't my
main PC but I'll make an effort at some point to try all 3 of these
configs in case I can give you any useful feedback about the leading
edge code.  Probably not this week though.

Thanks for your help.
Dave

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-05-03 17:35 Insight broken with latest tcl/tk Dave Lawrence
                   ` (2 preceding siblings ...)
  2009-05-06  4:13 ` Gene Smith
@ 2009-06-14  4:40 ` Gene Smith
  2009-06-15  3:56   ` Gene Smith
  3 siblings, 1 reply; 21+ messages in thread
From: Gene Smith @ 2009-06-14  4:40 UTC (permalink / raw)
  To: insight

Dave Lawrence wrote, On 05/03/2009 09:08 AM:
> It would appear that insight no longer works with the latest tcl/tk.
>
> The following error
> Can't find a usable tk.tcl in the following directories:
>      /usr/local/share/tk8.4 /usr/local/lib/tk8.4 /usr/lib/tk8.4
> /usr/local/library /usr/library /usr/tk8.4.1/library /tk8.4.1/library
>
> or similar seems to have been reported on several newsgroups / blogs etc
> however I have never seen a solution.
>

FWIW, this bug re-bit me when building insight-6.8 on fedora8 x86_64. 
This patch applied to insight's tk/generic/tk.h seems to fix it:
http://bugs.gentoo.org/attachment.cgi?id=161242


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: Insight broken with latest tcl/tk
  2009-06-14  4:40 ` Gene Smith
@ 2009-06-15  3:56   ` Gene Smith
  0 siblings, 0 replies; 21+ messages in thread
From: Gene Smith @ 2009-06-15  3:56 UTC (permalink / raw)
  To: insight

Gene Smith wrote, On 06/13/2009 11:12 PM:
>
> FWIW, this bug re-bit me when building insight-6.8 on fedora8 x86_64.
> This patch applied to insight's tk/generic/tk.h seems to fix it:
> http://bugs.gentoo.org/attachment.cgi?id=161242

Typo above: OK or fedora 8. Problem was with fedora 11.


^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2009-06-14  4:40 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-03 17:35 Insight broken with latest tcl/tk Dave Lawrence
2009-05-04 21:41 ` Kevin Buettner
2009-05-05  5:37 ` Gene Smith
2009-05-05 13:44   ` Gene Smith
2009-05-05 17:37     ` Kevin Buettner
2009-05-05 18:43       ` Gene Smith
2009-05-05 20:17         ` Kevin Buettner
2009-05-06  2:17           ` Gene Smith
2009-05-06  3:04             ` Gene Smith
2009-05-06  4:13 ` Gene Smith
2009-05-06  4:53   ` Gene Smith
2009-05-06 15:30     ` Keith Seitz
2009-05-06 15:46       ` Pierre Muller
2009-05-06 15:48         ` Keith Seitz
2009-05-06 15:53           ` Pierre Muller
2009-05-07  4:02             ` Gene Smith
2009-05-11 16:52               ` Dave Lawrence
2009-05-11 18:13                 ` Keith Seitz
2009-05-12  9:41                   ` Dave Lawrence
2009-06-14  4:40 ` Gene Smith
2009-06-15  3:56   ` Gene Smith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).