From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Hui Zhu'" <teawater@gmail.com>, <insight@sourceware.org>,
"'Keith Seitz'" <keiths@redhat.com>
Subject: Re: [PATCH] Fix gdbtk-cmds.c: get a build error
Date: Fri, 12 Mar 2010 18:28:00 -0000 [thread overview]
Message-ID: <m3ljdxbgtr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <000001cac1ef$084ed8d0$18ec8a70$@muller@ics-cnrs.unistra.fr> (Pierre Muller's message of "Fri, 12 Mar 2010 15:19:30 +0100")
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> The patch below fixes it.
Pierre> Checked in as obvious,
This patch isn't correct.
It will work for the time being, but it will break whenever we merge in
code that causes an objfile not to use psymtabs.
The rule is, only the psymtab implementation and debuginfo readers are
allowed to include psympriv.h. All other code must go through the
"quick" API.
I'm working on a replacement patch.
Tom
next prev parent reply other threads:[~2010-03-12 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 14:19 Hui Zhu
2010-03-12 17:17 ` [PATCH] Fix " Pierre Muller
2010-03-12 18:28 ` Tom Tromey [this message]
2010-03-12 18:32 ` Tom Tromey
2010-03-15 2:20 ` Keith Seitz
2010-03-17 5:44 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ljdxbgtr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=insight@sourceware.org \
--cc=keiths@redhat.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).