From: Mark Wielaard <mjw@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
GCJ-patches <java-patches@gcc.gnu.org>,
Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH] java: Use build_qualified_type instead of build_type_variant.
Date: Wed, 09 Jul 2014 10:58:00 -0000 [thread overview]
Message-ID: <1404903479.8859.16.camel@bordewijk.wildebeest.org> (raw)
In-Reply-To: <CAFiYyc0TRtcSN53U=Pd5B338YDbq1LodWwGunZ=V-9AH+U7jxw@mail.gmail.com>
On Wed, 2014-07-09 at 12:23 +0200, Richard Biener wrote:
> On Tue, Jul 8, 2014 at 10:12 PM, Mark Wielaard <mjw@redhat.com> wrote:
> > The java frontend is one of the only places where build_type_variant is
> > still used. New code should use build_qualified_type. See gcc/tree.h.
> >
> > Build and tested on x86_64-unknown-linux-gnu.
>
> Ok.
Thanks. Pushed.
> Can build_type_variant be removed now?
Not yet. There are still a few usages that are easy to change to
build_qualified_type like the ones in the java frontend.
But there are 3 cases that I haven't figured out yet. c-common, ada and
lto all use it in their implementation of handle_noreturn_attribute and
c-common and lto in handle_const_attribute. I think the c-common one is
correct, but maybe there is a reason for them to be slightly different.
Cheers,
Mark
prev parent reply other threads:[~2014-07-09 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 20:13 Mark Wielaard
2014-07-09 10:23 ` Richard Biener
2014-07-09 10:58 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404903479.8859.16.camel@bordewijk.wildebeest.org \
--to=mjw@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).