Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

[Joern Rennecke]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

Quoting "Joseph S. Myers" <joseph@codesourcery.com>:

> The c-opts.c change to include tm.h seems independent of the rest of the
> patch, and is incorrect since the file already has an explicit tm.h
> include with a comment saying why it's included.

Yes, I've left this bit out now.  It used to be necessary, but it has been
obsoleted by your c-opts.c patch last month.

> I think it would be a
> good idea for the java/expr.c include (which I can't approve, Java patches
> should best be CC:ed to java-patches) to have a comment saying what target
> macros are used

Added.

> Similar comments also apply to the fortran/trans-types.c change: send to
> the fortran list as well as gcc-patches, include a comment listing the
> target macros involved (BOOL_TYPE_SIZE CHAR_TYPE_SIZE DOUBLE_TYPE_SIZE
> FLOAT_TYPE_SIZE INT_TYPE_SIZE LIBGCC2_HAS_TF_MODE LONG_DOUBLE_TYPE_SIZE
> LONG_LONG_TYPE_SIZE LONG_TYPE_SIZE POINTER_SIZE SHORT_TYPE_SIZE
> SIZE_TYPE).

Instead of including SIZE_TYPE in this list, I've removed the #if 0 code
that did (not) use it.
I've also added 2011 to the Copyright years in touched files that  
didn't already
have it.

[-- Attachment #2: pr46500-patch-20110507-2.gz --]
[-- Type: application/x-gzip, Size: 29333 bytes --]

Ping: Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

[Joern Rennecke]

This patch hasn't been reviewed for a week:
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00582.html

Re: Ping: Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

[Tobias Burnus]

Joern Rennecke wrote:
> This patch hasn't been reviewed for a week:
> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00582.html
>

The Fortran bits are OK.

Tobias

PS: For those, who have not looked at the patch, the Fortran-relevant 
part is '#include "tm.h"' and the removal of "#if 0" code.


2010-05-07  Joern Rennecke <joern.rennecke@embecosm.com>

         PR middle-end/46500
gcc:
         * target.h: Don't include "tm.h" .
[...]
gcc/fortran:
         * trans-types.c: Include "tm.h" .
         [0] (c_size_t_size): Remove.

Re: Ping: Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

[Andrew Haley]

On 14/05/11 15:43, Tobias Burnus wrote:
> Joern Rennecke wrote:
>> This patch hasn't been reviewed for a week:
>> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00582.html
>>
> 
> The Fortran bits are OK.

As is the Java bit.

Andrew.

Ping^2: Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

[Joern Rennecke]

Except or the fortran bits (committed), this patch hasn't been reviewed for
two weeks:
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00582.html

Ping^3: Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

[Joern Rennecke]

Except or the fortran bits (committed), this patch hasn't been reviewed for
three weeks:
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00582.html

Re: Ping^3: Re: Updated^2: RFA: Fix middle-end/46500 (void * encapsulated)

[Andrew Haley]

On 30/05/11 04:26, Joern Rennecke wrote:
> Except or the fortran bits (committed), this patch hasn't been reviewed for
> three weeks:
> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00582.html

This is OK.  I said so already.

Andrew.