From: Matthias Klose <doko@ubuntu.com>
To: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
Cc: Jakub Jelinek <jakub@redhat.com>,
java-patches@gcc.gnu.org,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Disable static build for libjava
Date: Sat, 09 Jul 2011 15:38:00 -0000 [thread overview]
Message-ID: <4E1875CA.9050309@ubuntu.com> (raw)
In-Reply-To: <20110707203554.280270@gmx.net>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
On 07/07/2011 10:35 PM, Ralf Wildenhues wrote:
> Hi Matthias,
>
> On Thu, Jul 07, 2011 at 10:26:59PM +0200, Jakub Jelinek wrote:
>> On Thu, Jul 07, 2011 at 10:22:37PM +0200, Matthias Klose wrote:
>>> +AC_PROG_LIBTOOL
>
> This tests the wrong compiler and toolchain. The compiler you want
> to test doesn't exist yet at the time this configure script is run.
> So you might as well deduce the switch you need from a fixed set or
> other GCC configure data.
>
> Or you put AC_PROG_LIBTOOL in libjava/ but pass down the value of
> enable_static_libjava as --en/disable-static there.
here is the updated patch. AC_PROG_LIBTOOL is already called in libjava/
ok to install?
Matthias
[-- Attachment #2: j.diff --]
[-- Type: text/plain, Size: 2744 bytes --]
<toplevel>
2011-07-09 Matthias Klose <doko@ubuntu.com>
* Makefile.tpl (EXTRA_CONFIGARGS_LIBJAVA): Define.
* Makefile.def (target_modules/libjava): Pass
$(EXTRA_CONFIGARGS_LIBJAVA).
* configure.ac: Pass --disable-static in EXTRA_CONFIGARGS_LIBJAVA,
if not configured with --enable-static-libjava.
* Makefile.in: Regenerate.
* configure: Likewise.
gcc/
2011-07-09 Matthias Klose <doko@ubuntu.com>
* doc/install.texi: Document --enable-static-libjava.
Index: Makefile.tpl
===================================================================
--- Makefile.tpl (revision 176072)
+++ Makefile.tpl (working copy)
@@ -319,6 +319,8 @@
HOST_LIBELFLIBS = @libelflibs@
HOST_LIBELFINC = @libelfinc@
+EXTRA_CONFIGARGS_LIBJAVA = @EXTRA_CONFIGARGS_LIBJAVA@
+
# ----------------------------------------------
# Programs producing files for the BUILD machine
# ----------------------------------------------
Index: Makefile.def
===================================================================
--- Makefile.def (revision 176072)
+++ Makefile.def (working copy)
@@ -132,7 +132,8 @@
target_modules = { module= winsup; };
target_modules = { module= libgloss; no_check=true; };
target_modules = { module= libffi; };
-target_modules = { module= libjava; raw_cxx=true; };
+target_modules = { module= libjava; raw_cxx=true;
+ extra_configure_flags="$(EXTRA_CONFIGARGS_LIBJAVA)"; };
target_modules = { module= zlib; };
target_modules = { module= boehm-gc; };
target_modules = { module= rda; };
Index: configure.ac
===================================================================
--- configure.ac (revision 176072)
+++ configure.ac (working copy)
@@ -443,7 +443,21 @@
;;
esac
+AC_ARG_ENABLE(static-libjava,
+[AS_HELP_STRING([[--enable-static-libjava[=ARG]]],
+ [build static libjava @<:@default=no@:>@])],
+ENABLE_STATIC_LIBJAVA=$enableval,
+ENABLE_STATIC_LIBJAVA=no)
+enable_static_libjava=
+if test "${ENABLE_STATIC_LIBJAVA}" = "yes" ; then
+ enable_static_libjava=yes
+fi
+if test x$enable_static_libjava != xyes ; then
+ EXTRA_CONFIGARGS_LIBJAVA=--disable-static
+fi
+AC_SUBST(EXTRA_CONFIGARGS_LIBJAVA)
+
# Disable libmudflap on some systems.
if test x$enable_libmudflap = x ; then
case "${target}" in
Index: gcc/doc/install.texi
===================================================================
--- gcc/doc/install.texi (revision 176072)
+++ gcc/doc/install.texi (working copy)
@@ -1968,6 +1968,10 @@
@item --enable-browser-plugin
Build the gcjwebplugin web browser plugin.
+@item --enable-static-libjava
+Build static libraries in libjava. The default is to only build shared
+libraries.
+
@table @code
@item ansi
Use the single-byte @code{char} and the Win32 A functions natively,
next prev parent reply other threads:[~2011-07-09 15:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 16:28 Matthias Klose
2011-07-07 16:51 ` David Daney
2011-07-07 16:58 ` Matthias Klose
2011-07-07 17:02 ` David Daney
2011-07-07 17:56 ` Andrew Haley
2011-07-07 20:22 ` Matthias Klose
2011-07-07 20:27 ` Jakub Jelinek
2011-07-07 20:36 ` Ralf Wildenhues
2011-07-09 15:38 ` Matthias Klose [this message]
2011-07-11 12:47 ` Andrew Haley
2011-07-16 6:07 ` Ralf Wildenhues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1875CA.9050309@ubuntu.com \
--to=doko@ubuntu.com \
--cc=Ralf.Wildenhues@gmx.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).