public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Ralf Wildenhues" <Ralf.Wildenhues@gmx.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Matthias Klose <doko@ubuntu.com>,
	java-patches@gcc.gnu.org, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Disable static build for libjava
Date: Thu, 07 Jul 2011 20:36:00 -0000	[thread overview]
Message-ID: <20110707203554.280270@gmx.net> (raw)
In-Reply-To: <20110707202659.GT2687@tyan-ft48-01.lab.bos.redhat.com>

Hi Matthias,

On Thu, Jul 07, 2011 at 10:26:59PM +0200, Jakub Jelinek wrote:
> On Thu, Jul 07, 2011 at 10:22:37PM +0200, Matthias Klose wrote:
> > +AC_PROG_LIBTOOL

This tests the wrong compiler and toolchain.  The compiler you want
to test doesn't exist yet at the time this configure script is run.
So you might as well deduce the switch you need from a fixed set or
other GCC configure data.

Or you put AC_PROG_LIBTOOL in libjava/ but pass down the value of
enable_static_libjava as --en/disable-static there.

> > +if test x$enable_shared = xyes && test x$enable_static_libjava != xyes ; then
> > +  case $host_cpu in
> 
> Shouldn't this be $host_os instead of $host_cpu ?  cygwin* etc.
> don't look like host_cpu names...
> 
> > +  cygwin* | mingw* | pw32* | cegcc*)
> > +    ;;
> > +  *)
> > +    EXTRA_CONFIGARGS_LIBJAVA=--disable-static

Cheers,
Ralf

  reply	other threads:[~2011-07-07 20:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 16:28 Matthias Klose
2011-07-07 16:51 ` David Daney
2011-07-07 16:58   ` Matthias Klose
2011-07-07 17:02     ` David Daney
2011-07-07 17:56       ` Andrew Haley
2011-07-07 20:22         ` Matthias Klose
2011-07-07 20:27           ` Jakub Jelinek
2011-07-07 20:36             ` Ralf Wildenhues [this message]
2011-07-09 15:38               ` Matthias Klose
2011-07-11 12:47                 ` Andrew Haley
2011-07-16  6:07                 ` Ralf Wildenhues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110707203554.280270@gmx.net \
    --to=ralf.wildenhues@gmx.de \
    --cc=doko@ubuntu.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=java-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).