Unreviewed libffi, libgfortran, libitm patches

Unreviewed libffi, libgfortran, libitm patches

[Rainer Orth]

The following patches have remained unreviewed for two or three weeks:

	[libffi] Build 64-bit multilib for i?86-linux
	http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01011.html

In the absence of a listed libffi maintainer, it probably needs a global
reviewer.

	[libgfortran, libitm] Link with -shared-libgcc
	http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01382.html

This will need a fortran resp. libitm maintainer.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed libffi, libgfortran, libitm patches

[Richard Henderson]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

On 01/04/2012 11:27 PM, Rainer Orth wrote:
> 	[libgfortran, libitm] Link with -shared-libgcc
> 	http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01382.html
> 
> This will need a fortran resp. libitm maintainer.

Does the following alleviate the need for -shared-libgcc for libitm?


r~

[-- Attachment #2: z --]
[-- Type: text/plain, Size: 854 bytes --]

diff --git a/libitm/eh_cpp.cc b/libitm/eh_cpp.cc
index 6f302cd..a6a1851 100644
--- a/libitm/eh_cpp.cc
+++ b/libitm/eh_cpp.cc
@@ -45,6 +45,7 @@ void __cxa_throw (void *, void *, void *) { return; }
 void *__cxa_begin_catch (void *) { return NULL; }
 void *__cxa_end_catch (void) { return NULL; }
 void __cxa_tm_cleanup (void *, void *, unsigned int) { return; }
+void _Unwind_DeleteException (_Unwind_Exception *) { return; }
 #endif /* HAVE_ELF_STYLE_WEAKREF */
 
 }
diff --git a/libitm/libitm_i.h b/libitm/libitm_i.h
index b53792a..959d802 100644
--- a/libitm/libitm_i.h
+++ b/libitm/libitm_i.h
@@ -39,6 +39,10 @@
 #include "local_type_traits"
 #include "local_atomic"
 
+/* Don't require libgcc_s.so for exceptions.  */
+extern void _Unwind_DeleteException (_Unwind_Exception*) __attribute__((weak));
+
+
 #include "common.h"
 
 namespace GTM HIDDEN {

Re: Unreviewed libffi, libgfortran, libitm patches

[Richard Guenther]

On Thu, Jan 5, 2012 at 5:28 AM, Richard Henderson <rth@redhat.com> wrote:
> On 01/04/2012 11:27 PM, Rainer Orth wrote:
>>       [libgfortran, libitm] Link with -shared-libgcc
>>       http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01382.html
>>
>> This will need a fortran resp. libitm maintainer.
>
> Does the following alleviate the need for -shared-libgcc for libitm?

Do all targets support sth like weak relocs?

>
> r~

Re: Unreviewed libffi, libgfortran, libitm patches

[Richard Henderson]

On 01/05/2012 08:30 PM, Richard Guenther wrote:
> Do all targets support sth like weak relocs?

Nearly.  Those that don't probably don't pass the pthreads requirement.


r~

Re: Unreviewed libffi, libgfortran, libitm patches

[Rainer Orth]

Richard Henderson <rth@redhat.com> writes:

> On 01/04/2012 11:27 PM, Rainer Orth wrote:
>> 	[libgfortran, libitm] Link with -shared-libgcc
>> 	http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01382.html
>> 
>> This will need a fortran resp. libitm maintainer.
>
> Does the following alleviate the need for -shared-libgcc for libitm?

Yep.  I've bootstrapped with this patch on i386-pc-solaris2.11 with both
gas/Sun ld and gas/gld, with no regressions.  libitm.so is linked with
libgcc_s.so with Sun ld since -shared implies -shared-libgcc there, and
without with gld.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed libffi, libgfortran, libitm patches

[Rainer Orth]

Richard Henderson <rth@redhat.com> writes:

> On 01/04/2012 11:27 PM, Rainer Orth wrote:
>> 	[libgfortran, libitm] Link with -shared-libgcc
>> 	http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01382.html
>> 
>> This will need a fortran resp. libitm maintainer.
>
> Does the following alleviate the need for -shared-libgcc for libitm?

As mentioned, it did and also passed regtesting on alpha-dec-osf5.1b,
i386-pc-solaris2* and x86_64-unknown-linux-gnu.  Would you mind
committing the patch?

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed libffi, libgfortran, libitm patches

[Richard Henderson]

On 01/10/2012 03:06 AM, Rainer Orth wrote:
> Richard Henderson <rth@redhat.com> writes:
> 
>> On 01/04/2012 11:27 PM, Rainer Orth wrote:
>>> 	[libgfortran, libitm] Link with -shared-libgcc
>>> 	http://gcc.gnu.org/ml/gcc-patches/2011-12/msg01382.html
>>>
>>> This will need a fortran resp. libitm maintainer.
>>
>> Does the following alleviate the need for -shared-libgcc for libitm?
> 
> As mentioned, it did and also passed regtesting on alpha-dec-osf5.1b,
> i386-pc-solaris2* and x86_64-unknown-linux-gnu.  Would you mind
> committing the patch?

Done.


r~