public inbox for java-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch] let gjdoc accept -source 1.[567]
@ 2013-01-14 19:58 Matthias Klose
  2013-01-15  9:51 ` Andrew Haley
  0 siblings, 1 reply; 2+ messages in thread
From: Matthias Klose @ 2013-01-14 19:58 UTC (permalink / raw)
  To: GCJ-patches

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

this patch is now in classpath trunk. the compiler does accept the newer -source
versions, so gjdoc should do as well (with a warning).

ok for the trunk?
ok for the 4.7 branch as well? it looks safe, as it only tries to accept the
option, and maybe bails out later. at least it helps with unmodified sources
which are now built with a newer -source option.

  Matthias

[-- Attachment #2: libjava-gjdoc.diff --]
[-- Type: text/x-diff, Size: 1215 bytes --]

# DP: Let gjdoc accept -source 1.5|1.6|1.7. Addresses: #678945.

--- a/src/libjava/classpath/tools/gnu/classpath/tools/gjdoc/Main.java
+++ b/src/libjava/classpath/tools/gnu/classpath/tools/gjdoc/Main.java
@@ -1337,12 +1337,17 @@
           void process(String[] args)
           {
             option_source = args[0];
-            if (!"1.2".equals(option_source)
+            if ("1.5".equals(option_source)
+                || "1.6".equals(option_source)
+                || "1.7".equals(option_source)) {
+              System.err.println("WARNING: support for option -source " + option_source + " is experimental");
+            }
+            else if (!"1.2".equals(option_source)
                 && !"1.3".equals(option_source)
                 && !"1.4".equals(option_source)) {
 
-              throw new RuntimeException("Only he following values are currently"
-                                         + " supported for option -source: 1.2, 1.3, 1.4.");
+              throw new RuntimeException("Only the following values are currently"
+                                         + " supported for option -source: 1.2, 1.3, 1.4; experimental: 1.5, 1.6, 1.7.");
             }
           }
         });

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] let gjdoc accept -source 1.[567]
  2013-01-14 19:58 [patch] let gjdoc accept -source 1.[567] Matthias Klose
@ 2013-01-15  9:51 ` Andrew Haley
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Haley @ 2013-01-15  9:51 UTC (permalink / raw)
  To: Matthias Klose; +Cc: GCJ-patches

On 01/14/2013 07:58 PM, Matthias Klose wrote:
> ok for the trunk?
> ok for the 4.7 branch as well?

Yes.  Yes.  Not sure it really needs approval.

Andrew.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-15  9:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-14 19:58 [patch] let gjdoc accept -source 1.[567] Matthias Klose
2013-01-15  9:51 ` Andrew Haley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).